Skip to contentSkip to conversation

net: Exposing more skb fields in netif_receive_skb trace event

PATCH Superseded Edward Wu 1 participant 2 messages Jun 9, 2021 – Jun 23, 2021

Subsystems (3)
lore
Share & tools
lore

Edward Wu

author
#0 lore raw

PATCH 1/1 net: Exposing more skb fields in netif_receive_skb trace event

This exposing helps to analyze network behavior.

In performance tuning, we will check nr_frags to analyze GRO aggregation behavior. By this commit, we can enable netif_receive_skb trace event for dynamic debugging.

---
 include/trace/events/net.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
include/trace/events/net.h +7 -7
index 2399073c3afc..48aa7168b68f 100644
@@ -147,13 +147,6 @@ DEFINE_EVENT(net_dev_template, net_dev_queue,
 	TP_ARGS(skb)
 );
 
-DEFINE_EVENT(net_dev_template, netif_receive_skb,
-
-	TP_PROTO(struct sk_buff *skb),
-
-	TP_ARGS(skb)
-);
-
 DEFINE_EVENT(net_dev_template, netif_rx,
 
 	TP_PROTO(struct sk_buff *skb),
@@ -239,6 +232,13 @@ DEFINE_EVENT(net_dev_rx_verbose_template, napi_gro_receive_entry,
 	TP_ARGS(skb)
 );
 
+DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb,
+
+	TP_PROTO(const struct sk_buff *skb),
+
+	TP_ARGS(skb)
+);
+
 DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb_entry,
 
 	TP_PROTO(const struct sk_buff *skb),
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH RESEND 1/1 net: Exposing more skb fields in netif_receive_skb trace event

This exposing helps to analyze network behavior.

In performance tuning, we will check nr_frags to analyze GRO aggregation behavior. By this commit, we can enable netif_receive_skb trace event for dynamic debugging.

---
 include/trace/events/net.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
include/trace/events/net.h +7 -7
index 2399073c3afc..48aa7168b68f 100644
@@ -147,13 +147,6 @@ DEFINE_EVENT(net_dev_template, net_dev_queue,
 	TP_ARGS(skb)
 );
 
-DEFINE_EVENT(net_dev_template, netif_receive_skb,
-
-	TP_PROTO(struct sk_buff *skb),
-
-	TP_ARGS(skb)
-);
-
 DEFINE_EVENT(net_dev_template, netif_rx,
 
 	TP_PROTO(struct sk_buff *skb),
@@ -239,6 +232,13 @@ DEFINE_EVENT(net_dev_rx_verbose_template, napi_gro_receive_entry,
 	TP_ARGS(skb)
 );
 
+DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb,
+
+	TP_PROTO(const struct sk_buff *skb),
+
+	TP_ARGS(skb)
+);
+
 DEFINE_EVENT(net_dev_rx_verbose_template, netif_receive_skb_entry,
 
 	TP_PROTO(const struct sk_buff *skb),
Signature · 1 line
2.17.1