Skip to contentSkip to conversation

staging: rtl8723bs: convert function to static

PATCH In review Fabio Aiuto 2 participants 2 messages Jun 23, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: convert function to static

function chk_sta_is_alive() is used only inside core/rtw_ap.c so remove the prototype and convert it to static.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -2
index 23bbdf084631..3e2d8b735fc8 100644
@@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
 	pnetwork_mlmeext->IELength = offset + remainder_ielen;
 }
 
-u8 chk_sta_is_alive(struct sta_info *psta);
-u8 chk_sta_is_alive(struct sta_info *psta)
+static u8 chk_sta_is_alive(struct sta_info *psta)
 {
 	sta_update_last_rx_pkts(psta);
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Fabio Aiuto

function chk_sta_is_alive() is used only inside core/rtw_ap.c so remove the prototype and convert it to static.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 19 lines
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +1 -2
index 23bbdf084631..3e2d8b735fc8 100644
@@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
 	pnetwork_mlmeext->IELength = offset + remainder_ielen;
 }
 
-u8 chk_sta_is_alive(struct sta_info *psta);
-u8 chk_sta_is_alive(struct sta_info *psta)
+static u8 chk_sta_is_alive(struct sta_info *psta)
 {
 	sta_update_last_rx_pkts(psta);