Skip to contentSkip to conversation

Add AM64x SoC support to PRU remoteproc driver

PATCH In review Suman Anna 3 participants 6 messages Jun 23, 2021 – Jun 24, 2021

Subsystems (2)
lore
Share & tools
lore

Suman Anna

author
#0 lore raw

cover Add AM64x SoC support to PRU remoteproc driver

Hi All,

The following series updates the PRU remoteproc driver to support the PRU, RTU and Tx_PRU cores present within the ICSSG IP on AM64x SoCs. Patches are on top of latest rproc-next branch based on v5.13-rc1, commit 30da589dba53 ("dt-bindings: remoteproc: qcom: pas: Fix indentation warnings").

There are some minor differences around the PRU cores like different Broadside RAM (BSRAM) sizes, but otherwise behave functionally the same as the PRU cores on previous SoCs.

regards,
Suman

Suman Anna (2):
dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 drivers/remoteproc/pru_rproc.c                               | 3 +++
 2 files changed, 8 insertions(+)
Signature · 1 line
2.30.1
author
#1 lore raw

PATCH 1/2 dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs

The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs have the same set of two PRU cores, two RTU cores and two auxiliary PRU cores called Transmit PRUs (Tx_PRUs). There are some minor differences surrounding the PRU cores like different Broadside RAM (BSRAM) sizes w.r.t AM65x SR1.0 SoCs.

Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.

---
 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml +5 -0
index 63071eef1632..4f8435d49a62 100644
@@ -44,6 +44,9 @@ properties:
       - ti,j721e-pru    # for PRUs in K3 J721E SoC family
       - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
       - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
+      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
+      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
 
   reg:
     items:
@@ -68,6 +71,7 @@ if:
       enum:
         - ti,am654-rtu
         - ti,j721e-rtu
+        - ti,am642-rtu
 then:
   properties:
     $nodename:
@@ -79,6 +83,7 @@ else:
         enum:
           - ti,am654-tx-pru
           - ti,j721e-tx-pru
+          - ti,am642-tx-pru
   then:
     properties:
       $nodename:
Signature · 1 line
2.30.1
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs

Quoted 38 lines · Suman Anna

The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs have the same set of two PRU cores, two RTU cores and two auxiliary PRU cores called Transmit PRUs (Tx_PRUs). There are some minor differences surrounding the PRU cores like different Broadside RAM (BSRAM) sizes w.r.t AM65x SR1.0 SoCs.

Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.

---
  .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
  1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml +4 -0
index 63071eef1632..4f8435d49a62 100644
@@ -44,6 +44,9 @@ properties:
        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
+      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
+      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
 
    reg:
      items:
@@ -68,6 +71,7 @@ if:
        enum:
          - ti,am654-rtu
          - ti,j721e-rtu
+        - ti,am642-rtu
  then:
    properties:
      $nodename:

Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml else: · line 89

Quoted 7 lines
Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml +1 -0
@@ -79,6 +83,7 @@ else:
          enum:
            - ti,am654-tx-pru
            - ti,j721e-tx-pru
+          - ti,am642-tx-pru
    then:
      properties:
        $nodename:
Signature · 2 lines
Best regards,
grygorii
author
#3 lore raw

PATCH 2/2 remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

In reply to Suman Anna

The K3 AM64x family of SoCs have a ICSSG IP that is similar to the version on AM65x SR2.0 SoCs with some minor differences. The AM64x SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).

Enhance the existing PRU remoteproc driver to support all these PRU, RTU and Tx_PRU cores by using specific compatibles. The cores have the same memory copying limitations as on AM65x, so reuses the custom memcpy function within the driver's ELF loader implementation. The initial names for the firmware images for each PRU core are retrieved from DT nodes, and can be adjusted through sysfs if required.

---
 drivers/remoteproc/pru_rproc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/remoteproc/pru_rproc.c +3 -0
index e5778e476245..0ecf2675f5eb 100644
@@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
 	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
 	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
 	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
+	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
+	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
 	{},
 };
 MODULE_DEVICE_TABLE(of, pru_rproc_match);
Signature · 1 line
2.30.1
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

Quoted 24 lines · Suman Anna

The K3 AM64x family of SoCs have a ICSSG IP that is similar to the version on AM65x SR2.0 SoCs with some minor differences. The AM64x SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).

Enhance the existing PRU remoteproc driver to support all these PRU, RTU and Tx_PRU cores by using specific compatibles. The cores have the same memory copying limitations as on AM65x, so reuses the custom memcpy function within the driver's ELF loader implementation. The initial names for the firmware images for each PRU core are retrieved from DT nodes, and can be adjusted through sysfs if required.

---
  drivers/remoteproc/pru_rproc.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/remoteproc/pru_rproc.c +0 -0
index e5778e476245..0ecf2675f5eb 100644

drivers/remoteproc/pru_rproc.c static const struct of_device_id pru_rproc_match[] = { · line 902

Quoted 9 lines
drivers/remoteproc/pru_rproc.c +3 -0
@@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
  	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
  	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
  	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
+	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
+	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
  	{},
  };
  MODULE_DEVICE_TABLE(of, pru_rproc_match);
Signature · 2 lines
Best regards,
grygorii
maintainer Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

In reply to Suman Anna
Quoted 23 lines · Suman Anna

The K3 AM64x family of SoCs have a ICSSG IP that is similar to the version on AM65x SR2.0 SoCs with some minor differences. The AM64x SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).

Enhance the existing PRU remoteproc driver to support all these PRU, RTU and Tx_PRU cores by using specific compatibles. The cores have the same memory copying limitations as on AM65x, so reuses the custom memcpy function within the driver's ELF loader implementation. The initial names for the firmware images for each PRU core are retrieved from DT nodes, and can be adjusted through sysfs if required.

---
 drivers/remoteproc/pru_rproc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/remoteproc/pru_rproc.c +0 -0
index e5778e476245..0ecf2675f5eb 100644

drivers/remoteproc/pru_rproc.c static const struct of_device_id pru_rproc_match[] = { · line 900

Quoted 7 lines
drivers/remoteproc/pru_rproc.c +3 -0
@@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
 	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
 	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
 	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
+	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
+	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
 	{},
Quoted 5 lines
drivers/remoteproc/pru_rproc.c +0 -0
 };
 MODULE_DEVICE_TABLE(of, pru_rproc_match);
Signature · 1 line
2.30.1