Skip to contentSkip to conversation

libtraceevent: Free "->" token in process_entry()

PATCH New Steven Rostedt 1 participant 1 message Jun 24, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtraceevent: Free "->" token in process_entry()

From: "Steven Rostedt (VMware)" <[email protected]>

Fixing an issue with parsing "(REC)->" when it expected "REC->", changed the test of "->" to read into a "token" variable instead of just "expecting" it. This was needed to test for the ")" case. But since it is now read into a token, that token needs to be freed. But that was missed.

Free the token.

This was found by the libtracefs "make test_mem" tests.

Fixes 62823da1 ("libtraceevent: Handle parsing of "(REC)->" case")
---
 src/event-parse.c | 2 ++
 1 file changed, 2 insertions(+)
src/event-parse.c +2 -0
index 94e2b90..de28b3b 100644
@@ -2325,6 +2325,8 @@ process_entry(struct tep_event *event __maybe_unused, struct tep_print_arg *arg,
 	if (test_type_token(type, token,  TEP_EVENT_OP, "->"))
 		goto out_free;
 
+	free_token(token);
+
 	if (read_expect_type(TEP_EVENT_ITEM, &token) < 0)
 		goto out_free;
 	field = token;
Signature · 1 line
2.29.2