mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
PATCH 1/1 mmc: sdhci-pci-gli: Finetune GL9763E L1 Entry Delay
Finetune the L1 entry delay to 20us for better balance of performance and battery life.
--- drivers/mmc/host/sdhci-pci-gli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +2 -2
@@ -90,7 +90,7 @@#define PCIE_GLI_9763E_CFG2 0x8A4#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19) -#define GLI_9763E_CFG2_L1DLY_MID 0x54 +#define GLI_9763E_CFG2_L1DLY_MID 0x50#define PCIE_GLI_9763E_MMC_CTRL 0x960#define GLI_9763E_HS400_SLOW BIT(3)
@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)pci_read_config_dword (pdev,PCIE_GLI_9763E_CFG2 , &value); value &= ~GLI_9763E_CFG2_L1DLY ; -/* set ASPM L1 entry delay to 21us */ +/* set ASPM L1 entry delay to 20us */ value |=FIELD_PREP (GLI_9763E_CFG2_L1DLY ,GLI_9763E_CFG2_L1DLY_MID );pci_write_config_dword (pdev,PCIE_GLI_9763E_CFG2 , value);
Signature · 1 line
2.27.0
Quoted 4 lines · Renius Chen
Finetune the L1 entry delay to 20us for better balance of performance and battery life.
Signed-off-by Renius Chen <[email protected]>
Quoted 27 lines
--- drivers/mmc/host/sdhci-pci-gli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-gli.c +2
-2@@ -90,7 +90,7 @@#define PCIE_GLI_9763E_CFG2 0x8A4#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19) -#define GLI_9763E_CFG2_L1DLY_MID 0x54 +#define GLI_9763E_CFG2_L1DLY_MID 0x50#define PCIE_GLI_9763E_MMC_CTRL 0x960#define GLI_9763E_HS400_SLOW BIT(3)@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)pci_read_config_dword (pdev,PCIE_GLI_9763E_CFG2 , &value); value &= ~GLI_9763E_CFG2_L1DLY ; -/* set ASPM L1 entry delay to 21us */ +/* set ASPM L1 entry delay to 20us */ value |=FIELD_PREP (GLI_9763E_CFG2_L1DLY ,GLI_9763E_CFG2_L1DLY_MID );pci_write_config_dword (pdev,PCIE_GLI_9763E_CFG2 , value);
Quoted 14 lines · Renius Chen
Finetune the L1 entry delay to 20us for better balance of performance and battery life.
Signed-off-by Renius Chen <[email protected]>--- drivers/mmc/host/sdhci-pci-gli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-gli.c +0
-0
drivers/mmc/host/sdhci-pci-gli.c line 93
Quoted 5 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-1@@ -90,7 +90,7 @@#define PCIE_GLI_9763E_CFG2 0x8A4#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19) -#define GLI_9763E_CFG2_L1DLY_MID 0x54 +#define GLI_9763E_CFG2_L1DLY_MID 0x50
We just changed from 21us to 20us. Really, how big of a difference can this make?
Moreover, I suppose the difference is related to the running use case. No?
If you really want this, at least I want an ack from Ben for it, then let's be done with it.
Kind regards
Uffe
Quoted 15 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-2#define PCIE_GLI_9763E_MMC_CTRL 0x960#define GLI_9763E_HS400_SLOW BIT(3)@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)pci_read_config_dword (pdev,PCIE_GLI_9763E_CFG2 , &value); value &= ~GLI_9763E_CFG2_L1DLY ; -/* set ASPM L1 entry delay to 21us */ +/* set ASPM L1 entry delay to 20us */ value |=FIELD_PREP (GLI_9763E_CFG2_L1DLY ,GLI_9763E_CFG2_L1DLY_MID );pci_write_config_dword (pdev,PCIE_GLI_9763E_CFG2 , value); --2.27.0
Ulf Hansson <[email protected]> 於 2021年6月30日 週三 下午11:16寫道:
Quoted 25 lines · Renius Chen
Quoted 14 lines
Finetune the L1 entry delay to 20us for better balance of performance and battery life.
Signed-off-by Renius Chen <[email protected]>--- drivers/mmc/host/sdhci-pci-gli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-gli.c +0
-0drivers/mmc/host/sdhci-pci-gli.c line 93
Quoted 5 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-1@@ -90,7 +90,7 @@#define PCIE_GLI_9763E_CFG2 0x8A4#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19) -#define GLI_9763E_CFG2_L1DLY_MID 0x54 +#define GLI_9763E_CFG2_L1DLY_MID 0x50We just changed from 21us to 20us. Really, how big of a difference can this make?
Quoted 8 lines
Moreover, I suppose the difference is related to the running use case. No?
If you really want this, at least I want an ack from Ben for it, then let's be done with it.
Kind regards
Uffe
Yes, according to the result of our customer's PLT test for battery life, It will pass the test with 20us and will not pass the test with 21us. I'll ask Ben for acking this, thank you.
Quoted 15 lines
Quoted 15 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-2#define PCIE_GLI_9763E_MMC_CTRL 0x960#define GLI_9763E_HS400_SLOW BIT(3)@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)pci_read_config_dword (pdev,PCIE_GLI_9763E_CFG2 , &value); value &= ~GLI_9763E_CFG2_L1DLY ; -/* set ASPM L1 entry delay to 21us */ +/* set ASPM L1 entry delay to 20us */ value |=FIELD_PREP (GLI_9763E_CFG2_L1DLY ,GLI_9763E_CFG2_L1DLY_MID );pci_write_config_dword (pdev,PCIE_GLI_9763E_CFG2 , value); --2.27.0
Hi Ulf and Renius,
Quoted 31 lines
Ulf Hansson <[email protected]> 於 2021年6月30日 週三 下午11:16寫道:
Quoted 30 lines · Renius Chen
Quoted 14 lines
Finetune the L1 entry delay to 20us for better balance of performance and battery life.
Signed-off-by Renius Chen <[email protected]>--- drivers/mmc/host/sdhci-pci-gli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mmc/host/sdhci-pci-gli.c +0
-0drivers/mmc/host/sdhci-pci-gli.c line 93
Quoted 5 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-1@@ -90,7 +90,7 @@#define PCIE_GLI_9763E_CFG2 0x8A4#define GLI_9763E_CFG2_L1DLY GENMASK(28, 19) -#define GLI_9763E_CFG2_L1DLY_MID 0x54 +#define GLI_9763E_CFG2_L1DLY_MID 0x50We just changed from 21us to 20us. Really, how big of a difference can this make?
Moreover, I suppose the difference is related to the running use case. No?
If you really want this, at least I want an ack from Ben for it, then let's be done with it.
Quoted 6 lines
Quoted 3 lines
Kind regards
UffeYes, according to the result of our customer's PLT test for battery life, It will pass the test with 20us and will not pass the test with 21us. I'll ask Ben for acking this, thank you.
Using 20us can pass the battery life testing, but need to consider that it may reduce some performance.
So this patch should be together with 4k patch or after 4k patch. Then I can acked Acked-by: Ben Chuang <[email protected]>.
Best regards,
Ben
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
drivers/mmc/host/sdhci-pci-gli.c +1
-2#define PCIE_GLI_9763E_MMC_CTRL 0x960#define GLI_9763E_HS400_SLOW BIT(3)@@ -810,7 +810,7 @@ static void gli_set_gl9763e(struct sdhci_pci_slot *slot)pci_read_config_dword (pdev,PCIE_GLI_9763E_CFG2 , &value); value &= ~GLI_9763E_CFG2_L1DLY ; -/* set ASPM L1 entry delay to 21us */ +/* set ASPM L1 entry delay to 20us */ value |=FIELD_PREP (GLI_9763E_CFG2_L1DLY ,GLI_9763E_CFG2_L1DLY_MID );pci_write_config_dword (pdev,PCIE_GLI_9763E_CFG2 , value); --2.27.0