drm/qxl: Remove empty qxl_gem_prime_mmap()
Subsystems (4)
Thomas Zimmermann
maintainerPATCH 1/1 drm/qxl: Remove empty qxl_gem_prime_mmap()
The function qxl_gem_prime_mmap() returns an error. The two callers of gem_prime_mmap are drm_fbdev_fb_mmap() and drm_gem_dmabuf_mmap(), which both already handle NULL-callbacks with an error code. So clear gem_prime_mmap in qxl and remove qxl_gem_prime_mmap().
Signed-off-by Thomas Zimmermann <[email protected]>
--- drivers/gpu/drm/qxl/qxl_drv.c | 1 - drivers/gpu/drm/qxl/qxl_drv.h | 2 -- drivers/gpu/drm/qxl/qxl_prime.c | 6 ------ 3 files changed, 9 deletions(-)
drivers/gpu/drm/qxl/qxl_drv.c +0 -1
@@ -281,7 +281,6 @@ static struct drm_driver qxl_driver = { .prime_handle_to_fd = drm_gem_prime_handle_to_fd, .prime_fd_to_handle = drm_gem_prime_fd_to_handle, .gem_prime_import_sg_table = qxl_gem_prime_import_sg_table, - .gem_prime_mmap = qxl_gem_prime_mmap, .fops = &qxl_fops, .ioctls = qxl_ioctls, .irq_handler = qxl_irq_handler,
drivers/gpu/drm/qxl/qxl_drv.h +0 -2
@@ -434,8 +434,6 @@ struct drm_gem_object *qxl_gem_prime_import_sg_table(int qxl_gem_prime_vmap (struct drm_gem_object *obj,struct dma_buf_map *map);void qxl_gem_prime_vunmap (struct drm_gem_object *obj,struct dma_buf_map *map); -int qxl_gem_prime_mmap (struct drm_gem_object *obj, -struct vm_area_struct *vma);/* qxl_irq.c */ int qxl_irq_init (struct qxl_device *qdev);
drivers/gpu/drm/qxl/qxl_prime.c +0 -6
@@ -73,9 +73,3 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj,qxl_bo_vunmap (bo); } - -int qxl_gem_prime_mmap (struct drm_gem_object *obj, -struct vm_area_struct *area) -{ -return -ENOSYS ; -}
Signature · 1 line
2.32.0
Quoted 4 lines · Thomas Zimmermann
The function
qxl_gem_prime_mmap()returns an error. The two callers ofgem_prime_mmaparedrm_fbdev_fb_mmap()anddrm_gem_dmabuf_mmap(), which both already handle NULL-callbacks with an error code. So cleargem_prime_mmapin qxl and removeqxl_gem_prime_mmap().
Reviewed-by Gerd Hoffmann <[email protected]>