Skip to contentSkip to conversation

test: remove hack for private header inclusion

PATCH Applied David Marchand 3 participants 4 messages Jun 24, 2021 – Jul 6, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: remove hack for private header inclusion

This hack was needed with the make build system.
With meson, any private header from a library is visible as long as a dependency to this library is expressed.

---
 app/test/test_eal_fs.c         | 3 +--
 app/test/test_memzone.c        | 3 ++-
 app/test/test_telemetry_json.c | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)
app/test/test_eal_fs.c +1 -2
index bb93b82a43..39ac6961b3 100644
@@ -8,8 +8,7 @@
 #include <string.h>
 #include <errno.h>
 
-/* eal_filesystem.h is not a public header file, so use relative path */
-#include "../../lib/eal/common/eal_filesystem.h"
+#include "eal_filesystem.h"
 
 static int
 test_parse_sysfs_value(void)
app/test/test_memzone.c +2 -1
index 03a9d1d3bb..27b8b52fcd 100644
@@ -18,7 +18,8 @@
 #include <rte_string_fns.h>
 #include <rte_errno.h>
 #include <rte_malloc.h>
-#include "../../lib/eal/common/malloc_elem.h"
+
+#include "malloc_elem.h"
 
 #include "test.h"
 
app/test/test_telemetry_json.c +2 -1
index 3171ab12ec..790181d316 100644
@@ -4,7 +4,8 @@
 
 #include <string.h>
 
-#include "../../lib/telemetry/telemetry_json.h"
+#include "telemetry_json.h"
+
 #include "test.h"
 
 static int
Signature · 1 line
2.23.0
author Acked-by Bruce Richardson Acked-by Tyler Retzlaff on v1 1/1 Applied
#3 lore raw
In reply to David Marchand
Quoted 6 lines · David Marchand

This hack was needed with the make build system.
With meson, any private header from a library is visible as long as a dependency to this library is expressed.

Applied.

Signature · 1 line
David Marchand