Skip to contentSkip to conversation

net: prepare the outer ipv4 hdr for checksum

PATCH In review Mohsin Kazmi 2 participants 2 messages Jun 24, 2021 – Jun 29, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: prepare the outer ipv4 hdr for checksum

Preparation the headers for the hardware offload misses the outer ipv4 checksum offload.
It results in bad checksum computed by hardware NIC.

This patch fixes the issue by setting the outer ipv4 checksum field to 0.

---
 lib/net/rte_net.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
lib/net/rte_net.h +11 -1
index 434435ffa2..e47365099e 100644
@@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)
 	if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG)))
 		return 0;
 
-	if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))
+	if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {
 		inner_l3_offset += m->outer_l2_len + m->outer_l3_len;
+		/*
+		 * prepare outer ipv4 header checksum by setting it to 0,
+		 * in order to be computed by hardware NICs.
+		 */
+		if (ol_flags & PKT_TX_OUTER_IP_CKSUM) {
+			ipv4_hdr = rte_pktmbuf_mtod_offset(m,
+					struct rte_ipv4_hdr *, m->outer_l2_len);
+			ipv4_hdr->hdr_checksum = 0;
+		}
+	}
 
 	/*
 	 * Check if headers are fragmented.
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Mohsin Kazmi
Sent: Thursday, June 24, 2021 11:28 PM
To: [email protected]
Cc: Mohsin Kazmi <[email protected]>; Kinsella, Ray <[email protected]>; Olivier Matz <[email protected]>
Subject: [dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum

Quoted 5 lines

Preparation the headers for the hardware offload misses the outer ipv4 checksum offload.
It results in bad checksum computed by hardware NIC.

This patch fixes the issue by setting the outer ipv4 checksum field to 0.

As this a fix, below fix line and cc stable could be added

Fixes 4fb7e803eb1a ("ethdev: add Tx preparation")
Quoted 4 lines