Skip to contentSkip to conversation

ARM: dts: NSP: add Meraki MX64/MX65 series

PATCH Superseded Matthew Hagan 4 participants 11 messages Jun 25, 2021 – Aug 5, 2021

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover ARM: dts: NSP: add Meraki MX64/MX65 series

Changes from v2:
- Introduce boards to Makefile in same patch as the board dts is added (Vladimir Oltean)
- Use alphabetical ordering for labels (Vladimir Oltean)
- Remove address-cells and size-cells in qca8337 switch nodes (Vladimir Oltean)
- Remove "cpu" labels from switch nodes' CPU ports (Vladimir Oltean)
- Various LED fixes, utilising dt-bindings/leds/common.h and correctly specifying LEDs in the form "led-N" and with the color/function/ function-enumerator properties.
- Fix PWM LEDs and corresponding pinctrl bindings. (Vladimir Oltean)

The following changes were submitted as a separate series:
- Introduce patches to disable QSPI by default and enable where used (Vladimir Oltean)
- Move mdio@18032000 node from board related file to SoC (Vladimir Oltean)
- In addition to above, relocate mdio-mux to bcm-nsp.dtsi and fix the resulting usb3_phy issues

Changes from v3:
- Sort labels on mx64 a0 dts files into alphabetical order as well
- move include directives for input/input.h and leds/common.h to bcm958625-mx6x-common.dtsi
- Whitespace fixes in bcm958625-mx6x-common.dtsi
- rename "senao_nvram" partition to "nvram"

Matthew Hagan (4):
ARM: dts: NSP: Add common bindings for MX64/MX65
ARM: dts: NSP: Add DT files for Meraki MX64 series
ARM: dts: NSP: Add DT files for Meraki MX65 series
dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65

 .../devicetree/bindings/arm/bcm/brcm,nsp.yaml |   6 +
 arch/arm/boot/dts/Makefile                    |   6 +
 arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 279 ++++++++++++++++++
 .../boot/dts/bcm958625-meraki-kingpin.dtsi    | 163 ++++++++++
 .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts |  45 +++
 arch/arm/boot/dts/bcm958625-meraki-mx64.dts   |  15 +
 .../boot/dts/bcm958625-meraki-mx64w-a0.dts    |  55 ++++
 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts  |  23 ++
 arch/arm/boot/dts/bcm958625-meraki-mx65.dts   |  15 +
 arch/arm/boot/dts/bcm958625-meraki-mx65w.dts  |  23 ++
 .../dts/bcm958625-meraki-mx6x-common.dtsi     | 143 +++++++++
 11 files changed, 773 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx65.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx65w.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi
Signature · 1 line
2.26.3
#1 lore raw

PATCH v4 1/4 ARM: dts: NSP: Add common bindings for MX64/MX65

These bindings are required for all Meraki MX64/MX65 devices. These common bindings include memory (2GB), PWM LEDs, AMAC, I2C (AT24), NAND partitions, EHCI, OHCI and pinctrl.

---
 .../dts/bcm958625-meraki-mx6x-common.dtsi     | 143 ++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi
arch/arm/boot/dts/bcm958625-meraki-mx6x-common.dtsi new file +143 -0
new file mode 100644
index 000000000000..b2336bd0e19b
@@ -0,0 +1,143 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Common Bindings for Cisco Meraki MX64 (Kingpin) and MX65 (Alamo) devices.
+ *
+ * Copyright (C) 2020-2021 Matthew Hagan <[email protected]>
+ */
+
+#include "bcm-nsp.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x60000000 0x80000000>;
+	};
+
+	pwm-leds {
+		compatible = "pwm-leds";
+
+		led-1 {
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_RED>;
+			pwms = <&pwm 1 50000>;
+			max-brightness = <255>;
+		};
+
+		led-2 {
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_GREEN>;
+			pwms = <&pwm 2 50000>;
+			max-brightness = <255>;
+		};
+
+		led-3 {
+			function = LED_FUNCTION_INDICATOR;
+			color = <LED_COLOR_ID_BLUE>;
+			pwms = <&pwm 3 50000>;
+			max-brightness = <255>;
+		};
+	};
+};
+
+&amac2 {
+	status = "okay";
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+
+	at24@50 {
+		compatible = "atmel,24c64";
+		pagesize = <32>;
+		reg = <0x50>;
+	};
+};
+
+&L2 {
+	arm,io-coherent;
+	prefetch-data = <1>;
+	prefetch-instr = <1>;
+};
+
+&nand {
+	nandcs@0 {
+		compatible = "brcm,nandcs";
+		reg = <0>;
+		nand-on-flash-bbt;
+
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		nand-ecc-strength = <24>;
+		nand-ecc-step-size = <1024>;
+
+		brcm,nand-oob-sector-size = <27>;
+
+		partition@0 {
+			label = "u-boot";
+			reg = <0x0 0x80000>;
+			read-only;
+		};
+
+		partition@80000 {
+			label = "shmoo";
+			reg = <0x80000 0x80000>;
+			read-only;
+		};
+
+		partition@100000 {
+			label = "bootkernel1";
+			reg = <0x100000 0x300000>;
+		};
+
+		partition@400000 {
+			label = "nvram";
+			reg = <0x400000 0x100000>;
+		};
+
+		partition@500000 {
+			label = "bootkernel2";
+			reg = <0x500000 0x300000>;
+		};
+
+		partition@800000 {
+			label = "ubi";
+			reg = <0x800000 0x3f700000>;
+		};
+	};
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pwm_leds>;
+
+	pwm_leds: pwm_leds {
+		function = "pwm";
+		groups = "pwm1_grp", "pwm2_grp", "pwm3_grp";
+	};
+};
+
+&pwm {
+	status = "okay";
+	#pwm-cells = <2>;
+};
+
+&uart0 {
+	clock-frequency = <62500000>;
+	status = "okay";
+};
Signature · 1 line
2.26.3
#2 lore raw

PATCH v4 2/4 ARM: dts: NSP: Add DT files for Meraki MX64 series

In reply to Matthew Hagan

MX64 & MX64W Hardware info:
- CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
- RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
- Storage: 1 GB (Micron MT29F8G08ABACA)
- Networking: BCM58625 internal switch (5x 1GbE ports)
- USB: 1x USB2.0
- Serial: Internal header
- WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus

This patch adds the Meraki MX64 series-specific bindings. Since some devices make use of the older A0 SoC, changes need to be made to accommodate this case, including removal of coherency options and modification to the secondary-boot-reg.

---
 arch/arm/boot/dts/Makefile                    |   4 +
 .../boot/dts/bcm958625-meraki-kingpin.dtsi    | 163 ++++++++++++++++++
 .../arm/boot/dts/bcm958625-meraki-mx64-a0.dts |  45 +++++
 arch/arm/boot/dts/bcm958625-meraki-mx64.dts   |  15 ++
 .../boot/dts/bcm958625-meraki-mx64w-a0.dts    |  55 ++++++
 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts  |  23 +++
 6 files changed, 305 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx64w.dts
arch/arm/boot/dts/Makefile +4 -0
index f8f09c5066e7..83560b05f797 100644
@@ -154,6 +154,10 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \
 	bcm958525xmc.dtb \
 	bcm958622hr.dtb \
 	bcm958623hr.dtb \
+	bcm958625-meraki-mx64.dtb \
+	bcm958625-meraki-mx64-a0.dtb \
+	bcm958625-meraki-mx64w.dtb \
+	bcm958625-meraki-mx64w-a0.dtb \
 	bcm958625hr.dtb \
 	bcm988312hr.dtb \
 	bcm958625k.dtb
arch/arm/boot/dts/bcm958625-meraki-kingpin.dtsi new file +163 -0

163 lines not on this page · raw message

arch/arm/boot/dts/bcm958625-meraki-mx64-a0.dts new file +45 -0

45 lines not on this page · raw message

arch/arm/boot/dts/bcm958625-meraki-mx64.dts new file +15 -0
new file mode 100644
index 000000000000..58addd69688a
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Device Tree Bindings for Cisco Meraki MX64 with B0+ SoC.
+ *
+ * Copyright (C) 2020-2021 Matthew Hagan <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "bcm958625-meraki-kingpin.dtsi"
+
+/ {
+	model = "Cisco Meraki MX64";
+	compatible = "meraki,mx64", "brcm,bcm58625", "brcm,nsp";
+};
arch/arm/boot/dts/bcm958625-meraki-mx64w-a0.dts new file +55 -0

55 lines not on this page · raw message

arch/arm/boot/dts/bcm958625-meraki-mx64w.dts new file +23 -0
new file mode 100644
index 000000000000..8d37cd56c093
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Device Tree Bindings for Cisco Meraki MX64W with B0+ SoC.
+ *
+ * Copyright (C) 2020-2021 Matthew Hagan <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "bcm958625-meraki-kingpin.dtsi"
+
+/ {
+	model = "Cisco Meraki MX64W";
+	compatible = "meraki,mx64w", "brcm,bcm58625", "brcm,nsp";
+};
+
+&pcie0 {
+	status = "okay";
+};
+
+&pcie1 {
+	status = "okay";
+};
Signature · 1 line
2.26.3
maintainer
#3 lore raw

Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series

Quoted 10 lines · Matthew Hagan

MX64 & MX64W Hardware info:
- CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
- RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
- Storage: 1 GB (Micron MT29F8G08ABACA)
- Networking: BCM58625 internal switch (5x 1GbE ports)
- USB: 1x USB2.0
- Serial: Internal header
- WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus

Quoted 6 lines

This patch adds the Meraki MX64 series-specific bindings. Since some devices make use of the older A0 SoC, changes need to be made to accommodate this case, including removal of coherency options and modification to the secondary-boot-reg.

Removing the dma-coherent flags in the dts file seemed really odd until I read the text above. It would seem more logical to me to have a .dtsi file that has all the a0 revision specific changes, and include that from the dts file.

On the other hand, the /chosen, /aliases and /memory nodes that you have in the .dtsi file should probably get moved into the .dts files, as these tend to be board specific settings, even if the examples you have are all the same.

Arnd

#4 lore raw

Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series

Quoted 15 lines · Arnd Bergmann
Quoted 14 lines · Matthew Hagan

MX64 & MX64W Hardware info:
- CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
- RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
- Storage: 1 GB (Micron MT29F8G08ABACA)
- Networking: BCM58625 internal switch (5x 1GbE ports)
- USB: 1x USB2.0
- Serial: Internal header
- WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus

This patch adds the Meraki MX64 series-specific bindings. Since some devices make use of the older A0 SoC, changes need to be made to accommodate this case, including removal of coherency options and modification to the secondary-boot-reg.

Quoted 5 lines
Quoted 1 line

Removing the dma-coherent flags in the dts file seemed really odd until I read the text above. It would seem more logical to me to have a .dtsi file that has all the a0 revision specific changes, and include that from the dts file.

How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the appropriate secondary-boot-reg and dma-coherent (or lack of) properties, which then include bcm-nsp.dtsi. Thus we can also avoid use of /delete-property/. Would this be preferable?

Quoted 5 lines

On the other hand, the /chosen, /aliases and /memory nodes that you have in the .dtsi file should probably get moved into the .dts files, as these tend to be board specific settings, even if the examples you have are all the same.

I did not come across any convention regarding this, though there are plenty of cases where the /chosen, /aliases and /memory nodes are defined in a .dtsi file and used by multiple similar boards. Also note in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we not prefer to avoid having 6x duplication?

Quoted 2 lines

Arnd

Matthew

#5 lore raw

Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series

Quoted 23 lines · Matthew Hagan
Quoted 15 lines · Arnd Bergmann
Quoted 14 lines · Matthew Hagan

MX64 & MX64W Hardware info:
- CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
- RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
- Storage: 1 GB (Micron MT29F8G08ABACA)
- Networking: BCM58625 internal switch (5x 1GbE ports)
- USB: 1x USB2.0
- Serial: Internal header
- WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus

This patch adds the Meraki MX64 series-specific bindings. Since some devices make use of the older A0 SoC, changes need to be made to accommodate this case, including removal of coherency options and modification to the secondary-boot-reg.

Quoted 5 lines
Quoted 1 line

Removing the dma-coherent flags in the dts file seemed really odd until I read the text above. It would seem more logical to me to have a .dtsi file that has all the a0 revision specific changes, and include that from the dts file.

Quoted 4 lines

How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the appropriate secondary-boot-reg and dma-coherent (or lack of) properties, which then include bcm-nsp.dtsi. Thus we can also avoid use of /delete-property/. Would this be preferable?

Is there any way that the Ax platforms could use a small shim between the boot loader and the kernel which could all of the necessary DT adaptation so the kernel only contains a single Device Tree source?

Using something like this:

https://github.com/zonque/pxa-impedance-matcher/

could be useful.

Quoted 17 lines
Quoted 6 lines

On the other hand, the /chosen, /aliases and /memory nodes that you have in the .dtsi file should probably get moved into the .dts files, as these tend to be board specific settings, even if the examples you have are all the same.

I did not come across any convention regarding this, though there are plenty of cases where the /chosen, /aliases and /memory nodes are defined in a .dtsi file and used by multiple similar boards. Also note in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we not prefer to avoid having 6x duplication?

Quoted 2 lines

Arnd

Matthew

Signature · 1 line
Florian
maintainer
#6 lore raw

Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series

Quoted 7 lines · Florian Fainelli
Quoted 6 lines · Matthew Hagan

On 25/06/2021 10:59, Arnd Bergmann wrote:

How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the appropriate secondary-boot-reg and dma-coherent (or lack of) properties, which then include bcm-nsp.dtsi. Thus we can also avoid use of /delete-property/. Would this be preferable?

That sounds good to me.

Quoted 9 lines

Is there any way that the Ax platforms could use a small shim between the boot loader and the kernel which could all of the necessary DT adaptation so the kernel only contains a single Device Tree source?

Using something like this:

https://github.com/zonque/pxa-impedance-matcher/

could be useful.

I don't think that's necessary here, but I wouldn't object if someone finds it useful and does the work. ;-)

Quoted 10 lines
Quoted 10 lines
Quoted 4 lines

On the other hand, the /chosen, /aliases and /memory nodes that you have in the .dtsi file should probably get moved into the .dts files, as these tend to be board specific settings, even if the examples you have are all the same.

I did not come across any convention regarding this, though there are plenty of cases where the /chosen, /aliases and /memory nodes are defined in a .dtsi file and used by multiple similar boards. Also note in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we not prefer to avoid having 6x duplication?

We are not too consistent about this, and there are cases in which a .dtsi file is used for a family of boards using different SoCs rather than a particular SoC or SoC family.

In the bcm-nsp.dtsi example you mention, I would move the aliases into the board files, mainly because there is no guarantee that each board exposes both uarts and all three on-chip ethernet ports. Note that the aliases are supposed to match whatever label you have on the board, not what the numbers are in the chip.

Arnd

#7 lore raw

PATCH v4 3/4 ARM: dts: NSP: Add DT files for Meraki MX65 series

In reply to Matthew Hagan

MX65 & MX65W Hardware info:
- CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz
- RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR)
- Storage: 1 GB (Micron MT29F8G08ABACA)
- Networking: BCM58625 switch (2x 1GbE ports)

    2x Qualcomm QCA8337 switches (10x 1GbE ports total)

- PSE: Broadcom BCM59111KMLG connected to LAN ports 11 & 12
- USB: 1x USB2.0
- Serial: Internal header
- WLAN(MX65W Only): 2x Broadcom BCM43520KMLG on the PCI bus.

Note that a driver and firmware image for the BCM59111 PSE has been released under GPL, but this is not present in the kernel.

---
 arch/arm/boot/dts/Makefile                    |   2 +
 arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 279 ++++++++++++++++++
 arch/arm/boot/dts/bcm958625-meraki-mx65.dts   |  15 +
 arch/arm/boot/dts/bcm958625-meraki-mx65w.dts  |  23 ++
 4 files changed, 319 insertions(+)
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx65.dts
 create mode 100644 arch/arm/boot/dts/bcm958625-meraki-mx65w.dts
arch/arm/boot/dts/Makefile +2 -0
index 83560b05f797..033d9604db60 100644
@@ -158,6 +158,8 @@ dtb-$(CONFIG_ARCH_BCM_NSP) += \
 	bcm958625-meraki-mx64-a0.dtb \
 	bcm958625-meraki-mx64w.dtb \
 	bcm958625-meraki-mx64w-a0.dtb \
+	bcm958625-meraki-mx65.dtb \
+	bcm958625-meraki-mx65w.dtb \
 	bcm958625hr.dtb \
 	bcm988312hr.dtb \
 	bcm958625k.dtb
arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi new file +279 -0

279 lines not on this page · raw message

arch/arm/boot/dts/bcm958625-meraki-mx65.dts new file +15 -0
new file mode 100644
index 000000000000..a196b3053a59
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Device Tree Bindings for Cisco Meraki MX65.
+ *
+ * Copyright (C) 2020-2021 Matthew Hagan <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "bcm958625-meraki-alamo.dtsi"
+
+/ {
+	model = "Cisco Meraki MX65";
+	compatible = "meraki,mx65", "brcm,bcm58625", "brcm,nsp";
+};
arch/arm/boot/dts/bcm958625-meraki-mx65w.dts new file +23 -0
new file mode 100644
index 000000000000..bfdaa1a6a046
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Device Tree Bindings for Cisco Meraki MX65W.
+ *
+ * Copyright (C) 2020-2021 Matthew Hagan <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "bcm958625-meraki-alamo.dtsi"
+
+/ {
+	model = "Cisco Meraki MX65W";
+	compatible = "meraki,mx65w", "brcm,bcm58625", "brcm,nsp";
+};
+
+&pcie0 {
+	status = "okay";
+};
+
+&pcie1 {
+	status = "okay";
+};
Signature · 1 line
2.26.3
#8 lore raw

PATCH v4 4/4 dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65

In reply to Matthew Hagan

Add bindings for the Meraki MX64/MX65 series.

---
 Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml +6 -0
index 78dfa315f3d0..7d184ba7d180 100644
@@ -62,6 +62,12 @@ properties:
           - enum:
               - brcm,bcm958625hr
               - brcm,bcm958625k
+              - meraki,mx64
+              - meraki,mx64-a0
+              - meraki,mx64w
+              - meraki,mx64w-a0
+              - meraki,mx65
+              - meraki,mx65w
           - const: brcm,bcm58625
           - const: brcm,nsp
 
Signature · 1 line
2.26.3
maintainer
#9 lore raw

Re: [PATCH v4 4/4] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65

Quoted 7 lines · Matthew Hagan

Add bindings for the Meraki MX64/MX65 series.

---
 Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

#10 lore raw
In reply to Matthew Hagan
Quoted 24 lines · Matthew Hagan

Changes from v2:
- Introduce boards to Makefile in same patch as the board dts is added (Vladimir Oltean)
- Use alphabetical ordering for labels (Vladimir Oltean)
- Remove address-cells and size-cells in qca8337 switch nodes (Vladimir Oltean)
- Remove "cpu" labels from switch nodes' CPU ports (Vladimir Oltean)
- Various LED fixes, utilising dt-bindings/leds/common.h and correctly specifying LEDs in the form "led-N" and with the color/function/ function-enumerator properties.
- Fix PWM LEDs and corresponding pinctrl bindings. (Vladimir Oltean)

The following changes were submitted as a separate series:
- Introduce patches to disable QSPI by default and enable where used (Vladimir Oltean)
- Move mdio@18032000 node from board related file to SoC (Vladimir Oltean)
- In addition to above, relocate mdio-mux to bcm-nsp.dtsi and fix the resulting usb3_phy issues

Changes from v3:
- Sort labels on mx64 a0 dts files into alphabetical order as well
- move include directives for input/input.h and leds/common.h to

    bcm958625-mx6x-common.dtsi
Quoted 8 lines

- Whitespace fixes in bcm958625-mx6x-common.dtsi
- rename "senao_nvram" partition to "nvram"

Matthew Hagan (4):
ARM: dts: NSP: Add common bindings for MX64/MX65
ARM: dts: NSP: Add DT files for Meraki MX64 series
ARM: dts: NSP: Add DT files for Meraki MX65 series
dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65

Matt, should I be expecting a v5 based on Arnd's comments?

Signature · 1 line
Florian