mlx5 updates 2021-06-26
Subsystems (6)
From: Saeed Mahameed <[email protected]>
Hi Dave, Jakub,
This series provides misc updates to mlx5 driver.
For more information please see tag log below.
Please pull and let me know if there is any problem.
Sorry about the weekend submission but I have an important submission coming up "XDP/AF_XDP support for switchdev representors", so I thought maybe I should clean up my queue of all this clutter, before submitting the XDP for reps.
Thanks,
Saeed.
---
---
The following changes since commit ff8744b5eb116fdf9b80a6ff774393afac7325bd:
Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue (2021-06-25 11:59:11 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-updates-2021-06-26
for you to fetch changes up to 5589b8f1a2c74670cbca9ea98756dbb8f92569b8:
net/mlx5e: Add IPsec support to uplink representor (2021-06-26 00:31:25 -0700)
----------------------------------------------------------------
mlx5-updates-2021-06-26
This series provides small updates to mlx5 driver.
1) Increase hairpin buffer size
2) Improve performance in SF allocation
3) Add IPsec support to uplink representor
4) Add stats for number of deleted kTLS TX offloaded connections
5) Add support for flow sampler in SW steering
----------------------------------------------------------------
Ariel Levkovich (1):
net/mlx5: Increase hairpin buffer size
Eli Cohen (1):
net/mlx5: SF, Improve performance in SF allocation
Raed Salem (1):
net/mlx5e: Add IPsec support to uplink representor
Tariq Toukan (1):
net/mlx5e: kTLS, Add stats for number of deleted kTLS TX offloaded connections
Yevgeny Kliteynik (2):
net/mlx5: Compare sampler flow destination ID in fs_core net/mlx5: DR, Add support for flow sampler offload
.../ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 2 +- .../ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 1 + .../net/ethernet/mellanox/mlx5/core/en_accel/tls.h | 1 + .../mellanox/mlx5/core/en_accel/tls_stats.c | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 7 +++ drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 4 +- .../net/ethernet/mellanox/mlx5/core/sf/hw_table.c | 23 +++++---- .../mellanox/mlx5/core/steering/dr_action.c | 55 ++++++++++++++++++++++ .../ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 33 +++++++++++++ .../mellanox/mlx5/core/steering/dr_types.h | 14 ++++++ .../ethernet/mellanox/mlx5/core/steering/fs_dr.c | 17 +++++-- .../ethernet/mellanox/mlx5/core/steering/mlx5dr.h | 3 ++ include/linux/mlx5/mlx5_ifc.h | 5 ++ 14 files changed, 152 insertions(+), 16 deletions(-)
PATCH 1/6 net/mlx5: Compare sampler flow destination ID in fs_core
From: Yevgeny Kliteynik <[email protected]>
When comparing sampler flow destinations,
in fs_core, consider sampler ID as well.
--- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +3 -1
@@ -1504,7 +1504,9 @@ static bool mlx5_flow_dests_cmp(struct mlx5_flow_destination *d1, (d1->type ==MLX5_FLOW_DESTINATION_TYPE_TIR && d1->tir_num == d2->tir_num) || (d1->type ==MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE_NUM && - d1->ft_num == d2->ft_num)) + d1->ft_num == d2->ft_num) || + (d1->type ==MLX5_FLOW_DESTINATION_TYPE_FLOW_SAMPLER && + d1->sampler_id == d2->sampler_id)) return true; }
Signature · 1 line
2.31.1
Re: [net-next 1/6] net/mlx5: Compare sampler flow destination ID in fs_core
This series was applied to netdev/net-next.git (refs/heads/master):
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
Quoted 9 lines · On Sat, 26 Jun 2021 00:44:12 -0700 you wrote:
From: Yevgeny Kliteynik <[email protected]>
When comparing sampler flow destinations,
infs_core, consider sampler ID as well.Signed-off-by Yevgeny Kliteynik <[email protected]>Signed-off-by Saeed Mahameed <[email protected]>[...]
Here is the summary with links:
- [net-next,1/6] net/mlx5: Compare sampler flow destination ID in fs_core
https://git.kernel.org/netdev/net-next/c/6f8515568e69 - [net-next,2/6] net/mlx5: DR, Add support for flow sampler offload https://git.kernel.org/netdev/net-next/c/1ab6dc35e914 - [net-next,3/6] net/mlx5: Increase hairpin buffer size https://git.kernel.org/netdev/net-next/c/6cdc686aa316 - [net-next,4/6] net/mlx5: SF, Improve performance in SF allocation https://git.kernel.org/netdev/net-next/c/5bd8cee2b9c5 - [net-next,5/6] net/mlx5e: kTLS, Add stats for number of deleted kTLS TX offloaded connections https://git.kernel.org/netdev/net-next/c/e8c827614530 - [net-next,6/6] net/mlx5e: Add IPsec support to uplink representor https://git.kernel.org/netdev/net-next/c/5589b8f1a2c7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
PATCH 2/6 net/mlx5: DR, Add support for flow sampler offload
In reply to Saeed MahameedFrom: Yevgeny Kliteynik <[email protected]>
Add SW steering support for sFlow / flow sampler action.
--- .../mellanox/mlx5/core/steering/dr_action.c | 55 +++++++++++++++++++ .../mellanox/mlx5/core/steering/dr_cmd.c | 33 +++++++++++ .../mellanox/mlx5/core/steering/dr_types.h | 14 +++++ .../mellanox/mlx5/core/steering/fs_dr.c | 17 +++++- .../mellanox/mlx5/core/steering/mlx5dr.h | 3 + include/linux/mlx5/mlx5_ifc.h | 5 ++ 6 files changed, 124 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c +55 -0
@@ -31,6 +31,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_TNL_L2_TO_L2] = DR_ACTION_STATE_DECAP,
@@ -45,6 +46,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_DECAP, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_DECAP, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -57,6 +59,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_ENCAP, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_ENCAP, },
@@ -64,6 +67,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -74,6 +78,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_POP_VLAN] = DR_ACTION_STATE_MODIFY_VLAN,
@@ -86,6 +91,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_TAG] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_TNL_L2_TO_L2] = DR_ACTION_STATE_DECAP,
@@ -104,6 +110,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NO_ACTION] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP, [DR_ACTION_TYP_L2_TO_TNL_L3] = DR_ACTION_STATE_ENCAP,
@@ -114,11 +121,13 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_ENCAP] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_ENCAP, }, [DR_ACTION_STATE_MODIFY_HDR] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP, [DR_ACTION_TYP_L2_TO_TNL_L3] = DR_ACTION_STATE_ENCAP,
@@ -128,6 +137,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_MODIFY_VLAN] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_PUSH_VLAN] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -137,6 +147,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NON_TERM] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP, [DR_ACTION_TYP_L2_TO_TNL_L3] = DR_ACTION_STATE_ENCAP,
@@ -152,6 +163,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NO_ACTION] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_TNL_L2_TO_L2] = DR_ACTION_STATE_DECAP, [DR_ACTION_TYP_TNL_L3_TO_L2] = DR_ACTION_STATE_DECAP,
@@ -166,6 +178,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_DECAP, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_MODIFY_HDR] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_POP_VLAN] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_VPORT] = DR_ACTION_STATE_TERM,
@@ -178,11 +191,13 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_QP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_VPORT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR ] =DR_ACTION_STATE_ENCAP , }, [DR_ACTION_STATE_MODIFY_HDR] = { [DR_ACTION_TYP_DROP ] =DR_ACTION_STATE_TERM , [DR_ACTION_TYP_FT ] =DR_ACTION_STATE_TERM , + [DR_ACTION_TYP_SAMPLER ] =DR_ACTION_STATE_TERM , [DR_ACTION_TYP_CTR ] =DR_ACTION_STATE_MODIFY_HDR , [DR_ACTION_TYP_VPORT ] =DR_ACTION_STATE_TERM , [DR_ACTION_TYP_L2_TO_TNL_L2 ] =DR_ACTION_STATE_ENCAP ,
@@ -192,6 +207,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_MODIFY_VLAN] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_POP_VLAN] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_VPORT] = DR_ACTION_STATE_TERM,
@@ -203,6 +219,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NON_TERM] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_TNL_L2_TO_L2] = DR_ACTION_STATE_DECAP, [DR_ACTION_TYP_TNL_L3_TO_L2] = DR_ACTION_STATE_DECAP,
@@ -221,6 +238,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NO_ACTION] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_MODIFY_HDR] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -233,11 +251,13 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_ENCAP, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_VPORT ] =DR_ACTION_STATE_TERM , }, [DR_ACTION_STATE_MODIFY_HDR] = { [DR_ACTION_TYP_DROP ] =DR_ACTION_STATE_TERM , [DR_ACTION_TYP_FT ] =DR_ACTION_STATE_TERM , + [DR_ACTION_TYP_SAMPLER ] =DR_ACTION_STATE_TERM , [DR_ACTION_TYP_CTR ] =DR_ACTION_STATE_MODIFY_HDR , [DR_ACTION_TYP_L2_TO_TNL_L2 ] =DR_ACTION_STATE_ENCAP , [DR_ACTION_TYP_L2_TO_TNL_L3 ] =DR_ACTION_STATE_ENCAP ,
@@ -248,6 +268,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_MODIFY_VLAN] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_PUSH_VLAN] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_MODIFY_VLAN, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -258,6 +279,7 @@ next_action_state[DR_ACTION_DOMAIN_MAX][DR_ACTION_STATE_MAX][DR_ACTION_TYP_MAX] [DR_ACTION_STATE_NON_TERM] = { [DR_ACTION_TYP_DROP] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_FT] = DR_ACTION_STATE_TERM, + [DR_ACTION_TYP_SAMPLER] = DR_ACTION_STATE_TERM, [DR_ACTION_TYP_CTR] = DR_ACTION_STATE_NON_TERM, [DR_ACTION_TYP_MODIFY_HDR] = DR_ACTION_STATE_MODIFY_HDR, [DR_ACTION_TYP_L2_TO_TNL_L2] = DR_ACTION_STATE_ENCAP,
@@ -519,6 +541,10 @@ int mlx5dr_actions_build_ste_arr(struct mlx5dr_matcher *matcher, attr.reformat.size = action->reformat->size; attr.reformat.id = action->reformat->id;break ; +case DR_ACTION_TYP_SAMPLER : + attr.final_icm_addr = rx_rule ? action->sampler->rx_icm_addr : + action->sampler->tx_icm_addr; +break ;case DR_ACTION_TYP_VPORT : attr.hit_gvmi = action->vport->caps->vhca_gvmi; dest_action = action;
@@ -612,6 +638,7 @@ static unsigned int action_size[DR_ACTION_TYP_MAX] = { [DR_ACTION_TYP_VPORT] = sizeof(struct mlx5dr_action_vport), [DR_ACTION_TYP_PUSH_VLAN] = sizeof(struct mlx5dr_action_push_vlan), [DR_ACTION_TYP_INSERT_HDR] = sizeof(struct mlx5dr_action_reformat), + [DR_ACTION_TYP_SAMPLER] = sizeof(struct mlx5dr_action_sampler), }; static struct mlx5dr_action *
@@ -824,6 +851,31 @@ struct mlx5dr_action *mlx5dr_action_create_tag(u32 tag_value)return action; } +struct mlx5dr_action * +mlx5dr_action_create_flow_sampler (struct mlx5dr_domain *dmn,u32 sampler_id) +{ +struct mlx5dr_action *action; +u64 icm_rx, icm_tx; +int ret; + + ret =mlx5dr_cmd_query_flow_sampler (dmn->mdev, sampler_id, + &icm_rx, &icm_tx); +if (ret) +return NULL ; + + action =dr_action_create_generic (DR_ACTION_TYP_SAMPLER ); +if (!action) +return NULL ; + + action->sampler->dmn = dmn; + action->sampler->sampler_id = sampler_id; + action->sampler->rx_icm_addr = icm_rx; + action->sampler->tx_icm_addr = icm_tx; + +refcount_inc (&dmn->refcount); +return action; +} + static int dr_action_verify_reformat_params(enum mlx5dr_action_type reformat_type, struct mlx5dr_domain *dmn,
@@ -1624,6 +1676,9 @@ int mlx5dr_action_destroy(struct mlx5dr_action *action)kfree (action->rewrite->data);refcount_dec (&action->rewrite->dmn->refcount);break ; +case DR_ACTION_TYP_SAMPLER : +refcount_dec (&action->sampler->dmn->refcount); +break ;default :break ; }
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c +33 -0
@@ -228,6 +228,36 @@ int mlx5dr_cmd_query_flow_table(struct mlx5_core_dev *dev,return 0 ; } +int mlx5dr_cmd_query_flow_sampler (struct mlx5_core_dev *dev, +u32 sampler_id, +u64 *rx_icm_addr, +u64 *tx_icm_addr) +{ +u32 out[MLX5_ST_SZ_DW (query_sampler_obj_out)] = {}; +u32 in[MLX5_ST_SZ_DW (general_obj_in_cmd_hdr)] = {}; +void *attr; +int ret; + +MLX5_SET (general_obj_in_cmd_hdr, in, opcode, +MLX5_CMD_OP_QUERY_GENERAL_OBJECT ); +MLX5_SET (general_obj_in_cmd_hdr, in, obj_type, +MLX5_GENERAL_OBJECT_TYPES_SAMPLER ); +MLX5_SET (general_obj_in_cmd_hdr, in, obj_id, sampler_id); + + ret =mlx5_cmd_exec (dev, in,sizeof (in), out,sizeof (out)); +if (ret) +return ret; + + attr =MLX5_ADDR_OF (query_sampler_obj_out, out, sampler_object); + + *rx_icm_addr =MLX5_GET64 (sampler_obj, attr, + sw_steering_icm_address_rx); + *tx_icm_addr =MLX5_GET64 (sampler_obj, attr, + sw_steering_icm_address_tx); + +return 0 ; +} +int mlx5dr_cmd_sync_steering (struct mlx5_core_dev *mdev) {u32 in[MLX5_ST_SZ_DW (sync_steering_in)] = {};
@@ -711,6 +741,9 @@ int mlx5dr_cmd_set_fte(struct mlx5_core_dev *dev, fte->dest_arr[i].vport.reformat_id); }break ; +case MLX5_FLOW_DESTINATION_TYPE_FLOW_SAMPLER : + id = fte->dest_arr[i].sampler_id; +break ;default : id = fte->dest_arr[i].tir_num; }
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_types.h +14 -0
@@ -124,6 +124,7 @@ enum mlx5dr_action_type {DR_ACTION_TYP_POP_VLAN ,DR_ACTION_TYP_PUSH_VLAN ,DR_ACTION_TYP_INSERT_HDR , +DR_ACTION_TYP_SAMPLER , DR_ACTION_TYP_MAX, };
@@ -919,6 +920,13 @@ struct mlx5dr_action_reformat {u8 param_1; }; +struct mlx5dr_action_sampler { +struct mlx5dr_domain *dmn; +u64 rx_icm_addr; +u64 tx_icm_addr; +u32 sampler_id; +}; +struct mlx5dr_action_dest_tbl {u8 is_fw_tbl:1 ;union {
@@ -962,6 +970,7 @@ struct mlx5dr_action {void *data;struct mlx5dr_action_rewrite *rewrite;struct mlx5dr_action_reformat *reformat; +struct mlx5dr_action_sampler *sampler;struct mlx5dr_action_dest_tbl *dest_tbl;struct mlx5dr_action_ctr *ctr;struct mlx5dr_action_vport *vport;
@@ -1116,6 +1125,10 @@ int mlx5dr_cmd_query_gvmi(struct mlx5_core_dev *mdev, bool other_vport, u16 vport_number, u16 *gvmi);int mlx5dr_cmd_query_esw_caps (struct mlx5_core_dev *mdev,struct mlx5dr_esw_caps *caps); +int mlx5dr_cmd_query_flow_sampler (struct mlx5_core_dev *dev, +u32 sampler_id, +u64 *rx_icm_addr, +u64 *tx_icm_addr);int mlx5dr_cmd_sync_steering (struct mlx5_core_dev *mdev); int mlx5dr_cmd_set_fte_modify_and_vport(struct mlx5_core_dev *mdev, u32 table_type,
@@ -1303,6 +1316,7 @@ struct mlx5dr_cmd_flow_destination_hw_info {u32 ft_num;u32 ft_id;u32 counter_id; +u32 sampler_id;struct {u16 num;u16 vhca_id;
drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c +14 -3
@@ -387,7 +387,7 @@ static int mlx5_cmd_dr_create_fte(struct mlx5_flow_root_namespace *ns,if (fte->action.action &MLX5_FLOW_CONTEXT_ACTION_FWD_DEST ) {list_for_each_entry (dst, &fte->node.children, node.list) {enum mlx5_flow_destination_type type = dst->dest_attr.type; -u32 ft_id; +u32 id;if (num_actions ==MLX5_FLOW_CONTEXT_ACTION_MAX || num_term_actions >=MLX5_FLOW_CONTEXT_ACTION_MAX ) {
@@ -425,9 +425,20 @@ static int mlx5_cmd_dr_create_fte(struct mlx5_flow_root_namespace *ns, num_term_actions++;break ;case MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE_NUM : - ft_id = dst->dest_attr.ft_num; + id = dst->dest_attr.ft_num; tmp_action =mlx5dr_action_create_dest_table_num (domain, - ft_id); + id); +if (!tmp_action) { + err = -ENOMEM ; + goto free_actions; + } + fs_dr_actions[fs_dr_num_actions++] = tmp_action; + term_actions[num_term_actions++].dest = tmp_action; +break ; +case MLX5_FLOW_DESTINATION_TYPE_FLOW_SAMPLER : + id = dst->dest_attr.sampler_id; + tmp_action =mlx5dr_action_create_flow_sampler (domain, + id);if (!tmp_action) { err = -ENOMEM ; goto free_actions;
drivers/net/ethernet/mellanox/mlx5/core/steering/mlx5dr.h +3 -0
@@ -100,6 +100,9 @@ struct mlx5dr_action *mlx5dr_action_create_drop(void);struct mlx5dr_action *mlx5dr_action_create_tag (u32 tag_value); +struct mlx5dr_action * +mlx5dr_action_create_flow_sampler (struct mlx5dr_domain *dmn,u32 sampler_id); +struct mlx5dr_action *mlx5dr_action_create_flow_counter (u32 counter_id);
include/linux/mlx5/mlx5_ifc.h +5 -0
@@ -11083,6 +11083,11 @@ struct mlx5_ifc_create_sampler_obj_in_bits {struct mlx5_ifc_sampler_obj_bits sampler_object; }; +struct mlx5_ifc_query_sampler_obj_out_bits { +struct mlx5_ifc_general_obj_out_cmd_hdr_bits general_obj_out_cmd_hdr; +struct mlx5_ifc_sampler_obj_bits sampler_object; +}; +enum {MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_KEY_SIZE_128 =0x0 ,MLX5_GENERAL_OBJECT_TYPE_ENCRYPTION_KEY_KEY_SIZE_256 =0x1 ,
Signature · 1 line
2.31.1
PATCH 3/6 net/mlx5: Increase hairpin buffer size
In reply to Saeed MahameedFrom: Ariel Levkovich <[email protected]>
The max packet size a hairpin queue is able to handle is determined by the total hairpin buffer size divided by 4.
Currently the buffer size is set to 32KB which makes the max packet size to be 8KB and doesn't support jumbo frames of size 9KB.
This change increases the buffer size to 64KB to increase the max frame size and support 9KB frames.
--- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +1 -1
@@ -846,7 +846,7 @@ static int mlx5e_hairpin_flow_add(struct mlx5e_priv *priv, hash_hairpin_info(peer_id, match_prio));mutex_unlock (&priv->fs.tc.hairpin_tbl_lock); - params.log_data_size =15 ; + params.log_data_size =16 ; params.log_data_size =min_t (u8, params.log_data_size,MLX5_CAP_GEN (priv->mdev, log_max_hairpin_wq_data_sz)); params.log_data_size = max_t(u8, params.log_data_size,
Signature · 1 line
2.31.1
PATCH 4/6 net/mlx5: SF, Improve performance in SF allocation
In reply to Saeed MahameedFrom: Eli Cohen <[email protected]>
Avoid second traversal on the SF table by recording the first free entry and using it in case the looked up entry was not found in the table.
--- .../ethernet/mellanox/mlx5/core/sf/hw_table.c | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/sf/hw_table.c +13 -10
@@ -73,26 +73,29 @@ static int mlx5_sf_hw_table_id_alloc(struct mlx5_sf_hw_table *table, u32 control u32 usr_sfnum) {struct mlx5_sf_hwc_table *hwc; +int free_idx =-1 ;int i; hwc =mlx5_sf_controller_to_hwc (table->dev, controller);if (!hwc->sfs)return -ENOSPC ; -/* Check if sf with same sfnum already exists or not. */ for (i =0 ; i < hwc->max_fn; i++) { +if (!hwc->sfs[i].allocated && free_idx ==-1 ) { + free_idx = i; +continue ; + } +if (hwc->sfs[i].allocated && hwc->sfs[i].usr_sfnum == usr_sfnum)return -EEXIST ; } -/* Find the free entry and allocate the entry from the array */ -for (i =0 ; i < hwc->max_fn; i++) { -if (!hwc->sfs[i].allocated) { - hwc->sfs[i].usr_sfnum = usr_sfnum; - hwc->sfs[i].allocated = true; -return i; - } - } -return -ENOSPC ; + +if (free_idx ==-1 ) +return -ENOSPC ; + + hwc->sfs[free_idx].usr_sfnum = usr_sfnum; + hwc->sfs[free_idx].allocated = true; +return free_idx; }static void mlx5_sf_hw_table_id_free (struct mlx5_sf_hw_table *table,u32 controller,int id)
Signature · 1 line
2.31.1
PATCH 5/6 net/mlx5e: kTLS, Add stats for number of deleted kTLS TX offloaded connections
In reply to Saeed MahameedFrom: Tariq Toukan <[email protected]>
Expose ethtool SW counter for the number of kTLS device-offloaded TX connections that are finished and deleted.
--- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_stats.c | 1 + 3 files changed, 3 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +1 -0
@@ -138,6 +138,7 @@ void mlx5e_ktls_del_tx(struct net_device *netdev, struct tls_context *tls_ctx) priv =netdev_priv (netdev); mdev = priv->mdev; +atomic64_inc (&priv_tx->sw_stats->tx_tls_del);mlx5e_destroy_tis (mdev, priv_tx->tisn);mlx5_ktls_destroy_key (mdev, priv_tx->key_id);kfree (priv_tx);
drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.h +1 -0
@@ -42,6 +42,7 @@struct mlx5e_tls_sw_stats {atomic64_t tx_tls_ctx; +atomic64_t tx_tls_del;atomic64_t tx_tls_drop_metadata;atomic64_t tx_tls_drop_resync_alloc;atomic64_t tx_tls_drop_no_sync_data;
drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_stats.c +1 -0
@@ -47,6 +47,7 @@ static const struct counter_desc mlx5e_tls_sw_stats_desc[] = {static const struct counter_desc mlx5e_ktls_sw_stats_desc[] = { { MLX5E_DECLARE_STAT(struct mlx5e_tls_sw_stats, tx_tls_ctx) }, + { MLX5E_DECLARE_STAT(struct mlx5e_tls_sw_stats, tx_tls_del) }, { MLX5E_DECLARE_STAT(struct mlx5e_tls_sw_stats, rx_tls_ctx) }, { MLX5E_DECLARE_STAT(struct mlx5e_tls_sw_stats, rx_tls_del) }, };
Signature · 1 line
2.31.1
PATCH 6/6 net/mlx5e: Add IPsec support to uplink representor
In reply to Saeed MahameedFrom: Raed Salem <[email protected]>
Add the xfrm xdo and ipsec_init/cleanup to uplink representor to support IPsec in SRIOV switchdev mode.
--- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c +1 -1
@@ -428,7 +428,6 @@ int mlx5e_ipsec_init(struct mlx5e_priv *priv)spin_lock_init (&ipsec->sadb_rx_lock);ida_init (&ipsec->halloc); ipsec->en_priv = priv; - ipsec->en_priv->ipsec = ipsec; ipsec->no_trailer = !!(mlx5_accel_ipsec_device_caps (priv->mdev) &MLX5_ACCEL_IPSEC_CAP_RX_NO_TRAILER ); ipsec->wq = alloc_ordered_workqueue("mlx5e_ipsec: %s", 0,
@@ -438,6 +437,7 @@ int mlx5e_ipsec_init(struct mlx5e_priv *priv)return -ENOMEM ; } + priv->ipsec = ipsec;mlx5e_accel_ipsec_fs_init (priv);netdev_dbg (priv->netdev,"IPSec attached to netdevice\n" );return 0 ;
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +7 -0
@@ -51,6 +51,7 @@#include "lib/mlx5.h" #define CREATE_TRACE_POINTS #include "diag/en_rep_tracepoint.h" +#include "en_accel/ipsec.h" #define MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE \ max(0x7, MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE)
@@ -630,6 +631,11 @@ static int mlx5e_init_ul_rep(struct mlx5_core_dev *mdev, struct net_device *netdev) {struct mlx5e_priv *priv =netdev_priv (netdev); +int err; + + err =mlx5e_ipsec_init (priv); +if (err) +mlx5_core_err (mdev,"Uplink rep IPsec initialization failed, %d\n" , err);mlx5e_vxlan_set_netdev_info (priv);return mlx5e_init_rep (mdev, netdev);
@@ -637,6 +643,7 @@ static int mlx5e_init_ul_rep(struct mlx5_core_dev *mdev,static void mlx5e_cleanup_rep (struct mlx5e_priv *priv) { +mlx5e_ipsec_cleanup (priv); }static int mlx5e_create_rep_ttc_table (struct mlx5e_priv *priv)
Signature · 1 line
2.31.1