Skip to contentSkip to conversation

efi_loader: Do not enable by default on armv7

PATCH NAK Tom Rini 5 participants 7 messages Jun 27, 2021 – Jun 28, 2021

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 efi_loader: Do not enable by default on armv7

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

Cc Alexander Graf <[email protected]>
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Mark Kettenis <[email protected]>
Cc Masahisa Kojima <[email protected]>
Cc Peter Robinson <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
I'm very much looking for feedback here that this is the wrong approach and that I've missed the off the shelf distributions that make use of this.

---
 lib/efi_loader/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +1 -1
index 6242caceb7f9..8a22fe9951a3 100644
@@ -10,7 +10,7 @@ config EFI_LOADER
 	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
 	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
 	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
-	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
+	default y if !ARM || SYS_CPU = armv8
 	select LIB_UUID
 	select HAVE_BLOCK_DEVICE
 	select REGEX
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

Best regards

Heinrich

Quoted 32 lines
Cc Alexander Graf <[email protected]>
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Mark Kettenis <[email protected]>
Cc Masahisa Kojima <[email protected]>
Cc Peter Robinson <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
I'm very much looking for feedback here that this is the wrong approach and that I've missed the off the shelf distributions that make use of this.

---
  lib/efi_loader/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +1 -1
index 6242caceb7f9..8a22fe9951a3 100644
@@ -10,7 +10,7 @@ config EFI_LOADER
  	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
  	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
  	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
-	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
+	default y if !ARM || SYS_CPU = armv8
  	select LIB_UUID
  	select HAVE_BLOCK_DEVICE
  	select REGEX
#2 lore raw
Quoted 10 lines

From: Heinrich Schuchardt <[email protected]>
Date: Sun, 27 Jun 2021 23:03:58 +0200

Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

Quoted 3 lines

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

+1

OpenBSD/armv7 relies on EFI loader support as well.

Cheers.

Quoted 33 lines
Quoted 31 lines
Cc Alexander Graf <[email protected]>
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Mark Kettenis <[email protected]>
Cc Masahisa Kojima <[email protected]>
Cc Peter Robinson <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
I'm very much looking for feedback here that this is the wrong approach and that I've missed the off the shelf distributions that make use of this.

---
  lib/efi_loader/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +1 -1
index 6242caceb7f9..8a22fe9951a3 100644
@@ -10,7 +10,7 @@ config EFI_LOADER
  	depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT
  	# We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB
  	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
-	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
+	default y if !ARM || SYS_CPU = armv8
  	select LIB_UUID
  	select HAVE_BLOCK_DEVICE
  	select REGEX
author
#3 lore raw
Quoted 10 lines · Mark Kettenis
Quoted 10 lines

From: Heinrich Schuchardt <[email protected]>
Date: Sun, 27 Jun 2021 23:03:58 +0200

Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

Quoted 7 lines
Quoted 3 lines

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

+1

OpenBSD/armv7 relies on EFI loader support as well.

OK, thanks guys. I missed the Fedora link and I thought *BSD was still using a custom loader on v7.

Signature · 1 line
Tom
#4 lore raw
Quoted 14 lines · Tom Rini
Quoted 12 lines · Mark Kettenis
Quoted 12 lines

From: Heinrich Schuchardt <[email protected]>
Date: Sun, 27 Jun 2021 23:03:58 +0200

Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

NAK

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

+1

OpenBSD/armv7 relies on EFI loader support as well.

OK, thanks guys. I missed the Fedora link and I thought *BSD was still using a custom loader on v7.

Yes, so Fedora uses UEFI by default for across all arm devices now. Linaro also uses it for a bunch of their reference platforms but Ilias will be able to better provide details there.

Peter

#5 lore raw
Quoted 19 lines · Peter Robinson
Quoted 18 lines · Tom Rini
Quoted 16 lines · Mark Kettenis
Quoted 10 lines

From: Heinrich Schuchardt <[email protected]>
Date: Sun, 27 Jun 2021 23:03:58 +0200

Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now. However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead. Disable this by default for armv7 only.

Quoted 3 lines

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

+1

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

OpenBSD/armv7 relies on EFI loader support as well.

OK, thanks guys. I missed the Fedora link and I thought *BSD was still using a custom loader on v7.

Yes, so Fedora uses UEFI by default for across all arm devices now. Linaro also uses it for a bunch of their reference platforms but Ilias will be able to better provide details there.

Yes we are also booting every platform with EFI. And tbh it's not only a matter of distros that already use it. Arm itself has the SystemReady specification [1] which mandates the use of EFI in most of it's flavors (SR, ES and IR). Keeping in mind U-Boot's EFI support is very close to be 100% compliant, I think it's beneficial overall to have pre-canned board configs that support that.

[1] https://developer.arm.com/architectures/system-architectures/arm-systemready

Cheers
/Ilias

#6 lore raw
In reply to Heinrich Schuchardt
Quoted 10 lines · Heinrich Schuchardt
Quoted 5 lines · Tom Rini

We have had EFI loader support enabled by default on armv7 platforms for a long time now.  However, there has been little uptake in the wider community to use EFI loader support as the step to start a generic OS distribution, on this architecture family and the focus has been on armv8 instead.  Disable this by default for armv7 only.

NAK

Please, read https://fedoraproject.org/wiki/Changes/uEFIforARMv7.

OpenBSD and FreeBSD rely on UEFI for booting.

Quoted 38 lines

Best regards

Heinrich

Quoted 32 lines
Cc Alexander Graf <[email protected]>
Cc Heinrich Schuchardt <[email protected]>
Cc Ilias Apalodimas <[email protected]>
Cc Mark Kettenis <[email protected]>
Cc Masahisa Kojima <[email protected]>
Cc Peter Robinson <[email protected]>
Cc Sughosh Ganu <[email protected]>
Cc Vagrant Cascadian <[email protected]>

---
I'm very much looking for feedback here that this is the wrong approach and that I've missed the off the shelf distributions that make use of this.
---
  lib/efi_loader/Kconfig | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/Kconfig +0 -0
index 6242caceb7f9..8a22fe9951a3 100644
@@ -10,7 +10,7 @@ config EFI_LOADER

      depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT

-    default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
+    default y if !ARM || SYS_CPU = armv8

      select LIB_UUID
      select HAVE_BLOCK_DEVICE
      select REGEX