Skip to contentSkip to conversation

Some more QEMU 6.0 fixes

PATCH In review Anthony PERARD 3 participants 6 messages Jun 28, 2021 – Jul 2, 2021

lore
Share & tools
lore
#0 lore raw

Follow-up of
[XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
to fix few missing bits.

To be backported to Xen 4.15 as well.

#1 lore raw

PATCH 1/2 libxl: Replace short-form boolean for QEMU's -vnc

f3f778c81769 forgot one boolean parameter.

Fixes f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option")
---
 tools/libs/light/libxl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libs/light/libxl_dm.c +1 -1
index 5b01cf284163..7670e403a90f 100644
@@ -1324,7 +1324,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
             vncarg = GCSPRINTF("127.0.0.1:%d", vnc->display);
 
         if (vnc->passwd && vnc->passwd[0]) {
-            vncarg = GCSPRINTF("%s,password", vncarg);
+            vncarg = GCSPRINTF("%s,password=on", vncarg);
         }
 
         if (libxl_defbool_val(vnc->findunused)) {
Signature · 1 line
Anthony PERARD
#3 lore raw

PATCH 2/2 libxl: Fix QEMU cmdline for scsi device

In reply to Anthony PERARD

Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives.
See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)

---
 tools/libs/light/libxl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libs/light/libxl_dm.c +1 -1
index 7670e403a90f..dbd3c7f278f9 100644
@@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
                                                         &drive_id),
                     flexarray_vappend(dm_args,
                         "-drive", drive,
-                        "-device", GCSPRINTF("scsi-disk,drive=%s,scsi-id=%d",
+                        "-device", GCSPRINTF("scsi-hd,drive=%s,scsi-id=%d",
                                              drive_id, disk),
                         NULL);
                     continue;
Signature · 1 line
Anthony PERARD
Reviewed-by on v1 2/2
#4 lore raw

Re: [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device

Quoted 6 lines · Anthony PERARD

Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives.
See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)

Looks like scsi-hd is really old - qemu v0.15.

Regards,
Jason

#5 lore raw
In reply to Anthony PERARD

Hi,

Quoted 3 lines · Anthony PERARD

Follow-up of
[XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
to fix few missing bits.

I have committed the series.

Quoted 2 lines

To be backported to Xen 4.15 as well.

@Ian can you queue it for backport?

Cheers,

Signature · 1 line
Julien Grall