Some more QEMU 6.0 fixes
Follow-up of
[XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
to fix few missing bits.
To be backported to Xen 4.15 as well.
PATCH 1/2 libxl: Replace short-form boolean for QEMU's -vnc
f3f778c81769 forgot one boolean parameter.
--- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libs/light/libxl_dm.c +1 -1
@@ -1324,7 +1324,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, vncarg =GCSPRINTF ("127.0.0.1:%d" , vnc->display);if (vnc->passwd && vnc->passwd[0 ]) { - vncarg =GCSPRINTF ("%s,password" , vncarg); + vncarg =GCSPRINTF ("%s,password=on" , vncarg); }if (libxl_defbool_val (vnc->findunused)) {
Signature · 1 line
Anthony PERARD
Re: [XEN PATCH 1/2] libxl: Replace short-form boolean for QEMU's -vnc
Quoted 5 lines · Anthony PERARD
f3f778c81769forgot one boolean parameter.Fixes f3f778c81769 ("libxl: Replace QEMU's command line short-form boolean option")Signed-off-by Anthony PERARD <[email protected]>
PATCH 2/2 libxl: Fix QEMU cmdline for scsi device
In reply to Anthony PERARDUsage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives.
See QEMU 879be3af49 (hw/scsi: remove 'scsi-disk' device)
--- tools/libs/light/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/libs/light/libxl_dm.c +1 -1
@@ -1972,7 +1972,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, &drive_id),flexarray_vappend (dm_args,"-drive" , drive, -"-device" ,GCSPRINTF ("scsi-disk,drive=%s,scsi-id=%d" , +"-device" ,GCSPRINTF ("scsi-hd,drive=%s,scsi-id=%d" , drive_id, disk),NULL );continue ;
Signature · 1 line
Anthony PERARD
Re: [XEN PATCH 2/2] libxl: Fix QEMU cmdline for scsi device
Quoted 6 lines · Anthony PERARD
Usage of 'scsi-disk' device is deprecated and removed from QEMU, instead we need to use 'scsi-hd' for hard drives.
See QEMU879be3af49(hw/scsi: remove 'scsi-disk' device)Signed-off-by Anthony PERARD <[email protected]>
Looks like scsi-hd is really old - qemu v0.15.
Regards,
Jason
Hi,
Quoted 3 lines · Anthony PERARD
Follow-up of
[XEN PATCH v2 0/8] Fix libxl with QEMU 6.0 + remove some more deprecated usages
to fix few missing bits.
I have committed the series.
Quoted 2 lines
To be backported to Xen 4.15 as well.
@Ian can you queue it for backport?
Cheers,
Signature · 1 line
Julien Grall