Skip to contentSkip to conversation

driver: base: Prefer unsigned int to bare use of unsigned

PATCH In review Jinchao Wang 2 participants 2 messages Jun 26, 2021 – Jun 28, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver: base: Prefer unsigned int to bare use of unsigned

Fix checkpatch warnings:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 drivers/base/cpu.c                   |  4 ++--
 drivers/base/map.c                   | 12 ++++++------
 drivers/base/node.c                  |  8 ++++----
 drivers/base/regmap/regmap-debugfs.c |  2 +-
 drivers/base/regmap/regmap-mmio.c    |  2 +-
 drivers/base/regmap/regmap.c         |  6 +++---
 6 files changed, 17 insertions(+), 17 deletions(-)
drivers/base/cpu.c +2 -2
index 5ef14db97904..5fc258073bc7 100644
@@ -388,7 +388,7 @@ int register_cpu(struct cpu *cpu, int num)
 	return 0;
 }
 
-struct device *get_cpu_device(unsigned cpu)
+struct device *get_cpu_device(unsigned int cpu)
 {
 	if (cpu < nr_cpu_ids && cpu_possible(cpu))
 		return per_cpu(cpu_sys_devices, cpu);
@@ -484,7 +484,7 @@ static const struct attribute_group *cpu_root_attr_groups[] = {
 	NULL,
 };
 
-bool cpu_is_hotpluggable(unsigned cpu)
+bool cpu_is_hotpluggable(unsigned int cpu)
 {
 	struct device *dev = get_cpu_device(cpu);
 	return dev && container_of(dev, struct cpu, dev)->hotpluggable;
drivers/base/map.c +6 -6
index 5650ab2b247a..83aeb09ca161 100644
@@ -33,9 +33,9 @@ int kobj_map(struct kobj_map *domain, dev_t dev, unsigned long range,
 	     struct module *module, kobj_probe_t *probe,
 	     int (*lock)(dev_t, void *), void *data)
 {
-	unsigned n = MAJOR(dev + range - 1) - MAJOR(dev) + 1;
-	unsigned index = MAJOR(dev);
-	unsigned i;
+	unsigned int n = MAJOR(dev + range - 1) - MAJOR(dev) + 1;
+	unsigned int index = MAJOR(dev);
+	unsigned int i;
 	struct probe *p;
 
 	if (n > 255)
@@ -67,9 +67,9 @@ int kobj_map(struct kobj_map *domain, dev_t dev, unsigned long range,
 
 void kobj_unmap(struct kobj_map *domain, dev_t dev, unsigned long range)
 {
-	unsigned n = MAJOR(dev + range - 1) - MAJOR(dev) + 1;
-	unsigned index = MAJOR(dev);
-	unsigned i;
+	unsigned int n = MAJOR(dev + range - 1) - MAJOR(dev) + 1;
+	unsigned int index = MAJOR(dev);
+	unsigned int i;
 	struct probe *found = NULL;
 
 	if (n > 255)
drivers/base/node.c +4 -4
index 4a4ae868ad9f..2bc9089f3e78 100644
@@ -75,7 +75,7 @@ static DEVICE_ATTR_RO(cpulist);
 struct node_access_nodes {
 	struct device		dev;
 	struct list_head	list_node;
-	unsigned		access;
+	unsigned int		access;
 #ifdef CONFIG_HMEM_REPORTING
 	struct node_hmem_attrs	hmem_attrs;
 #endif
@@ -122,7 +122,7 @@ static void node_access_release(struct device *dev)
 }
 
 static struct node_access_nodes *node_init_node_access(struct node *node,
-						       unsigned access)
+						       unsigned int access)
 {
 	struct node_access_nodes *access_node;
 	struct device *dev;
@@ -187,7 +187,7 @@ static struct attribute *access_attrs[] = {
  * @access: The access class the for the given attributes
  */
 void node_set_perf_attrs(unsigned int nid, struct node_hmem_attrs *hmem_attrs,
-			 unsigned access)
+			 unsigned int access)
 {
 	struct node_access_nodes *c;
 	struct node *node;
@@ -711,7 +711,7 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
  */
 int register_memory_node_under_compute_node(unsigned int mem_nid,
 					    unsigned int cpu_nid,
-					    unsigned access)
+					    unsigned int access)
 {
 	struct node *init_node, *targ_node;
 	struct node_access_nodes *initiator, *target;
drivers/base/regmap/regmap-debugfs.c +1 -1
index 211a335a608d..ad684d37c2da 100644
@@ -368,7 +368,7 @@ static ssize_t regmap_reg_ranges_read_file(struct file *file,
 	char *buf;
 	char *entry;
 	int ret;
-	unsigned entry_len;
+	unsigned int entry_len;
 
 	if (*ppos < 0 || !count)
 		return -EINVAL;
drivers/base/regmap/regmap-mmio.c +1 -1
index f9cd51afb9d2..71f16be7e717 100644
@@ -15,7 +15,7 @@
 
 struct regmap_mmio_context {
 	void __iomem *regs;
-	unsigned val_bytes;
+	unsigned int val_bytes;
 	bool relaxed_mmio;
 
 	bool attached_clk;
drivers/base/regmap/regmap.c +3 -3
index fe3e38dd5324..904e1022d12e 100644
@@ -1126,9 +1126,9 @@ struct regmap *__regmap_init(struct device *dev,
 		/* Make sure, that this register range has no selector
 		   or data window within its boundary */
 		for (j = 0; j < config->num_ranges; j++) {
-			unsigned sel_reg = config->ranges[j].selector_reg;
-			unsigned win_min = config->ranges[j].window_start;
-			unsigned win_max = win_min +
+			unsigned int sel_reg = config->ranges[j].selector_reg;
+			unsigned int win_min = config->ranges[j].window_start;
+			unsigned int win_max = win_min +
 					   config->ranges[j].window_len - 1;
 
 			/* Allow data window inside its own virtual range */
Signature · 1 line
2.31.1
maintainer
#1 lore raw
Quoted 11 lines · Jinchao Wang

Fix checkpatch warnings:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 drivers/base/cpu.c                   |  4 ++--
 drivers/base/map.c                   | 12 ++++++------
 drivers/base/node.c                  |  8 ++++----
 drivers/base/regmap/regmap-debugfs.c |  2 +-
 drivers/base/regmap/regmap-mmio.c    |  2 +-
 drivers/base/regmap/regmap.c         |  6 +++---

Please don't mix changes for multiple subsystems into single patches, send at least one patch per subsystem.