vp_vdpa: correct the return value when fail to map notification
PATCH 1/1 vp_vdpa: correct the return value when fail to map notification
We forget to assign a error value when we fail to map the notification during prove. This patch fixes it.
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
Fixes 11d8ffed00b23 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by Jason Wang <[email protected]>
--- drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + 1 file changed, 1 insertion(+)
drivers/vdpa/virtio_pci/vp_vdpa.c +1 -0
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)vp_modern_map_vq_notify (mdev, i, &vp_vdpa->vring[i].notify_pa);if (!vp_vdpa->vring[i].notify) { + ret = -EINVAL ;dev_warn (&pdev->dev,"Fail to map vq notify %d\n" , i); goto err; }
Signature · 6 lines
2.25.1 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 25 lines · Jason Wang
We forget to assign a error value when we fail to map the notification during prove. This patch fixes it.
Reported-by kernel test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>Fixes 11d8ffed00b23 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")Signed-off-by Jason Wang <[email protected]>---
drivers/vdpa/virtio_pci/vp_vdpa.c| 1 +1 file changed, 1 insertion(+)drivers/vdpa/virtio_pci/vp_vdpa.c +1
-0@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)vp_modern_map_vq_notify (mdev, i, &vp_vdpa->vring[i].notify_pa);if (!vp_vdpa->vring[i].notify) { + ret = -EINVAL ;dev_warn (&pdev->dev,"Fail to map vq notify %d\n" , i); goto err; }Signature · 1 line
2.25.1
Reviewed-by Stefano Garzarella <[email protected]>
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization