package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
PATCH 1/1 package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
Move 'rosetta' prefix from VERSION to SITE to have version be in a standard format.
--- package/fb-test-app/fb-test-app.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/fb-test-app/fb-test-app.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -FB_TEST_APP_VERSION = rosetta-1.1.1 -FB_TEST_APP_SITE = $(call github,andy-shev,fb-test-app,$(FB_TEST_APP_VERSION)) +FB_TEST_APP_VERSION = 1.1.1 +FB_TEST_APP_SITE = $(call github,andy-shev,fb-test-app,rosetta-$(FB_TEST_APP_VERSION)) FB_TEST_APP_LICENSE = GPL-2.0 FB_TEST_APP_LICENSE_FILES = COPYING
Signature · 1 line
2.30.2
PATCH 1/1 package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
Quoted 5 lines · On Mon, 28 Jun 2021 16:08:16 +0300 Andy Shevchenko…
Move 'rosetta' prefix from VERSION to SITE to have version be in a standard format.
Suggested-by Thomas Petazzoni <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Thanks for the patch. However, are you sure you tested it? I believe this doesn't build, as the .hash file needs to be adjusted accordingly.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
Quoted 11 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 28 Jun 2021 16:08:16 +0300 Andy Shevchenko…
Move 'rosetta' prefix from VERSION to SITE to have version be in a standard format.
Suggested-by Thomas Petazzoni <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Thanks for the patch. However, are you sure you tested it? I believe this doesn't build, as the .hash file needs to be adjusted accordingly.
You are right, it wasn't tested on the repo which has this package enabled in the configuration.
I'll send v2 which I have just tested:
--2021-06-28 18:58:28-- https://github.com/andy-shev/fb-test-app/archive/rosetta-1.1.1/fb-test-app-1.1.1.tar.gz
...
fb-test-app-1.1.1.tar.gz: OK (sha256: 45d490ed78a6e4425d9a760e81e99dc503af01704e17ab5bf186b87a31c5e3db)
Signature · 2 lines
With Best Regards, Andy Shevchenko