Skip to contentSkip to conversation

KVM: SVM: Call SEV Guest Decommission if ASID binding fails

PATCH In review Alper Gun 4 participants 5 messages Jun 28, 2021 – Jul 8, 2021 Stable branch

lore
Share & tools
lore

Alper Gun

author
#0 lore raw

PATCH 1/1 KVM: SVM: Call SEV Guest Decommission if ASID binding fails

commit 934002cd660b035b926438244b4294e647507e13 upstream.

Send SEV_CMD_DECOMMISSION command to PSP firmware if ASID binding fails. If a failure happens after a successful LAUNCH_START command, a decommission command should be executed. Otherwise, guest context will be unfreed inside the AMD SP. After the firmware will not have memory to allocate more SEV guest context, LAUNCH_START command will begin to fail with SEV_RET_RESOURCE_LIMIT error.

The existing code calls decommission inside sev_unbind_asid, but it is not called if a failure happens before guest activation succeeds. If sev_bind_asid fails, decommission is never called. PSP firmware has a limit for the number of guests. If sev_asid_binding fails many times, PSP firmware will not have resources to create another guest context.

Fixes 59414c989220 ("KVM: SVM: Add support for KVM_SEV_LAUNCH_START command")

Message-Id: <[email protected]>

---
 arch/x86/kvm/svm.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)
arch/x86/kvm/svm.c +21 -11
index 074cd170912a..aa2da922ca99 100644
@@ -1794,9 +1794,25 @@ static void sev_asid_free(struct kvm *kvm)
 	__sev_asid_free(sev->asid);
 }
 
-static void sev_unbind_asid(struct kvm *kvm, unsigned int handle)
+static void sev_decommission(unsigned int handle)
 {
 	struct sev_data_decommission *decommission;
+
+	if (!handle)
+		return;
+
+	decommission = kzalloc(sizeof(*decommission), GFP_KERNEL);
+	if (!decommission)
+		return;
+
+	decommission->handle = handle;
+	sev_guest_decommission(decommission, NULL);
+
+	kfree(decommission);
+}
+
+static void sev_unbind_asid(struct kvm *kvm, unsigned int handle)
+{
 	struct sev_data_deactivate *data;
 
 	if (!handle)
@@ -1814,15 +1830,7 @@ static void sev_unbind_asid(struct kvm *kvm, unsigned int handle)
 	sev_guest_df_flush(NULL);
 	kfree(data);
 
-	decommission = kzalloc(sizeof(*decommission), GFP_KERNEL);
-	if (!decommission)
-		return;
-
-	/* decommission handle */
-	decommission->handle = handle;
-	sev_guest_decommission(decommission, NULL);
-
-	kfree(decommission);
+	sev_decommission(handle);
 }
 
 static struct page **sev_pin_memory(struct kvm *kvm, unsigned long uaddr,
@@ -6475,8 +6483,10 @@ static int sev_launch_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
 
 	/* Bind ASID to this guest */
 	ret = sev_bind_asid(kvm, start->handle, error);
-	if (ret)
+	if (ret) {
+		sev_decommission(start->handle);
 		goto e_free_session;
+	}
 
 	/* return handle to userspace */
 	params.handle = start->handle;
Signature · 1 line
2.32.0.93.g670b81a890-goog
maintainer
#1 lore raw
Quoted 15 lines · Alper Gun

commit 934002cd660b035b926438244b4294e647507e13 upstream.

Send SEV_CMD_DECOMMISSION command to PSP firmware if ASID binding fails. If a failure happens after a successful LAUNCH_START command, a decommission command should be executed. Otherwise, guest context will be unfreed inside the AMD SP. After the firmware will not have memory to allocate more SEV guest context, LAUNCH_START command will begin to fail with SEV_RET_RESOURCE_LIMIT error.

The existing code calls decommission inside sev_unbind_asid, but it is not called if a failure happens before guest activation succeeds. If sev_bind_asid fails, decommission is never called. PSP firmware has a limit for the number of guests. If sev_asid_binding fails many times, PSP firmware will not have resources to create another guest context.

Quoted 7 lines
Fixes 59414c989220 ("KVM: SVM: Add support for KVM_SEV_LAUNCH_START command")

Message-Id: <[email protected]>

Message-id? Odd...

Quoted 3 lines
---
 arch/x86/kvm/svm.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)

<snip>

Can you also provide working backports for the newer kernel trees as well? We would need this in 5.10 and 5.12, right?

thanks,

greg k-h

Acked-by
#2 lore raw
Quoted 24 lines · Greg KH
Quoted 15 lines · Alper Gun

commit 934002cd660b035b926438244b4294e647507e13 upstream.

Send SEV_CMD_DECOMMISSION command to PSP firmware if ASID binding fails. If a failure happens after a successful LAUNCH_START command, a decommission command should be executed. Otherwise, guest context will be unfreed inside the AMD SP. After the firmware will not have memory to allocate more SEV guest context, LAUNCH_START command will begin to fail with SEV_RET_RESOURCE_LIMIT error.

The existing code calls decommission inside sev_unbind_asid, but it is not called if a failure happens before guest activation succeeds. If sev_bind_asid fails, decommission is never called. PSP firmware has a limit for the number of guests. If sev_asid_binding fails many times, PSP firmware will not have resources to create another guest context.

Quoted 7 lines
Fixes 59414c989220 ("KVM: SVM: Add support for KVM_SEV_LAUNCH_START command")

Message-Id: <[email protected]>

Quoted 1 line

Message-id? Odd...

Not that much, see "git log -- drivers | grep Message-Id". A link to lore.kernel.org is getting more popular these days, but Message-Id is what "git am" knows about.

Quoted 8 lines
Quoted 3 lines
---
  arch/x86/kvm/svm.c | 32 +++++++++++++++++++++-----------
  1 file changed, 21 insertions(+), 11 deletions(-)

<snip>

Can you also provide working backports for the newer kernel trees as well? We would need this in 5.10 and 5.12, right?

Already queued:

https://lore.kernel.org/stable/[email protected]/ for 5.12
https://lore.kernel.org/stable/[email protected]/ for 5.10

For this one:

Paolo

maintainer
#3 lore raw
Quoted 40 lines · Paolo Bonzini
Quoted 24 lines · Greg KH
Quoted 15 lines · Alper Gun

commit 934002cd660b035b926438244b4294e647507e13 upstream.

Send SEV_CMD_DECOMMISSION command to PSP firmware if ASID binding fails. If a failure happens after a successful LAUNCH_START command, a decommission command should be executed. Otherwise, guest context will be unfreed inside the AMD SP. After the firmware will not have memory to allocate more SEV guest context, LAUNCH_START command will begin to fail with SEV_RET_RESOURCE_LIMIT error.

The existing code calls decommission inside sev_unbind_asid, but it is not called if a failure happens before guest activation succeeds. If sev_bind_asid fails, decommission is never called. PSP firmware has a limit for the number of guests. If sev_asid_binding fails many times, PSP firmware will not have resources to create another guest context.

Quoted 7 lines
Fixes 59414c989220 ("KVM: SVM: Add support for KVM_SEV_LAUNCH_START command")

Message-Id: <[email protected]>

Quoted 1 line

Message-id? Odd...

Not that much, see "git log -- drivers | grep Message-Id". A link to lore.kernel.org is getting more popular these days, but Message-Id is what "git am" knows about.

Quoted 8 lines
Quoted 3 lines
---
  arch/x86/kvm/svm.c | 32 +++++++++++++++++++++-----------
  1 file changed, 21 insertions(+), 11 deletions(-)

<snip>

Can you also provide working backports for the newer kernel trees as well? We would need this in 5.10 and 5.12, right?

Quoted 6 lines

Already queued:

https://lore.kernel.org/stable/[email protected]/
for 5.12
https://lore.kernel.org/stable/[email protected]/
for 5.10

Ah, you are right, I forgot to update my local tree, my fault.

greg k-h

#4 lore raw
In reply to Alper Gun
Quoted 21 lines · Alper Gun

commit 934002cd660b035b926438244b4294e647507e13 upstream.

Send SEV_CMD_DECOMMISSION command to PSP firmware if ASID binding fails. If a failure happens after a successful LAUNCH_START command, a decommission command should be executed. Otherwise, guest context will be unfreed inside the AMD SP. After the firmware will not have memory to allocate more SEV guest context, LAUNCH_START command will begin to fail with SEV_RET_RESOURCE_LIMIT error.

The existing code calls decommission inside sev_unbind_asid, but it is not called if a failure happens before guest activation succeeds. If sev_bind_asid fails, decommission is never called. PSP firmware has a limit for the number of guests. If sev_asid_binding fails many times, PSP firmware will not have resources to create another guest context.

Fixes 59414c989220 ("KVM: SVM: Add support for KVM_SEV_LAUNCH_START command")
Quoted 4 lines

Message-Id: <[email protected]>

---
 arch/x86/kvm/svm.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)

Now queued up, thanks.

greg k-h