trace-cmd split: Assert if the calculated record size is too big
PATCH 1/1 trace-cmd split: Assert if the calculated record size is too big
From: "Steven Rostedt (VMware)" <[email protected]>
With a discovery of a bug that caused a record to be written passed the end of a page (and this was a possible memory corruption bug), check that the calculated length is no bigger than the record it is copying. If it is, then crash, as this can cause the data to write pass the allocated page.
Now that bug would crash on the split command with:
Bad calculation of record len (expect:116 actual:120)
Signed-off-by Steven Rostedt (VMware) <[email protected]>
--- tracecmd/trace-split.c | 3 +++ 1 file changed, 3 insertions(+)
tracecmd/trace-split.c +3 -0
@@ -118,6 +118,9 @@ static int write_record(struct tracecmd_input *handle,if (!len) { len = record->size +4 ; +if ((len +4 ) > record->record_size) +die ("Bad calculation of record len (expect:%d actual:%d)" , + record->record_size, len +4 ); *(unsigned *)ptr =tep_read_number (pevent, &len,4 ); ptr +=4 ; index +=4 ;
Signature · 1 line
2.29.2