drm/amdgpu: return early for non-TTM_PL_TT type BOs
Subsystems (2)
PATCH v3 1/1 drm/amdgpu: return early for non-TTM_PL_TT type BOs
Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes ttm_resource argument to be TTM_PL_TT type BO's.
v3: remove extra braces.
v2: merge if-conditions.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -1
@@ -926,7 +926,8 @@ static int amdgpu_ttm_backend_bind(struct ttm_device *bdev, bo_mem->mem_type == AMDGPU_PL_OA)return -EINVAL ; -if (!amdgpu_gtt_mgr_has_gart_addr (bo_mem)) { +if (bo_mem->mem_type !=TTM_PL_TT || + !amdgpu_gtt_mgr_has_gart_addr (bo_mem)) { gtt->offset =AMDGPU_BO_INVALID_OFFSET ;return 0 ; }
--
2.32.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Christian,
Could you please pick this up for drm-misc-next or fixes ?
Regards,
Nirmoy
Quoted 28 lines · Nirmoy Das
Return early for non-TTM_PL_TT BOs so that we don't pass wrong pointer to
amdgpu_gtt_mgr_has_gart_addr()which assumesttm_resourceargument to beTTM_PL_TTtype BO's.v3: remove extra braces.
v2: merge if-conditions.Signed-off-by Nirmoy Das <[email protected]>Reviewed-by Christian König <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2@@ -926,7 +926,8 @@ static int amdgpu_ttm_backend_bind(struct ttm_device *bdev, bo_mem->mem_type == AMDGPU_PL_OA)return -EINVAL ; -if (!amdgpu_gtt_mgr_has_gart_addr (bo_mem)) { +if (bo_mem->mem_type !=TTM_PL_TT || + !amdgpu_gtt_mgr_has_gart_addr (bo_mem)) { gtt->offset =AMDGPU_BO_INVALID_OFFSET ;return 0 ; } --
Quoted 2 lines
2.32.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx