cmd: incorrect error reporting when table declaration exists
Pablo Neira Ayuso
maintainerPATCH 1/1 cmd: incorrect error reporting when table declaration exists
This example ruleset is missing the chain declaration:
add table x
add set x y { typeof ip saddr ; }
add rule x y counter
After this patch, error reporting provides suggestions for the missing chain:
# nft -f ruleset.nft
ruleset.nft:3:12-12: Error: No such file or directory; did you mean chain ‘INPUT’ in table ip ‘filter’?
add rule x y counter
^Before this patch, it incorrectly refers to the table:
ruleset.nft:3:10-10: Error: No such file or directory; did you mean table ‘filter’ in family ip? add rule x y counter
^
This patch invalidates the table that is found via fuzzy lookup if it exists in the cache.
Fixes 0276c2fee939 ("cmd: check for table mismatch first in error reporting")
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/cmd.c | 4 ++++ 1 file changed, 4 insertions(+)
src/cmd.c +4 -0
@@ -30,6 +30,10 @@ static int nft_cmd_enoent_table(struct netlink_ctx *ctx, const struct cmd *cmd,static int table_fuzzy_check (struct netlink_ctx *ctx,const struct cmd *cmd,const struct table *table) { +if (table_cache_find (&ctx->nft->cache.table_cache, + cmd->handle.table.name, cmd->handle.family)) +return 0 ; +if (strcmp (cmd->handle.table.name, table->handle.table.name) || cmd->handle.family != table->handle.family) { netlink_io_error(ctx, &cmd->handle.table.location,
Signature · 1 line
2.20.1