Skip to contentSkip to conversation

pinctrl: ralink: rt305x: add missing include

PATCH In review Sergio Paracuellos 2 participants 3 messages Jun 29, 2021 – Jun 30, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: ralink: rt305x: add missing include

Header 'rt305x.h' is ralink architecture dependent file where other general definitions which are in 'ralink_regs.h' are being used. This 'rt305x.h' is only being included in two different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When file 'pinctrl-rt305x.c' is being compiled definitions in 'ralink_regs.h' are need to build it properly. Hence, add missing include 'ralink_regs.h' in 'pinctrl-rt305x.c' source to avoid compilation problems.

Fixes 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
---
 drivers/pinctrl/ralink/pinctrl-rt305x.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-rt305x.c +1 -0
index 699fe18e7000..5d8fa156c003 100644
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <asm/mach-ralink/ralink_regs.h>
 #include <asm/mach-ralink/rt305x.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.25.1
#1 lore raw
Quoted 9 lines · Sergio Paracuellos

Header 'rt305x.h' is ralink architecture dependent file where other general definitions which are in 'ralink_regs.h' are being used. This 'rt305x.h' is only being included in two different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When file 'pinctrl-rt305x.c' is being compiled definitions in 'ralink_regs.h' are need to build it properly. Hence, add missing include 'ralink_regs.h' in 'pinctrl-rt305x.c' source to avoid compilation problems.

Quoted 3 lines
Fixes 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")

Patch applied!

Yours,
Linus Walleij

#2 lore raw
Quoted 13 lines · Linus Walleij
Quoted 9 lines · Sergio Paracuellos

Header 'rt305x.h' is ralink architecture dependent file where other general definitions which are in 'ralink_regs.h' are being used. This 'rt305x.h' is only being included in two different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When file 'pinctrl-rt305x.c' is being compiled definitions in 'ralink_regs.h' are need to build it properly. Hence, add missing include 'ralink_regs.h' in 'pinctrl-rt305x.c' source to avoid compilation problems.

Quoted 5 lines
Quoted 3 lines
Fixes 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")

Patch applied!

Thanks!

Best regards,
Sergio Paracuellos

Quoted 3 lines

Yours,
Linus Walleij