certs: Redirect openssl error message to null device
Subsystems (4)
PATCH 1/1 certs: Redirect openssl error message to null device
From: Stefan Berger <[email protected]>
Address the following issue detected by the kernel test robot when there's no certificate file at the time when checking for the type of key in the cert:
Can't open certs/signing_key.pem for reading, No such file or directory
The simplest solution is to redirect openssl's stderr output to /dev/null.
--- certs/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
certs/Makefile +1 -1
@@ -65,7 +65,7 @@ openssl_available = $(shell openssl help 2>/dev/null && echo yes) ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem") ifeq ($(openssl_available),yes) -X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text) +X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null) $(if $(findstring rsaEncryption,$(X509TEXT)),,$(shell rm -f $(CONFIG_MODULE_SIG_KEY))) endif
Signature · 1 line
2.31.1
Quoted 6 lines · Stefan Berger
From: Stefan Berger <[email protected]>
Address the following issue detected by the kernel test robot when there's no certificate file at the time when checking for the type of key in the cert:
Quoted 7 lines
Can't open
certs/signing_key.pemfor reading, No such file or directoryThe simplest solution is to redirect openssl's stderr output to
/dev/null.Fixes 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")Signed-off-by Stefan Berger <[email protected]>Reported-by kernel test robot <[email protected]>
Jarkko,
can you please squash this patch into the one it fixes. Unfortunately when rebasing you will have to fix the subsequent patch from this merge error
ifeq ($(openssl_available),yes)
<<<<<<< HEAD
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null)
=======
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text) endif
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
87e968848116(certs: Add support for using elliptic curve keys for signing modules)
to this:
ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null) endif
Thanks.
Stefan
Jarkko Sakkinen
maintainerQuoted 35 lines · Stefan Berger
Quoted 6 lines · Stefan Berger
From: Stefan Berger <[email protected]>
Address the following issue detected by the kernel test robot when there's no certificate file at the time when checking for the type of key in the cert:
Quoted 7 lines
Can't open
certs/signing_key.pemfor reading, No such file or directoryThe simplest solution is to redirect openssl's stderr output to
/dev/null.Fixes 28d62d945ded ("certs: Trigger creation of RSA module signing key if it's not an RSA key")Signed-off-by Stefan Berger <[email protected]>Reported-by kernel test robot <[email protected]>Jarkko,
can you please squash this patch into the one it fixes. Unfortunately when rebasing you will have to fix the subsequent patch from this merge error
ifeq ($(openssl_available),yes)
<<<<<<< HEAD
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null)
=======
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text) endifQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
87e968848116(certs: Add support for using elliptic curve keys forsigning modules)
to this:
Quoted 8 lines
ifeq ($(openssl_available),yes)
X509TEXT=$(shell openssl x509 -in $(CONFIG_MODULE_SIG_KEY) -text 2>/dev/null)
endifThanks.
Stefan
The problem is that I have already a pending pull request, and merge window is soon closing.
I think it's a better idea that I just drop these patches and send a new pull request, and you should construct a new version of the series. This cannot be a blocker for the rest of the patches (or even potential blocker). We can consider the current patches not ready for mainline.
/Jarkko
Quoted 8 lines · Jarkko Sakkinen
The problem is that I have already a pending pull request, and merge window is soon closing.
I think it's a better idea that I just drop these patches and send a new pull request, and you should construct a new version of the series. This cannot be a blocker for the rest of the patches (or even potential blocker). We can consider the current patches not ready for mainline.
I posted v7 based on what you had queue for the PR with the changes that I document for v7.
Stefan
Quoted 2 lines
/Jarkko