Skip to contentSkip to conversation

drm/amdgpu/display: drop unused variable

PATCH In review Alex Deucher 3 participants 3 messages Jun 29, 2021 – Jun 30, 2021

Subsystems (3)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/display: drop unused variable

Remove unused variable.

Fixes 00858131205f69 ("Revert "drm/amd/display: Fix overlay validation by considering cursors"")
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index f14b5468b7ee..e034017daa1a 100644
@@ -10221,7 +10221,7 @@ static int validate_overlay(struct drm_atomic_state *state)
 {
 	int i;
 	struct drm_plane *plane;
-	struct drm_plane_state *old_plane_state, *new_plane_state;
+	struct drm_plane_state *new_plane_state;
 	struct drm_plane_state *primary_state, *overlay_state = NULL;
 
 	/* Check if primary plane is contained inside overlay */
Signature · 6 lines
2.31.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Alex Deucher

Remove unused variable.

Fixes 00858131205f69 ("Revert "drm/amd/display: Fix overlay validation by considering cursors"")

Harry

Quoted 10 lines
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index f14b5468b7ee..e034017daa1a 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int validate_overlay(struct drm_atomic_state *state) · line 10227

Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -10221,7 +10221,7 @@ static int validate_overlay(struct drm_atomic_state *state)
 {
 	int i;
 	struct drm_plane *plane;
-	struct drm_plane_state *old_plane_state, *new_plane_state;
+	struct drm_plane_state *new_plane_state;
 	struct drm_plane_state *primary_state, *overlay_state = NULL;
 
 	/* Check if primary plane is contained inside overlay */

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Alex Deucher

Am 29.06.21 um 23:02 schrieb Alex Deucher:

Quoted 4 lines

Remove unused variable.

Fixes 00858131205f69 ("Revert "drm/amd/display: Fix overlay validation by considering cursors"")
Quoted 9 lines
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
index f14b5468b7ee..e034017daa1a 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static int validate_overlay(struct drm_atomic_state *state) · line 10227

Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -10221,7 +10221,7 @@ static int validate_overlay(struct drm_atomic_state *state)
  {
  	int i;
  	struct drm_plane *plane;
-	struct drm_plane_state *old_plane_state, *new_plane_state;
+	struct drm_plane_state *new_plane_state;
  	struct drm_plane_state *primary_state, *overlay_state = NULL;
 
  	/* Check if primary plane is contained inside overlay */

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx