Skip to contentSkip to conversation

drm/amdgpu: Make noretry the default on yellow carp

PATCH In review Aaron Liu 2 participants 2 messages Jun 30, 2021

Subsystems (2)
lore
Share & tools
lore

Aaron Liu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Make noretry the default on yellow carp

From: chen gong <[email protected]>

Performing kfd page fault tests on the yellow carp platform will fail.

From the scan data after the failure, it can be found that a nack=0x1(retry fault) is returned. but we did not enable the interrupts for retry faults in the code.

So we need to set noretry = 1 like the above ASICs.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +1 -0
index 1525d957e114..d4e9704dec62 100644
@@ -591,6 +591,7 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
 	case CHIP_ARCTURUS:
 	case CHIP_ALDEBARAN:
 	case CHIP_BEIGE_GOBY:
+	case CHIP_YELLOW_CARP:
 		/*
 		 * noretry = 0 will cause kfd page fault tests fail
 		 * for some ASICs, so set default to 1 for these ASICs.
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by Reviewed-by Aaron Liu Acked-by on v1 1/1
#1 lore raw

[AMD Official Use Only]

-----Original Message-----
From: Liu, Aaron <[email protected]>
Sent: Wednesday, June 30, 2021 1:57 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Huang, Ray <[email protected]>; Gong, Curry <[email protected]>; Kuehling, Felix <[email protected]>; Liu, Aaron <[email protected]>; Huang, Ray <[email protected]>
Subject: [PATCH] drm/amdgpu: Make noretry the default on yellow carp

From: chen gong <[email protected]>

Performing kfd page fault tests on the yellow carp platform will fail.

From the scan data after the failure, it can be found that a nack=0x1(retry fault) is returned. but we did not enable the interrupts for retry faults in the code.

So we need to set noretry = 1 like the above ASICs.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c +1 -0
index 1525d957e114..d4e9704dec62 100644
@@ -591,6 +591,7 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
 	case CHIP_ARCTURUS:
 	case CHIP_ALDEBARAN:
 	case CHIP_BEIGE_GOBY:
+	case CHIP_YELLOW_CARP:
 		/*
 		 * noretry = 0 will cause kfd page fault tests fail
 		 * for some ASICs, so set default to 1 for these ASICs.

--
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx