Skip to contentSkip to conversation

drm/amdgpu: Correct the irq numbers for virtual ctrc

PATCH In review Emily Deng 3 participants 5 messages Jul 1, 2021 – Jul 6, 2021

Subsystems (2)
lore
Share & tools
lore

Emily Deng

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Correct the irq numbers for virtual ctrc

---
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +1 -1
index 33324427b555..7e0d8c092c7e 100644
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
 
 static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
 {
-	adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+	adev->crtc_irq.num_types = adev->mode_info.num_crtc;
 	adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
 }
 
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

[AMD Official Use Only]

Ping......

Quoted 27 lines

-----Original Message-----
From: Emily Deng <[email protected]>
Sent: Thursday, July 1, 2021 12:38 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>; Zhao, Victor <[email protected]>
Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +1 -2
index 33324427b555..7e0d8c092c7e 100644
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
 dce_virtual_crtc_irq_funcs = {
 
 static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)  {
-      adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+      adev->crtc_irq.num_types = adev->mode_info.num_crtc;
      adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;  }
 
--
Quoted 1 line

2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#2 lore raw
Quoted 31 lines · Emily

[AMD Official Use Only]

Ping......

Quoted 26 lines

-----Original Message-----
From: Emily Deng <[email protected]>
Sent: Thursday, July 1, 2021 12:38 PM
To: [email protected]
Cc: Deng, Emily <[email protected]>; Zhao, Victor <[email protected]>
Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +1 -1
index 33324427b555..7e0d8c092c7e 100644
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
 dce_virtual_crtc_irq_funcs = {
 
 static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)  {
-      adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+      adev->crtc_irq.num_types = adev->mode_info.num_crtc;
      adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;  }
 
Quoted 7 lines
Quoted 2 lines
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +0 -1
--

2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to Emily Deng

Please describe bit more with a commit message.

Quoted 11 lines · Emily Deng
---
  drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +0 -0
index 33324427b555..7e0d8c092c7e 100644

drivers/gpu/drm/amd/amdgpu/dce_virtual.c static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = { · line 772

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +1 -1
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
 
  static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
  {
-	adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+	adev->crtc_irq.num_types = adev->mode_info.num_crtc;
  	adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
  }
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#4 lore raw

[AMD Official Use Only]

Hi Nirmoy,
Thanks, already send out another patch with updating the commit.

Best wishes
Emily Deng

Quoted 16 lines

-----Original Message-----
From: Das, Nirmoy <[email protected]>
Sent: Friday, July 2, 2021 5:03 PM
To: Deng, Emily <[email protected]>; [email protected]
Cc: Zhao, Victor <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc

Please describe bit more with a commit message.

Quoted 6 lines · Emily Deng
---
  drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c

drivers/gpu/drm/amd/amdgpu/dce_virtual.c static const struct amdgpu_irq_src_funcs

Quoted 4 lines

index 33324427b555..7e0d8c092c7e 100644

drivers/gpu/drm/amd/amdgpu/dce_virtual.c +0 -0
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs

dce_virtual_crtc_irq_funcs = {

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +1 -1
  static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
  {
-    adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+    adev->crtc_irq.num_types = adev->mode_info.num_crtc;
     adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
  }
 

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx