Skip to contentSkip to conversation

API tests cleanup

PATCH New Petr Vorel 5 participants 10 messages Jul 1, 2021

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

cover API tests cleanup

From: Petr Vorel <[email protected]>

Hi,

preparation for v4 test API cleanup.

Kind regards,
Petr

Petr Vorel (2):
lib/tests: Rename test tst_print_result.c
lib/tests: Rename test to tst_fuzzy_sync03.c

 lib/newlib_tests/.gitignore                       |  4 ++--
 lib/newlib_tests/Makefile                         |  4 ++--
 lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} |  0
 lib/newlib_tests/{test17.c => tst_print_result.c} | 10 ++++------
 4 files changed, 8 insertions(+), 10 deletions(-)
 rename lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} (100%)
 rename lib/newlib_tests/{test17.c => tst_print_result.c} (80%)
Signature · 1 line
2.32.0.rc0
author
#1 lore raw

PATCH 1/2 lib/tests: Rename test tst_print_result.c

From: Petr Vorel <[email protected]>

Also:
* remove copy pasted test description
* fix author in the copyright

Fixes cecbd0cb3 ("Fix buffer overflow in print_result() function")
---
 lib/newlib_tests/.gitignore                       |  2 +-
 lib/newlib_tests/{test17.c => tst_print_result.c} | 10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)
 rename lib/newlib_tests/{test17.c => tst_print_result.c} (80%)
lib/newlib_tests/.gitignore +1 -1
index 83a240223..9f53bbb99 100644
@@ -22,7 +22,7 @@ tst_device
 tst_safe_fileops
 tst_res_hexd
 tst_strstatus
-test17
+tst_print_result
 test18
 test19
 test20
lib/newlib_tests/tst_print_result.c renamed from lib/newlib_tests/test17.c +4 -6
similarity index 80%
rename from lib/newlib_tests/test17.c
rename to lib/newlib_tests/tst_print_result.c
index c0fc0bc30..0a2ca5af1 100644
@@ -1,12 +1,10 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * Copyright (c) 2017 Richard Palethorpe <[email protected]>
+ * Copyright (c) 2017 Veronika Kabatova <[email protected]>
  */
-/* Basic functionality test for tst_fuzzy_sync.h similar to the atomic tests
- * (test15.c). One thread writes to the odd indexes of an array while the
- * other writes to the even. If the threads are not synchronised then they
- * will probably write to the wrong indexes as they share an index variable
- * which they should take it in turns to update.
+
+/*
+ * Test for cecbd0cb3 ("Fix buffer overflow in print_result() function")
  */
 
 #include <stdlib.h>
Signature · 1 line
2.32.0.rc0
#2 lore raw

PATCH 1/2 lib/tests: Rename test tst_print_result.c

Hello Petr,

Quoted 9 lines · Petr Vorel

From: Petr Vorel <[email protected]>

Also:
* remove copy pasted test description
* fix author in the copyright

Fixes cecbd0cb3 ("Fix buffer overflow in print_result() function")
Quoted 43 lines
---
 lib/newlib_tests/.gitignore                       |  2 +-
 lib/newlib_tests/{test17.c => tst_print_result.c} | 10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)
 rename lib/newlib_tests/{test17.c => tst_print_result.c} (80%)
lib/newlib_tests/.gitignore +1 -1
index 83a240223..9f53bbb99 100644
@@ -22,7 +22,7 @@ tst_device
 tst_safe_fileops
 tst_res_hexd
 tst_strstatus
-test17
+tst_print_result
 test18
 test19
 test20
lib/newlib_tests/tst_print_result.c renamed from lib/newlib_tests/test17.c +4 -6
similarity index 80%
rename from lib/newlib_tests/test17.c
rename to lib/newlib_tests/tst_print_result.c
index c0fc0bc30..0a2ca5af1 100644
@@ -1,12 +1,10 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * Copyright (c) 2017 Richard Palethorpe <[email protected]>
+ * Copyright (c) 2017 Veronika Kabatova <[email protected]>
  */
-/* Basic functionality test for tst_fuzzy_sync.h similar to the atomic tests
- * (test15.c). One thread writes to the odd indexes of an array while the
- * other writes to the even. If the threads are not synchronised then they
- * will probably write to the wrong indexes as they share an index variable
- * which they should take it in turns to update.
+
+/*
+ * Test for cecbd0cb3 ("Fix buffer overflow in print_result() function")
  */
 
 #include <stdlib.h>
Signature · 2 lines
Thank you,
Richard.
author
#3 lore raw

PATCH 2/2 lib/tests: Rename test to tst_fuzzy_sync03.c

In reply to Petr Vorel

From: Petr Vorel <[email protected]>

---
 lib/newlib_tests/.gitignore                       | 2 +-
 lib/newlib_tests/Makefile                         | 4 ++--
 lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} | 0
 3 files changed, 3 insertions(+), 3 deletions(-)
 rename lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} (100%)
lib/newlib_tests/.gitignore +1 -1
index 9f53bbb99..b51f6a679 100644
@@ -13,7 +13,6 @@ test12
 test13
 test14
 test15
-test16
 tst_capability01
 tst_capability02
 tst_cgroup01
@@ -44,3 +43,4 @@ test_macros03
 test_macros04
 tst_fuzzy_sync01
 tst_fuzzy_sync02
+tst_fuzzy_sync03
lib/newlib_tests/Makefile +2 -2
index 5bd68e95e..1fbf7649a 100644
@@ -6,8 +6,8 @@ include $(top_srcdir)/include/mk/env_pre.mk
 CFLAGS			+= -W -Wall
 LDLIBS			+= -lltp
 
-test08 test09 test15 test16 tst_fuzzy_sync01 tst_fuzzy_sync02: CFLAGS += -pthread
-test16 tst_expiration_timer: LDLIBS += -lrt
+test08 test09 test15 tst_fuzzy_sync01 tst_fuzzy_sync02 tst_fuzzy_sync03: CFLAGS += -pthread
+tst_expiration_timer tst_fuzzy_sync03: LDLIBS += -lrt
 
 ifeq ($(ANDROID),1)
 FILTER_OUT_MAKE_TARGETS	+= test08
lib/newlib_tests/tst_fuzzy_sync03.c renamed from lib/newlib_tests/test16.c +0 -0
similarity index 100%
rename from lib/newlib_tests/test16.c
rename to lib/newlib_tests/tst_fuzzy_sync03.c
Signature · 1 line
2.32.0.rc0
#4 lore raw

PATCH 2/2 lib/tests: Rename test to tst_fuzzy_sync03.c

Hello Petr,

Quoted 3 lines · Petr Vorel

From: Petr Vorel <[email protected]>

Quoted 43 lines
---
 lib/newlib_tests/.gitignore                       | 2 +-
 lib/newlib_tests/Makefile                         | 4 ++--
 lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} | 0
 3 files changed, 3 insertions(+), 3 deletions(-)
 rename lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} (100%)
lib/newlib_tests/.gitignore +1 -1
index 9f53bbb99..b51f6a679 100644
@@ -13,7 +13,6 @@ test12
 test13
 test14
 test15
-test16
 tst_capability01
 tst_capability02
 tst_cgroup01
@@ -44,3 +43,4 @@ test_macros03
 test_macros04
 tst_fuzzy_sync01
 tst_fuzzy_sync02
+tst_fuzzy_sync03
lib/newlib_tests/Makefile +2 -2
index 5bd68e95e..1fbf7649a 100644
@@ -6,8 +6,8 @@ include $(top_srcdir)/include/mk/env_pre.mk
 CFLAGS			+= -W -Wall
 LDLIBS			+= -lltp
 
-test08 test09 test15 test16 tst_fuzzy_sync01 tst_fuzzy_sync02: CFLAGS += -pthread
-test16 tst_expiration_timer: LDLIBS += -lrt
+test08 test09 test15 tst_fuzzy_sync01 tst_fuzzy_sync02 tst_fuzzy_sync03: CFLAGS += -pthread
+tst_expiration_timer tst_fuzzy_sync03: LDLIBS += -lrt
 
 ifeq ($(ANDROID),1)
 FILTER_OUT_MAKE_TARGETS	+= test08
lib/newlib_tests/tst_fuzzy_sync03.c renamed from lib/newlib_tests/test16.c +0 -0
similarity index 100%
rename from lib/newlib_tests/test16.c
rename to lib/newlib_tests/tst_fuzzy_sync03.c
Signature · 2 lines
Thank you,
Richard.
#5 lore raw

PATCH 2/2 lib/tests: Rename test to tst_fuzzy_sync03.c

Hi all,

thanks for your review, both patches merged.

Kind regards,
Petr

#6 lore raw

cover API tests cleanup

In reply to Petr Vorel

Hi Petr

Why only rename these two tests?

ps:IMO, test01-test21 also can ben rename to a meaningful name.

Best Regards
Yang Xu

Quoted 21 lines

From: Petr Vorel<[email protected]>

Hi,

preparation for v4 test API cleanup.

Kind regards,
Petr

Petr Vorel (2):
lib/tests: Rename test tst_print_result.c
lib/tests: Rename test to tst_fuzzy_sync03.c

  lib/newlib_tests/.gitignore                       |  4 ++--
  lib/newlib_tests/Makefile                         |  4 ++--
  lib/newlib_tests/{test16.c =>  tst_fuzzy_sync03.c} |  0
  lib/newlib_tests/{test17.c =>  tst_print_result.c} | 10 ++++------
  4 files changed, 8 insertions(+), 10 deletions(-)

rename lib/newlib_tests/{test16.c => tst_fuzzy_sync03.c} (100%) rename lib/newlib_tests/{test17.c => tst_print_result.c} (80%)

#7 lore raw

cover API tests cleanup

Quoted 4 lines · On Thu, Jul 1, 2021 at 1:55 PM [email protected] <…

Hi Petr

Why only rename these two tests?

I guess Petr is recently working on investigating the tst_fuzzy_sync01 fail (I haven't got a chance to look into that issue) and do this by the opportunity.

Anyway, the rename looks good at this point:).

Quoted 3 lines

ps:IMO, test01-test21 also can ben rename to a meaningful name.

+1, someone will be appreciated if they complete that in separate patches.

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210701/2fd24b11/attachment-0001.htm>
author
#8 lore raw

cover API tests cleanup

In reply to [email protected]

Hi Xu,

Quoted 3 lines

Hi Petr

Why only rename these two tests?

There have been other tst_fuzzy_sync* tests, test17 had other issues to be fixed.

Quoted 1 line

ps:IMO, test01-test21 also can ben rename to a meaningful name.

Sure, feel free to rename more.

Kind regards,
Petr

#9 lore raw

cover API tests cleanup

Hi Petr, Li

Quoted 7 lines

Hi Xu,

Quoted 3 lines

Hi Petr

Why only rename these two tests?

There have been other tst_fuzzy_sync* tests, test17 had other issues to be fixed.

I see. Anyway, this rename patchset is ok.

Best Regards
Yang Xu

Quoted 7 lines
Quoted 2 lines

ps:IMO, test01-test21 also can ben rename to a meaningful name.

Sure, feel free to rename more.

Kind regards,
Petr