Skip to contentSkip to conversation

crypto/mvsam: fix memset of mrvl sess private data

PATCH Applied [email protected] 2 participants 2 messages Jul 1, 2021 – Jul 7, 2021 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/mvsam: fix memset of mrvl sess private data

From: Dana Vardi <[email protected]>

This patch fix wrong clear memory session pointer.

When call mrvl_crypto_pmd_sym_session_clear function, it might cause the following error:
CRYPTODEV: set_sym_session_private_data() line 497:
Set private data for driver 1 not allowed

This fix set zeroes to mrvl_crypto_session pointer instead to rte_cryptodev_sym_session pointer, and will verify that rte_cryptodev_sym_session pointer will not lose data such as nb_drivers.

Bugzilla ID: 646

Fixes 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +1 -1
index 3cb7e3b9c..1a0a9fc14 100644
@@ -794,7 +794,7 @@ mrvl_crypto_pmd_sym_session_clear(struct rte_cryptodev *dev,
 			MRVL_LOG(ERR, "Error while destroying session!");
 		}
 
-		memset(sess, 0, sizeof(struct mrvl_crypto_session));
+		memset(mrvl_sess, 0, sizeof(struct mrvl_crypto_session));
 		struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
 		set_sym_session_private_data(sess, index, NULL);
 		rte_mempool_put(sess_mp, sess_priv);
Signature · 1 line
2.29.0
Applied
#1 lore raw
Quoted 14 lines

From: Dana Vardi <[email protected]>

This patch fix wrong clear memory session pointer.

When call mrvl_crypto_pmd_sym_session_clear function, it might cause the following error:
CRYPTODEV: set_sym_session_private_data() line 497:
Set private data for driver 1 not allowed

This fix set zeroes to mrvl_crypto_session pointer instead to rte_cryptodev_sym_session pointer, and will verify that rte_cryptodev_sym_session pointer will not lose data such as nb_drivers.

Quoted 8 lines

Bugzilla ID: 646

Fixes 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")

---

Applied to dpdk-next-crypto

Thanks.