Skip to contentSkip to conversation

power: supply: cw2015: use dev_err_probe to allow deferred probe

PATCH In review Peter Robinson 3 participants 3 messages Jul 1, 2021 – Jul 16, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: supply: cw2015: use dev_err_probe to allow deferred probe

Deal with deferred probe using dev_err_probe so the error is handled and avoid logging lots probe defer information like the following:

[    9.125121] cw2015 4-0062: Failed to register power supply
[    9.211131] cw2015 4-0062: Failed to register power supply
Fixes b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
---
 drivers/power/supply/cw2015_battery.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/power/supply/cw2015_battery.c +3 -1
index d110597746b0..091868e9e9e8 100644
@@ -679,7 +679,9 @@ static int cw_bat_probe(struct i2c_client *client)
 						    &cw2015_bat_desc,
 						    &psy_cfg);
 	if (IS_ERR(cw_bat->rk_bat)) {
-		dev_err(cw_bat->dev, "Failed to register power supply\n");
+		/* try again if this happens */
+		dev_err_probe(&client->dev, PTR_ERR(cw_bat->rk_bat),
+			"Failed to register power supply\n");
 		return PTR_ERR(cw_bat->rk_bat);
 	}
 
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Peter Robinson

Deal with deferred probe using dev_err_probe so the error is handled and avoid logging lots probe defer information like the following:

[    9.125121] cw2015 4-0062: Failed to register power supply
[    9.211131] cw2015 4-0062: Failed to register power supply
Fixes b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")

---

Right, I also found this error message annoying and agree that's too noisy.

Best regards,
Javier

#2 lore raw

Hi,

Quoted 8 lines · Javier Martinez Canillas
Quoted 7 lines · Peter Robinson

Deal with deferred probe using dev_err_probe so the error is handled and avoid logging lots probe defer information like the following:

[    9.125121] cw2015 4-0062: Failed to register power supply
[    9.211131] cw2015 4-0062: Failed to register power supply
Quoted 7 lines
Quoted 3 lines
Fixes b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")

---

Right, I also found this error message annoying and agree that's too noisy.

Thanks, queued (but would have been nicer to just return dev_err_probe() instead of doing another round of PTR_ERR conversion).

-- Sebastian