power: supply: cw2015: use dev_err_probe to allow deferred probe
Subsystems (2)
PATCH 1/1 power: supply: cw2015: use dev_err_probe to allow deferred probe
Deal with deferred probe using dev_err_probe so the error is handled and avoid logging lots probe defer information like the following:
[ 9.125121] cw2015 4-0062: Failed to register power supply [ 9.211131] cw2015 4-0062: Failed to register power supply
--- drivers/power/supply/cw2015_battery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/power/supply/cw2015_battery.c +3 -1
@@ -679,7 +679,9 @@ static int cw_bat_probe(struct i2c_client *client) &cw2015_bat_desc, &psy_cfg);if (IS_ERR (cw_bat->rk_bat)) { -dev_err (cw_bat->dev,"Failed to register power supply\n" ); +/* try again if this happens */ +dev_err_probe (&client->dev,PTR_ERR (cw_bat->rk_bat), +"Failed to register power supply\n" );return PTR_ERR (cw_bat->rk_bat); }
Signature · 1 line
2.31.1
Quoted 10 lines · Peter Robinson
Deal with deferred probe using
dev_err_probeso the error is handled and avoid logging lots probe defer information like the following:[ 9.125121] cw2015 4-0062: Failed to register power supply [ 9.211131] cw2015 4-0062: Failed to register power supplyFixes b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")Signed-off-by Peter Robinson <[email protected]>---
Right, I also found this error message annoying and agree that's too noisy.
Best regards,
Javier
Hi,
Quoted 8 lines · Javier Martinez Canillas
Quoted 7 lines · Peter Robinson
Deal with deferred probe using
dev_err_probeso the error is handled and avoid logging lots probe defer information like the following:[ 9.125121] cw2015 4-0062: Failed to register power supply [ 9.211131] cw2015 4-0062: Failed to register power supply
Quoted 7 lines
Quoted 3 lines
Fixes b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")Signed-off-by Peter Robinson <[email protected]>---
Right, I also found this error message annoying and agree that's too noisy.
Reviewed-by Javier Martinez Canillas <[email protected]>
Thanks, queued (but would have been nicer to just return dev_err_probe() instead of doing another round of PTR_ERR conversion).
-- Sebastian