drm/i915/selftests: fix smatch warning in igt_check_blocks
Subsystems (2)
PATCH 1/2 drm/i915/selftests: fix smatch warning in igt_check_blocks
The block here can't be NULL, especially since we already dereferenced it earlier, so remove the redundant check.
igt_check_blocks() warn: variable dereferenced before check 'block' (see line 126)
--- drivers/gpu/drm/i915/selftests/i915_buddy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/selftests/i915_buddy.c +2 -4
@@ -166,10 +166,8 @@ static int igt_check_blocks(struct i915_buddy_mm *mm,igt_dump_block (mm, prev); } -if (block) { -pr_err ("bad block, dump:\n" ); -igt_dump_block (mm, block); - } +pr_err ("bad block, dump:\n" ); +igt_dump_block (mm, block);return err; }
Signature · 1 line
2.26.3
PATCH 2/2 drm/i915/selftests: fix smatch warning in mock_reserve
If mock_region_create fails then mem will be an error pointer. Instead we just need to use the correct ordering for the onion unwind.
igt_mock_reserve() error: 'mem' dereferencing possible ERR_PTR()
--- drivers/gpu/drm/i915/selftests/intel_memory_region.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/selftests/intel_memory_region.c +3 -2
@@ -173,7 +173,7 @@ static int igt_mock_reserve(void *arg)if (IS_ERR (mem)) {pr_err ("failed to create memory region\n" ); err =PTR_ERR (mem); - goto out_close; + goto out_free_order; }/* Reserve a bunch of ranges within the region */
@@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg) } out_close: -kfree (order);close_objects (mem, &objects);intel_memory_region_put (mem); +out_free_order: +kfree (order);return err; }
Signature · 1 line
2.26.3
Re: [PATCH 2/2] drm/i915/selftests: fix smatch warning in mock_reserve
Quoted 26 lines · Matthew Auld
If
mock_region_createfails then mem will be an error pointer. Instead we just need to use the correct ordering for the onion unwind.
igt_mock_reserve()error: 'mem' dereferencing possibleERR_PTR()Reported-by kernel test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>Signed-off-by Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/selftests/intel_memory_region.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/selftests/intel_memory_region.c +1
-1@@ -173,7 +173,7 @@ static int igt_mock_reserve(void *arg)if (IS_ERR (mem)) {pr_err ("failed to create memory region\n" ); err =PTR_ERR (mem); - goto out_close; + goto out_free_order; }/* Reserve a bunch of ranges within the region */
drivers/gpu/drm/i915/selftests/intel_memory_region.c static int igt_mock_reserve(void *arg) · line 230
Quoted 8 lines
drivers/gpu/drm/i915/selftests/intel_memory_region.c +2
-1@@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg) } out_close: -kfree (order);close_objects (mem, &objects);intel_memory_region_put (mem); +out_free_order: +kfree (order);
LGTM.
Quoted 6 lines
drivers/gpu/drm/i915/selftests/intel_memory_region.c +0
-0return err; }Signature · 1 line
2.26.3
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
URL : https://patchwork.freedesktop.org/series/92150/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 0da2bc133432 drm/i915/selftests: fix smatch warning in igt_check_blocks -:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4: Subject: [PATCH] drm/i915/selftests: fix smatch warning in igt_check_blocks
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9:igt_check_blocks() warn: variable dereferenced before check 'block' (see line 126)
total: 0 errors, 2 warnings, 0 checks, 12 lines checked337f0543a04c drm/i915/selftests: fix smatch warning in mock_reserve
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4:
Subject: [PATCH] drm/i915/selftests: fix smatch warning in mock_reserve
total: 0 errors, 1 warnings, 0 checks, 19 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
URL : https://patchwork.freedesktop.org/series/92150/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10302 -> Patchwork_20520
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/index.html
Known issues
------------
Here are the changes found in Patchwork_20520 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][1] -> [INCOMPLETE][2] ([i915#2782])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/fi-snb-2600/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/fi-snb-2600/igt@i915_selftest@[email protected]
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
Participating hosts (40 -> 34)
------------------------------
Missing (6): fi-kbl-soraka fi-bsw-cyan bat-adls-4 bat-adls-3 fi-bdw-samus bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10302 -> Patchwork_20520
CI-20190529: 20190529
CI_DRM_10302: 403c15e48caac46206e92d703408fe07d83c6bf4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20520: 337f0543a04c2c79c40f7602b5b3f19d278b3ab0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
337f0543a04c drm/i915/selftests: fix smatch warning in mock_reserve 0da2bc133432 drm/i915/selftests: fix smatch warning in igt_check_blocks
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks
URL : https://patchwork.freedesktop.org/series/92150/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10302_full -> Patchwork_20520_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20520_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20520_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20520_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_engines@execute-one:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk9/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_20520_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-clear:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#1888] / [i915#3160])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk8/igt@[email protected]
* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][7] ([i915#3002])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl6/igt@[email protected]
* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-snb5/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk8/igt@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#2842] / [i915#3468])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl7/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-tglb6/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-tglb6/igt@gem_exec_fair@[email protected]
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk6/igt@gem_exec_fair@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][17] ([i915#3296])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl3/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#180]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl2/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl6/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][20] -> [DMESG-WARN][21] ([i915#180])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-kbl6/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl4/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-kbl: [PASS][22] -> [FAIL][23] ([i915#2521])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-kbl1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl4/igt@[email protected]
* igt@kms_atomic_transition@plane-primary-toggle-with-vblank-wait:
- shard-tglb: [PASS][24] -> [DMESG-WARN][25] ([i915#2868])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-tglb2/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#110725] / [fdo#111614])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@[email protected]
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +14 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl7/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl10/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl8/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][31] ([i915#1319])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x256-sliding:
- shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271]) +40 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-snb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x85-random:
- shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#2346])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][36] -> [FAIL][37] ([i915#2346] / [i915#533])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#533])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#79])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl4/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][41] -> [DMESG-FAIL][42] ([i915#1982] / [i915#79])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl8/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#2122]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl2/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2672])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109280])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#1188])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl10/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][50] -> [FAIL][51] ([fdo#108145] / [i915#265]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl7/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl1/igt@[email protected]
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2733])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl1/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271]) +192 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl3/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2994]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl3/igt@[email protected]
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][58] ([i915#658]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][60] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-tglb6/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-tglb6/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][62] ([i915#2842]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb3/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-glk: [FAIL][64] ([i915#2842]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk1/igt@gem_exec_fair@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [FAIL][66] ([i915#2842]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-kbl2/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][68] ([i915#2842]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-tglb7/igt@gem_exec_fair@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][70] ([i915#2849]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@gem_exec_fair@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-fds-all:
- shard-glk: [DMESG-WARN][72] ([i915#118] / [i915#95]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk6/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk2/igt@[email protected]
* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-snb: [INCOMPLETE][74] ([i915#2055]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-snb5/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-snb5/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][76] ([i915#180]) -> [PASS][77] +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl6/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl1/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][78] ([i915#454]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb6/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb5/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-iclb: [FAIL][80] -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [DMESG-WARN][82] ([i915#1982]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl2/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-skl: [FAIL][84] ([i915#3444]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl7/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl1/igt@[email protected]
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][86] ([i915#2122]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk2/igt@kms_flip@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][88] ([fdo#108145] / [i915#265]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-skl7/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][90] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@kms_psr2_su@page_flip.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][92] ([fdo#109441]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [FAIL][94] ([i915#2851]) -> [FAIL][95] ([i915#2842])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk5/igt@gem_exec_fair@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk9/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][96] ([i915#658]) -> [SKIP][97] ([i915#588])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][98] ([i915#1804] / [i915#2684]) -> [WARN][99] ([i915#2684])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][100] ([i915#2920]) -> [SKIP][101] ([i915#658]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb2/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb3/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][102] ([i915#658]) -> [SKIP][103] ([i915#2920]) +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb5/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][104], [FAIL][105]) ([i915#3002] / [i915#3363]) -> ([FAIL][106], [FAIL][107], [FAIL][108]) ([i915#180] / [i915#3002] / [i915#3363])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-kbl2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-kbl7/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl2/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-kbl1/igt@[email protected]
- shard-iclb: ([FAIL][109], [FAIL][110], [FAIL][111]) ([i915#1814] / [i915#3002]) -> ([FAIL][112], [FAIL][113]) ([i915#3002])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-iclb7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb5/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-iclb6/igt@[email protected]
- shard-apl: ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl8/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl8/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-apl6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl8/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl6/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-apl6/igt@[email protected]
- shard-glk: ([FAIL][123], [FAIL][124]) ([i915#3002] / [i915#3363] / [k.org#202321]) -> ([FAIL][125], [FAIL][126], [FAIL][127]) ([i915#2722] / [i915#3002] / [i915#3363] / [k.org#202321])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk3/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10302/shard-glk4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk3/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk4/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/shard-glk9/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2851]: https://gitlab.freedesktop.org/drm/intel/issues/2851
[i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3160]: https://gitlab.freedesktop.org/drm/intel/issues/3160
[i915#3296]: https://gitlab.freedesktop.org/drm/intel/issues/3296
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3444]: https://gitlab.freedesktop.org/drm/intel/issues/3444
[i915#3468]: https://gitlab.freedesktop.org/drm/intel/issues/3468
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_10302 -> Patchwork_20520
CI-20190529: 20190529
CI_DRM_10302: 403c15e48caac46206e92d703408fe07d83c6bf4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6128: b24e5949af7e51f0af484d2ce4cb4c5a41ac5358 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20520: 337f0543a04c2c79c40f7602b5b3f19d278b3ab0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20520/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 16 lines · Matthew Auld
The block here can't be NULL, especially since we already dereferenced it earlier, so remove the redundant check.
igt_check_blocks()warn: variable dereferenced before check 'block' (see line 126)Reported-by Dan Carpenter <[email protected]>Signed-off-by Matthew Auld <[email protected]>--- drivers/gpu/drm/i915/selftests/i915_buddy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/selftests/i915_buddy.c +0
-0
drivers/gpu/drm/i915/selftests/i915_buddy.c static int igt_check_blocks(struct i915_buddy_mm *mm, · line 170
Quoted 9 lines
drivers/gpu/drm/i915/selftests/i915_buddy.c +2
-4@@ -166,10 +166,8 @@ static int igt_check_blocks(struct i915_buddy_mm *mm,igt_dump_block (mm, prev); } -if (block) { -pr_err ("bad block, dump:\n" ); -igt_dump_block (mm, block); - } +pr_err ("bad block, dump:\n" ); +igt_dump_block (mm, block);
LGTM.
Quoted 6 lines
drivers/gpu/drm/i915/selftests/i915_buddy.c +0
-0return err; }Signature · 1 line
2.26.3