target/ppc: MMU debug fixes
cover target/ppc: MMU debug fixes
A couple of fixes for the commented-out debug options in mmu_helper.c
Fabiano Rosas (2):
target/ppc: Fix compilation with DUMP_PAGE_TABLES debug option target/ppc: Fix compilation with FLUSH_ALL_TLBS debug option
target/ppc/mmu_helper.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
--
2.29.2
PATCH 1/2 target/ppc: Fix compilation with DUMP_PAGE_TABLES debug option
../target/ppc/mmu_helper.c: In function 'get_segment_6xx_tlb':../target/ppc/mmu_helper.c:514:46: error: passing argument 1 of 'ppc_hash32_hpt_mask' from incompatible pointer type [-Werror=incompatible-pointer-types]
514 | ppc_hash32_hpt_mask(env) + 0x80);
| ^~~
| |
| CPUPPCState *--- target/ppc/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/ppc/mmu_helper.c +1 -1
@@ -511,7 +511,7 @@ static int get_segment_6xx_tlb(CPUPPCState *env, mmu_ctx_t *ctx,qemu_log ("Page table: " TARGET_FMT_plx" len " TARGET_FMT_plx"\n" ,ppc_hash32_hpt_base (cpu), -ppc_hash32_hpt_mask (env) +0x80 ); +ppc_hash32_hpt_mask (cpu) +0x80 ); for (curaddr = ppc_hash32_hpt_base(cpu); curaddr < (ppc_hash32_hpt_base(cpu) + ppc_hash32_hpt_mask(cpu) + 0x80);
Signature · 1 line
2.29.2
PATCH 2/2 target/ppc: Fix compilation with FLUSH_ALL_TLBS debug option
In reply to Fabiano Rosas../target/ppc/mmu_helper.c: In function 'helper_store_ibatu':../target/ppc/mmu_helper.c:1802:17: error: unused variable 'cpu' [-Werror=unused-variable]
1802 | PowerPCCPU *cpu = env_archcpu(env);
| ^~~../target/ppc/mmu_helper.c: In function 'helper_store_dbatu':../target/ppc/mmu_helper.c:1838:17: error: unused variable 'cpu' [-Werror=unused-variable]
1838 | PowerPCCPU *cpu = env_archcpu(env);
| ^~~../target/ppc/mmu_helper.c: In function 'helper_store_601_batu':../target/ppc/mmu_helper.c:1874:17: error: unused variable 'cpu' [-Werror=unused-variable]
1874 | PowerPCCPU *cpu = env_archcpu(env);
| ^~~../target/ppc/mmu_helper.c: In function 'helper_store_601_batl':../target/ppc/mmu_helper.c:1919:17: error: unused variable 'cpu' [-Werror=unused-variable]
1919 | PowerPCCPU *cpu = env_archcpu(env);
--- target/ppc/mmu_helper.c | 8 -------- 1 file changed, 8 deletions(-)
target/ppc/mmu_helper.c +0 -8
@@ -1798,9 +1798,6 @@ static inline void dump_store_bat(CPUPPCState *env, char ID, int ul, int nr,void helper_store_ibatu (CPUPPCState *env,uint32_t nr,target_ulong value) {target_ulong mask; -#if defined(FLUSH_ALL_TLBS ) -PowerPCCPU *cpu =env_archcpu (env); -#endif dump_store_bat (env,'I' ,0 , nr, value);if (env->IBAT[0 ][nr] != value) {
@@ -1834,9 +1831,6 @@ void helper_store_ibatl(CPUPPCState *env, uint32_t nr, target_ulong value)void helper_store_dbatu (CPUPPCState *env,uint32_t nr,target_ulong value) {target_ulong mask; -#if defined(FLUSH_ALL_TLBS ) -PowerPCCPU *cpu =env_archcpu (env); -#endif dump_store_bat (env,'D' ,0 , nr, value);if (env->DBAT[0 ][nr] != value) {
@@ -1871,7 +1865,6 @@ void helper_store_601_batu(CPUPPCState *env, uint32_t nr, target_ulong value) {target_ulong mask;#if defined(FLUSH_ALL_TLBS ) -PowerPCCPU *cpu =env_archcpu (env);int do_inval;#endif
@@ -1916,7 +1909,6 @@ void helper_store_601_batl(CPUPPCState *env, uint32_t nr, target_ulong value)#if !defined(FLUSH_ALL_TLBS )target_ulong mask;#else -PowerPCCPU *cpu =env_archcpu (env);int do_inval;#endif
Signature · 1 line
2.29.2