xen/Makefile: drop -Werror
PATCH 1/1 xen/Makefile: drop -Werror
Drop -Werror to avoid the following build failure with -DNDEBUG:
In file included from <command-line>:0:0:/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
#define NDEBUG
<command-line>:0:0: note: this is the location of the previous definition
Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
--- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/Makefile +1 -1
@@ -210,7 +210,7 @@ CFLAGS += -fomit-frame-pointer endif CFLAGS += -nostdinc -fno-builtin -fno-common -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith +CFLAGS += -Wredundant-decls -Wno-pointer-arith $(call cc-option-add,CFLAGS,CC,-Wvla) CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h CFLAGS-$(CONFIG_DEBUG_INFO) += -g
Signature · 1 line
2.30.2
Quoted 6 lines · Fabrice Fontaine
Drop -Werror to avoid the following build failure with -DNDEBUG:
In file included from <command-line>:0:0:
/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
#define NDEBUG
Quoted 6 lines
<command-line>:0:0: note: this is the location of the previous definition
Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4dSigned-off-by Fabrice Fontaine <[email protected]>
For better or worse, It is Xen's policy that -Werror will remain. 95% of the time, it is the right thing. We will however build failures whenever they crop up.
This one is weird though. How is NDEBUG getting in twice? What does the rest of this build environment look like?
~Andrew
Quoted 13 lines · Andrew Cooper
Quoted 11 lines · Fabrice Fontaine
Drop -Werror to avoid the following build failure with -DNDEBUG:
In file included from <command-line>:0:0:
/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
#define NDEBUG<command-line>:0:0: note: this is the location of the previous definition
Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
Quoted 8 lines
Quoted 1 line
Signed-off-by Fabrice Fontaine <[email protected]>For better or worse, It is Xen's policy that -Werror will remain. 95% of the time, it is the right thing. We will however build failures whenever they crop up.
This one is weird though. How is NDEBUG getting in twice? What does the rest of this build environment look like?
NDEBUG is added by buildroot in the command line if the user sets BR2_ENABLE_RUNTIME_DEBUG to false since
https://git.buildroot.net/buildroot/commit/?id=5a8c50fe05afacc3cbe8e7347e238da9f242fab0
I do agree that setting -Werror is generally perfectly valid for upstream. However, for downstream packager, it is generally seen as an issue as it will always raise unexepected build failures with older, newer, or exotic toolchains, see
https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend.
It would be good to, at least, have an option to disable -Werror for example through a XEN_DISABLE_WERROR.
Quoted 2 lines
~Andrew
Best Regards,
Fabrice
Quoted 8 lines · Fabrice Fontaine
I do agree that setting -Werror is generally perfectly valid for upstream. However, for downstream packager, it is generally seen as an issue as it will always raise unexepected build failures with older, newer, or exotic toolchains, see
https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend.
It would be good to, at least, have an option to disable -Werror for example through aXEN_DISABLE_WERROR.
Two people don't make it a majority opinion, but if this was a meeting this opinion would get a second.
I don't know where everyone is on the spectrum, but I also strongly dislike -Werror yet do like -Wall and tend to get rid of warnings. -Werror is good for continuous integration systems, not so great for releases or active development.
-Werror kind of seems like Stack Ranking, good for use during brief periods, but poor for long term continuous use.
Signature · 4 lines
(\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | [email protected] PGP 87145445 | ) / \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
Quoted 10 lines · Elliott Mitchell
Quoted 8 lines · Fabrice Fontaine
I do agree that setting -Werror is generally perfectly valid for upstream. However, for downstream packager, it is generally seen as an issue as it will always raise unexepected build failures with older, newer, or exotic toolchains, see
https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend.
It would be good to, at least, have an option to disable -Werror for example through aXEN_DISABLE_WERROR.
Quoted 7 lines
Two people don't make it a majority opinion, but if this was a meeting this opinion would get a second.
I don't know where everyone is on the spectrum, but I also strongly dislike -Werror yet do like -Wall and tend to get rid of warnings. -Werror is good for continuous integration systems, not so great for releases or active development.
Well, my experience with Linux (when I started working there alongside working on Xen, many years ago) was that many people don't care at all about compiler warnings their code changes introduce. While Linux has improved some, I'm still carrying a fair size patch to silence all the warnings that I observe on various build systems (i.e. with various compiler versions). I do this because in a build with (perhaps many) pre-existing warnings it is far easier to miss the one you accidentally introduce with some code change. -Werror is an imo very appropriate measure to get people to at least address the warnings they can easily observe about everywhere. IOW I've always been appreciating Xen being different from Linux in this regard.
Jan
Quoted 21 lines · Fabrice Fontaine
Quoted 19 lines · Andrew Cooper
Quoted 6 lines · Fabrice Fontaine
Drop -Werror to avoid the following build failure with -DNDEBUG:
In file included from <command-line>:0:0:
/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
#define NDEBUGQuoted 6 lines
<command-line>:0:0: note: this is the location of the previous definition
Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4dSigned-off-by Fabrice Fontaine <[email protected]>For better or worse, It is Xen's policy that -Werror will remain. 95% of the time, it is the right thing. We will however build failures whenever they crop up.
Quoted 5 lines
Quoted 2 lines
This one is weird though. How is NDEBUG getting in twice? What does the rest of this build environment look like?
NDEBUG is added by buildroot in the command line if the user sets
BR2_ENABLE_RUNTIME_DEBUGto false since
https://git.buildroot.net/buildroot/commit/?id=5a8c50fe05afacc3cbe8e7347e238da9f242fab0
I suppose the build environment setting is really intended for user mode code. I question its applicability to the building of kernels or hypervisors, but I can see that opinions may vary here. If we wanted to honor a pre-existing NDEBUG, how about simply making xen/config.h have
#if !defined(CONFIG_DEBUG) && !defined(NDEBUG)
#define NDEBUG
#endif
? This then raises the question though how an external environment could achieve the opposite effect of suppressing NDEBUG's definition despite CONFIG_DEBUG being set. (The main point - hence my view expressed above - is that we switched to Kconfig to centralize where settings get established, moving away from taking ones from environment or make command line.)
Jan
Dear all,
Quoted 38 lines · Jan Beulich
Quoted 21 lines · Fabrice Fontaine
Quoted 19 lines · Andrew Cooper
Quoted 6 lines · Fabrice Fontaine
Drop -Werror to avoid the following build failure with -DNDEBUG:
In file included from <command-line>:0:0:
/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
#define NDEBUGQuoted 6 lines
<command-line>:0:0: note: this is the location of the previous definition
Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4dSigned-off-by Fabrice Fontaine <[email protected]>For better or worse, It is Xen's policy that -Werror will remain. 95% of the time, it is the right thing. We will however build failures whenever they crop up.
Quoted 5 lines
Quoted 2 lines
This one is weird though. How is NDEBUG getting in twice? What does the rest of this build environment look like?
NDEBUG is added by buildroot in the command line if the user sets
BR2_ENABLE_RUNTIME_DEBUGto false since
https://git.buildroot.net/buildroot/commit/?id=5a8c50fe05afacc3cbe8e7347e238da9f242fab0I suppose the build environment setting is really intended for user mode code. I question its applicability to the building of kernels or hypervisors, but I can see that opinions may vary here. If we wanted to honor a pre-existing NDEBUG, how about simply making
xen/config.hhave#if !defined(CONFIG_DEBUG) && !defined(NDEBUG)
#define NDEBUG
#endif
Quoted 6 lines
? This then raises the question though how an external environment could achieve the opposite effect of suppressing NDEBUG's definition despite
CONFIG_DEBUGbeing set. (The main point - hence my view expressed above - is that we switched toKconfigto centralize where settings get established, moving away from taking ones from environment or make command line.)
FYI, we have reverted the commit that allowed the user to set -DNDEBUG as it was raising too many build failures:
https://git.buildroot.net/buildroot/commit/?id=a1c7cff1a081765c082c196bd9e6c1e72ceee797
So, this patch is not needed anymore on buildroot side.
Quoted 3 lines
Jan
Best Regards,
Fabrice