env: efi: fix a wrong address dereference
PATCH 1/1 env: efi: fix a wrong address dereference
From: AKASHI Takahiro <[email protected]>
Probably, a pointer to a variable in an inner block should not be exposed to an outer block.
Fixes c70f44817d46 ("efi_loader: simplify 'printenv -e'")
Signed-off-by AKASHI Takahiro <[email protected]>
[trini: Don't make guid const now]
Signed-off-by Tom Rini <[email protected]>
--- cmd/nvedit_efi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
cmd/nvedit_efi.c +1 -2
@@ -241,6 +241,7 @@ int do_env_print_efi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) {const efi_guid_t *guid_p =NULL ; +efi_guid_t guid;bool verbose = true;efi_status_t ret;
@@ -254,8 +255,6 @@ int do_env_print_efi(struct cmd_tbl *cmdtp, int flag, int argc,for (argc--, argv++; argc >0 && argv[0 ][0 ] =='-' ; argc--, argv++) {if (!strcmp (argv[0 ],"-guid" )) { -efi_guid_t guid; -if (argc ==1 )return CMD_RET_USAGE ; argc--;
Signature · 1 line
2.17.1
Quoted 9 lines · Tom Rini
From: AKASHI Takahiro <[email protected]>
Probably, a pointer to a variable in an inner block should not be exposed to an outer block.
Fixes c70f44817d46 ("efi_loader: simplify 'printenv -e'")Signed-off-by AKASHI Takahiro <[email protected]>[trini: Don't make guid const now]Signed-off-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom