colo: Don't dump colo cache if dump-guest-core=off
PATCH 1/1 colo: Don't dump colo cache if dump-guest-core=off
One might set dump-guest-core=off to make coredumps smaller and still allow to debug many qemu bugs. Extend this option to the colo cache.
Signed-off-by Lukas Straub <[email protected]>
--- migration/ram.c | 6 ++++++ 1 file changed, 6 insertions(+)
migration/ram.c +6 -0
@@ -56,6 +56,8 @@#include "multifd.h" #include "sysemu/runstate.h" +#include "hw/boards.h" /* for machine_dump_guest_core() */ +#if defined(__linux__)#include "qemu/userfaultfd.h" #endif /* defined(__linux__) */
@@ -3356,6 +3358,10 @@ int colo_init_ram_cache(void) }return -errno; } +if (!machine_dump_guest_core (current_machine)) { +qemu_madvise (block->colo_cache, block->used_length, +QEMU_MADV_DONTDUMP ); + } } }
Signature · 1 line
2.20.1
Quoted 5 lines · Lukas Straub
One might set dump-guest-core=off to make coredumps smaller and still allow to debug many qemu bugs. Extend this option to the colo cache.
Signed-off-by Lukas Straub <[email protected]>
Reviewed-by Juan Quintela <[email protected]>