Skip to contentSkip to conversation

package/xen: fix build with -DNDEBUG

PATCH New Fabrice Fontaine 3 participants 3 messages Jul 2, 2021 – Jul 4, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/xen: fix build with -DNDEBUG

Fix build failure with -DNDEBUG raised since commit 5a8c50fe05afacc3cbe8e7347e238da9f242fab0

Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d

---
 .../xen/0002-xen-Makefile-drop-Werror.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/xen/0002-xen-Makefile-drop-Werror.patch
package/xen/0002-xen-Makefile-drop-Werror.patch new file +38 -0
new file mode 100644
index 0000000000..f3f13dae8f
@@ -0,0 +1,38 @@
+From e87870cf2645a4dafeea6afce290c6e6574c37ea Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Fri, 2 Jul 2021 19:00:30 +0200
+Subject: [PATCH] xen/Makefile: drop -Werror
+
+Drop -Werror to avoid the following build failure with -DNDEBUG:
+
+In file included from <command-line>:0:0:
+/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
+ #define NDEBUG
+
+<command-line>:0:0: note: this is the location of the previous definition
+
+Fixes:
+ - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: sent to xen-devel at lists.xenproject.org]
+---
+ xen/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/xen/Makefile b/xen/Makefile
+index 89879fad4c..cf9f83b1fb 100644
+--- a/xen/Makefile
++++ b/xen/Makefile
+@@ -210,7 +210,7 @@ CFLAGS += -fomit-frame-pointer
+ endif
+ 
+ CFLAGS += -nostdinc -fno-builtin -fno-common
+-CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
++CFLAGS += -Wredundant-decls -Wno-pointer-arith
+ $(call cc-option-add,CFLAGS,CC,-Wvla)
+ CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h
+ CFLAGS-$(CONFIG_DEBUG_INFO) += -g
+-- 
+2.30.2
+
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/xen: fix build with -DNDEBUG

Quoted 8 lines · Fabrice Fontaine

Fix build failure with -DNDEBUG raised since commit 5a8c50fe05afacc3cbe8e7347e238da9f242fab0

Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d

Alistair

Quoted 56 lines
---
 .../xen/0002-xen-Makefile-drop-Werror.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/xen/0002-xen-Makefile-drop-Werror.patch
package/xen/0002-xen-Makefile-drop-Werror.patch new file +38 -1
new file mode 100644
index 0000000000..f3f13dae8f
@@ -0,0 +1,38 @@
+From e87870cf2645a4dafeea6afce290c6e6574c37ea Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Fri, 2 Jul 2021 19:00:30 +0200
+Subject: [PATCH] xen/Makefile: drop -Werror
+
+Drop -Werror to avoid the following build failure with -DNDEBUG:
+
+In file included from <command-line>:0:0:
+/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
+ #define NDEBUG
+
+<command-line>:0:0: note: this is the location of the previous definition
+
+Fixes:
+ - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: sent to xen-devel at lists.xenproject.org]
+---
+ xen/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/xen/Makefile b/xen/Makefile
+index 89879fad4c..cf9f83b1fb 100644
+--- a/xen/Makefile
++++ b/xen/Makefile
+@@ -210,7 +210,7 @@ CFLAGS += -fomit-frame-pointer
+ endif
+
+ CFLAGS += -nostdinc -fno-builtin -fno-common
+-CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
++CFLAGS += -Wredundant-decls -Wno-pointer-arith
+ $(call cc-option-add,CFLAGS,CC,-Wvla)
+ CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h
+ CFLAGS-$(CONFIG_DEBUG_INFO) += -g
+--
+2.30.2
+
--

2.30.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 package/xen: fix build with -DNDEBUG

In reply to Fabrice Fontaine

Fabrice, All,

On 2021-07-02 19:07 +0200, Fabrice Fontaine spake thusly:

Quoted 7 lines

Fix build failure with -DNDEBUG raised since commit 5a8c50fe05afacc3cbe8e7347e238da9f242fab0

Fixes:
- http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d

We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.

So this patch is no longer needed; I've marked it as rejected.

Thanks!

Regards,
Yann E. MORIN.

Quoted 56 lines
---
 .../xen/0002-xen-Makefile-drop-Werror.patch   | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/xen/0002-xen-Makefile-drop-Werror.patch
package/xen/0002-xen-Makefile-drop-Werror.patch new file +38 -0
new file mode 100644
index 0000000000..f3f13dae8f
@@ -0,0 +1,38 @@
+From e87870cf2645a4dafeea6afce290c6e6574c37ea Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <[email protected]>
+Date: Fri, 2 Jul 2021 19:00:30 +0200
+Subject: [PATCH] xen/Makefile: drop -Werror
+
+Drop -Werror to avoid the following build failure with -DNDEBUG:
+
+In file included from <command-line>:0:0:
+/usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0: error: "NDEBUG" redefined [-Werror]
+ #define NDEBUG
+
+<command-line>:0:0: note: this is the location of the previous definition
+
+Fixes:
+ - http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+[Upstream status: sent to xen-devel at lists.xenproject.org]
+---
+ xen/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/xen/Makefile b/xen/Makefile
+index 89879fad4c..cf9f83b1fb 100644
+--- a/xen/Makefile
++++ b/xen/Makefile
+@@ -210,7 +210,7 @@ CFLAGS += -fomit-frame-pointer
+ endif
+ 
+ CFLAGS += -nostdinc -fno-builtin -fno-common
+-CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
++CFLAGS += -Wredundant-decls -Wno-pointer-arith
+ $(call cc-option-add,CFLAGS,CC,-Wvla)
+ CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h
+ CFLAGS-$(CONFIG_DEBUG_INFO) += -g
+-- 
+2.30.2
+
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'