Skip to contentSkip to conversation

package/qemu: disable NDEBUG

PATCH New Joseph Burt 2 participants 2 messages Jun 24, 2021 – Jul 4, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qemu: disable NDEBUG

QEMU cannot build with NDEBUG defined.

---
 package/qemu/qemu.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/qemu/qemu.mk +2 -2
index 470c285f16..c397b8883b 100644
@@ -160,7 +160,7 @@ define QEMU_CONFIGURE_CMDS
 	unset TARGET_DIR; \
 	cd $(@D); \
 		LIBS='$(QEMU_LIBS)' \
-		$(TARGET_CONFIGURE_OPTS) \
+		$(filter-out -DNDEBUG,$(TARGET_CONFIGURE_OPTS)) \
 		$(TARGET_CONFIGURE_ARGS) \
 		CPP="$(TARGET_CC) -E" \
 		$(QEMU_VARS) \
@@ -327,7 +327,7 @@ endif
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
 	unset TARGET_DIR; \
-	cd $(@D); $(HOST_CONFIGURE_OPTS) CPP="$(HOSTCC) -E" \
+	cd $(@D); $(filter-out -DNDEBUG,$(HOST_CONFIGURE_OPTS)) CPP="$(HOSTCC) -E" \
 		./configure \
 		--target-list="$(HOST_QEMU_TARGETS)" \
 		--prefix="$(HOST_DIR)" \
Signature · 1 line
2.32.0
#1 lore raw

PATCH 1/1 package/qemu: disable NDEBUG

Joseph, All,

On 2021-06-24 14:10 +0000, Joseph Burt spake thusly:

Quoted 3 lines

QEMU cannot build with NDEBUG defined.

We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.

So this patch is no longer needed; I've marked it as rejected.

Thanks!

Regards,
Yann E. MORIN.

Quoted 33 lines
---
 package/qemu/qemu.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/qemu/qemu.mk +2 -2
index 470c285f16..c397b8883b 100644
@@ -160,7 +160,7 @@ define QEMU_CONFIGURE_CMDS
 	unset TARGET_DIR; \
 	cd $(@D); \
 		LIBS='$(QEMU_LIBS)' \
-		$(TARGET_CONFIGURE_OPTS) \
+		$(filter-out -DNDEBUG,$(TARGET_CONFIGURE_OPTS)) \
 		$(TARGET_CONFIGURE_ARGS) \
 		CPP="$(TARGET_CC) -E" \
 		$(QEMU_VARS) \
@@ -327,7 +327,7 @@ endif
 # call the compiler.
 define HOST_QEMU_CONFIGURE_CMDS
 	unset TARGET_DIR; \
-	cd $(@D); $(HOST_CONFIGURE_OPTS) CPP="$(HOSTCC) -E" \
+	cd $(@D); $(filter-out -DNDEBUG,$(HOST_CONFIGURE_OPTS)) CPP="$(HOSTCC) -E" \
 		./configure \
 		--target-list="$(HOST_QEMU_TARGETS)" \
 		--prefix="$(HOST_DIR)" \
Signature · 6 lines
2.32.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'