Skip to contentSkip to conversation

package/casync: undefine NDEBUG

PATCH New Baruch Siach 2 participants 2 messages Jun 24, 2021 – Jul 4, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/casync: undefine NDEBUG

The casync code relies on assert() calls being non-empty. Undefine NDEBUG to override BR2_ENABLE_RUNTIME_DEBUG not being set.

Fixes:
http://autobuild.buildroot.net/results/4c69f45a41462564382f667f5e97b78b49c97759/
http://autobuild.buildroot.net/results/778a94f63c8e9f805badb5c8ff040dcfc5c193e7/
http://autobuild.buildroot.net/results/d4c23639747dafcded4e28602ccbe48d102c385b/

Cc Yair Ben Avraham <[email protected]>
---
 package/casync/casync.mk | 3 +++
 1 file changed, 3 insertions(+)
package/casync/casync.mk +3 -0
index d74cb1bfe85d..e161c7bbc6d3 100644
@@ -12,6 +12,9 @@ CASYNC_DEPENDENCIES = acl libcurl openssl
 
 CASYNC_CONF_OPTS = -Dman=false -Doss-fuzz=false -Dllvm-fuzz=false
 
+# Code relies on assert(false) calls
+CASYNC_CFLAGS = $(TARGET_CFLAGS) -UNDEBUG
+
 ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
 CASYNC_DEPENDENCIES += bash-completion
 # The default path is correct, leave it as-is
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/casync: undefine NDEBUG

Baruch, All,

On 2021-06-24 08:28 +0300, Baruch Siach spake thusly:

Quoted 10 lines

The casync code relies on assert() calls being non-empty. Undefine NDEBUG to override BR2_ENABLE_RUNTIME_DEBUG not being set.

Fixes:
http://autobuild.buildroot.net/results/4c69f45a41462564382f667f5e97b78b49c97759/
http://autobuild.buildroot.net/results/778a94f63c8e9f805badb5c8ff040dcfc5c193e7/
http://autobuild.buildroot.net/results/d4c23639747dafcded4e28602ccbe48d102c385b/

Cc Yair Ben Avraham <[email protected]>

We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.

So this patch is no longer needed; I've marked it as rejected.

Thanks!

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/casync/casync.mk | 3 +++
 1 file changed, 3 insertions(+)
package/casync/casync.mk +3 -0
index d74cb1bfe85d..e161c7bbc6d3 100644
@@ -12,6 +12,9 @@ CASYNC_DEPENDENCIES = acl libcurl openssl
 
 CASYNC_CONF_OPTS = -Dman=false -Doss-fuzz=false -Dllvm-fuzz=false
 
+# Code relies on assert(false) calls
+CASYNC_CFLAGS = $(TARGET_CFLAGS) -UNDEBUG
+
 ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
 CASYNC_DEPENDENCIES += bash-completion
 # The default path is correct, leave it as-is
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'