lib/test_hmm: Remove set but unused page variable
PATCH 1/1 lib/test_hmm: Remove set but unused page variable
The HMM selftests use atomic_check_access() to check atomic access to a page has been revoked. It doesn't matter if the page mapping has been removed from the mirrored page tables as that also implies atomic access has been revoked. Therefore remove the unused page variable to fix this compiler warning:
lib/test_hmm.c:631:16: warning: variable ‘page’ set but not used [-Wunused-but-set-variable]
--- lib/test_hmm.c | 2 -- 1 file changed, 2 deletions(-)
lib/test_hmm.c +0 -2
@@ -628,10 +628,8 @@ static int dmirror_check_atomic(struct dmirror *dmirror, unsigned long start,for (pfn = start >>PAGE_SHIFT ; pfn < (end >>PAGE_SHIFT ); pfn++) {void *entry; -struct page *page; entry =xa_load (&dmirror->pt, pfn); - page =xa_untag_pointer (entry);if (xa_pointer_tag (entry) ==DPT_XA_TAG_ATOMIC )return -EPERM ; }
Signature · 1 line
2.20.1
Quoted 7 lines · Alistair Popple
The HMM selftests use
atomic_check_access()to check atomic access to a page has been revoked. It doesn't matter if the page mapping has been removed from the mirrored page tables as that also implies atomic access has been revoked. Therefore remove the unused page variable to fix this compiler warning:
Quoted 7 lines
lib/test_hmm.c:631:16: warning: variable ‘page’ set but not used [-Wunused-but-set-variable]Fixes b659baea7546 ("mm: selftests for exclusive device memory")Reported-by Hulk Robot <[email protected]>Reported-by kernel test robot <[email protected]>Reported-by Yang Yingliang <[email protected]>Signed-off-by Alistair Popple <[email protected]>
Quoted 23 lines
--- lib/test_hmm.c | 2 -- 1 file changed, 2 deletions(-)lib/test_hmm.c +0
-3@@ -628,10 +628,8 @@ static int dmirror_check_atomic(struct dmirror *dmirror, unsigned long start,for (pfn = start >>PAGE_SHIFT ; pfn < (end >>PAGE_SHIFT ); pfn++) {void *entry; -struct page *page; entry =xa_load (&dmirror->pt, pfn); - page =xa_untag_pointer (entry);if (xa_pointer_tag (entry) ==DPT_XA_TAG_ATOMIC )return -EPERM ; } --2.20.1