Skip to contentSkip to conversation

drm/omapdrm: Remove outdated comment

PATCH In review Thomas Zimmermann 2 participants 3 messages Jul 6, 2021 – Jul 15, 2021

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/omapdrm: Remove outdated comment

The comment refers to drm_irq_install() et al, which are not used by omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't be used any longer. Remove the comment.

---
 drivers/gpu/drm/omapdrm/omap_irq.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/omapdrm/omap_irq.c +0 -7
index bb6e3fc18204..4aca14dab927 100644
@@ -253,13 +253,6 @@ static const u32 omap_underflow_irqs[] = {
 	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
 };
 
-/*
- * We need a special version, instead of just using drm_irq_install(),
- * because we need to register the irq via omapdss.  Once omapdss and
- * omapdrm are merged together we can assign the dispc hwmod data to
- * ourselves and drop these and just use drm_irq_{install,uninstall}()
- */
-
 int omap_drm_irq_install(struct drm_device *dev)
 {
 	struct omap_drm_private *priv = dev->dev_private;

--
2.32.0

author maintainer
#1 lore raw

ping for review

Am 06.07.21 um 09:31 schrieb Thomas Zimmermann:

Quoted 30 lines

The comment refers to drm_irq_install() et al, which are not used by omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't be used any longer. Remove the comment.

---
  drivers/gpu/drm/omapdrm/omap_irq.c | 7 -------
  1 file changed, 7 deletions(-)
drivers/gpu/drm/omapdrm/omap_irq.c +0 -8
index bb6e3fc18204..4aca14dab927 100644
@@ -253,13 +253,6 @@ static const u32 omap_underflow_irqs[] = {
  	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
  };
 
-/*
- * We need a special version, instead of just using drm_irq_install(),
- * because we need to register the irq via omapdss.  Once omapdss and
- * omapdrm are merged together we can assign the dispc hwmod data to
- * ourselves and drop these and just use drm_irq_{install,uninstall}()
- */
-
  int omap_drm_irq_install(struct drm_device *dev)
  {
  	struct omap_drm_private *priv = dev->dev_private;
--

2.32.0

Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Acked-by
#2 lore raw
Quoted 9 lines · Thomas Zimmermann

ping for review

Am 06.07.21 um 09:31 schrieb Thomas Zimmermann:

Quoted 5 lines

The comment refers to drm_irq_install() et al, which are not used by omapdrm. The functions are part of the DRM IRQ midlayer and shouldn't be used any longer. Remove the comment.

Quoted 34 lines
Quoted 23 lines
---
  drivers/gpu/drm/omapdrm/omap_irq.c | 7 -------
  1 file changed, 7 deletions(-)
drivers/gpu/drm/omapdrm/omap_irq.c +0 -8
index bb6e3fc18204..4aca14dab927 100644
@@ -253,13 +253,6 @@ static const u32 omap_underflow_irqs[] = {
      [OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
  };
 
-/*
- * We need a special version, instead of just using drm_irq_install(),
- * because we need to register the irq via omapdss.  Once omapdss and
- * omapdrm are merged together we can assign the dispc hwmod data to
- * ourselves and drop these and just use drm_irq_{install,uninstall}()
- */
-
  int omap_drm_irq_install(struct drm_device *dev)
  {
      struct omap_drm_private *priv = dev->dev_private;
--
Quoted 2 lines

2.32.0

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch