Skip to contentSkip to conversation

writeback-cgroup-add-smp_mb-to-cgroup_writeback_umount.patch removed from -mm tree

merged [email protected] 1 participant 1 message Jul 6, 2021

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: writeback, cgroup: add smp_mb() to cgroup_writeback_umount()
has been removed from the -mm tree. Its filename was
writeback-cgroup-add-smp_mb-to-cgroup_writeback_umount.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Roman Gushchin <[email protected]>
Subject: writeback, cgroup: add smp_mb() to cgroup_writeback_umount()

A full memory barrier is required between clearing SB_ACTIVE flag in generic_shutdown_super() and checking isw_nr_in_flight in cgroup_writeback_umount(), otherwise a new switch operation might be scheduled after atomic_read(&isw_nr_in_flight) returned 0. This would result in a non-flushed isw_wq, and a potential crash.

The problem hasn't yet been seen in the real life and was discovered by Jan Kara by looking into the code.

---

 fs/fs-writeback.c |    6 ++++++
 1 file changed, 6 insertions(+)
fs/fs-writeback.c renamed from fs/fs-writeback.c~writeback-cgroup-add-smp_mb-to-cgroup_writeback_umount +6 -0
@@ -1000,6 +1000,12 @@ out_bdi_put:
  */
 void cgroup_writeback_umount(void)
 {
+	/*
+	 * SB_ACTIVE should be reliably cleared before checking
+	 * isw_nr_in_flight, see generic_shutdown_super().
+	 */
+	smp_mb();
+
 	if (atomic_read(&isw_nr_in_flight)) {
 		/*
 		 * Use rcu_barrier() to wait for all pending callbacks to

_

Patches currently in -mm which might be from [email protected] are