Skip to contentSkip to conversation

mm-page_alloc-disassociate-the-pcp-high-from-pcp-batch.patch removed from -mm tree

merged [email protected] 1 participant 1 message Jul 6, 2021

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled

     Subject: mm/page_alloc: disassociate the pcp->high from pcp->batch

has been removed from the -mm tree. Its filename was
mm-page_alloc-disassociate-the-pcp-high-from-pcp-batch.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Mel Gorman <[email protected]>
Subject: mm/page_alloc: disassociate the pcp->high from pcp->batch

The pcp high watermark is based on the batch size but there is no relationship between them other than it is convenient to use early in boot.

This patch takes the first step and bases pcp->high on the zone low watermark split across the number of CPUs local to a zone while the batch size remains the same to avoid increasing allocation latencies. The intent behind the default pcp->high is "set the number of PCP pages such that if they are all full that background reclaim is not started prematurely".

Note that in this patch the pcp->high values are adjusted after memory hotplug events, min_free_kbytes adjustments and watermark scale factor adjustments but not CPU hotplug events which is handled later in the series.

On a test KVM instance;

Before grep -E "high:|batch" /proc/zoneinfo | tail -2

              high:  378
              batch: 63

After grep -E "high:|batch" /proc/zoneinfo | tail -2

              high:  649
              batch: 63

[[email protected]: fix __setup_per_zone_wmarks for parallel memory hotplug]

---

 mm/memory_hotplug.c |    6 ++--
 mm/page_alloc.c     |   62 +++++++++++++++++++++++++++++-------------
 2 files changed, 47 insertions(+), 21 deletions(-)
mm/memory_hotplug.c renamed from mm/memory_hotplug.c~mm-page_alloc-disassociate-the-pcp-high-from-pcp-batch +3 -3
@@ -961,7 +961,6 @@ int __ref online_pages(unsigned long pfn
 	node_states_set_node(nid, &arg);
 	if (need_zonelists_rebuild)
 		build_all_zonelists(NULL);
-	zone_pcp_update(zone);
 
 	/* Basic onlining is complete, allow allocation of onlined pages. */
 	undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE);
@@ -974,6 +973,7 @@ int __ref online_pages(unsigned long pfn
 	 */
 	shuffle_zone(zone);
 
+	/* reinitialise watermarks and update pcp limits */
 	init_per_zone_wmark_min();
 
 	kswapd_run(nid);
@@ -1829,13 +1829,13 @@ int __ref offline_pages(unsigned long st
 	adjust_managed_page_count(pfn_to_page(start_pfn), -nr_pages);
 	adjust_present_page_count(zone, -nr_pages);
 
+	/* reinitialise watermarks and update pcp limits */
 	init_per_zone_wmark_min();
 
 	if (!populated_zone(zone)) {
 		zone_pcp_reset(zone);
 		build_all_zonelists(NULL);
-	} else
-		zone_pcp_update(zone);
+	}
 
 	node_states_clear_node(node, &arg);
 	if (arg.status_change_nid >= 0) {
mm/page_alloc.c renamed from mm/page_alloc.c~mm-page_alloc-disassociate-the-pcp-high-from-pcp-batch +44 -18

99 lines not on this page · raw message

_

Patches currently in -mm which might be from [email protected] are