mtd: core: handle flashes without OTP gracefully
PATCH v2 1/1 mtd: core: handle flashes without OTP gracefully
There are flash drivers which registers the OTP callbacks although the flash doesn't support OTP regions and return -ENODATA for these callbacks if there is no OTP. If this happens, the probe of the whole flash will fail. Fix it by handling the ENODATA return code and skip the OTP region nvmem setup.
---
changes since v1:
- move the check into mtd_otp_size()
drivers/mtd/mtdcore.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mtd/mtdcore.c +3 -1
@@ -806,7 +806,9 @@ static ssize_t mtd_otp_size(struct mtd_info *mtd, bool is_user) err:kfree (info); -return ret; + +/* ENODATA means there is no OTP region. */ +return ret == -ENODATA ?0 : ret; } static struct nvmem_device *mtd_otp_nvmem_register(struct mtd_info *mtd,
Signature · 1 line
2.20.1
Quoted 10 lines · Michael Walle
There are flash drivers which registers the OTP callbacks although the flash doesn't support OTP regions and return
-ENODATAfor these callbacks if there is no OTP. If this happens, the probe of the whole flash will fail. Fix it by handling the ENODATA return code and skip the OTP region nvmem setup.Fixes 4b361cfa8624 ("mtd: core: add OTP nvmem provider support")Reported-by Guenter Roeck <[email protected]>Signed-off-by Michael Walle <[email protected]>Tested-by Guenter Roeck <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel