Skip to contentSkip to conversation

LICENSES/dual/CC-BY-4.0: Lets switch to utf-8

PATCH In review Nishanth Menon 6 participants 8 messages Jul 3, 2021 – Jul 12, 2021 Licenses and spdx stuff

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 LICENSES/dual/CC-BY-4.0: Lets switch to utf-8

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
LICENSES/dual/CC-BY-4.0 +1 -1
index 45a81b8e4669..869cad3d1643 100644
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons
 public licenses is dedicated to the public domain under the CC0 Public
 Domain Dedication. Except for the limited purpose of indicating that
 material is shared under a Creative Commons public license or as
Signature · 1 line
2.32.0
Acked-by on v1 1/1
#1 lore raw
Quoted 29 lines · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
LICENSES/dual/CC-BY-4.0 +0 -0
index 45a81b8e4669..869cad3d1643 100644

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 398

Quoted 8 lines
LICENSES/dual/CC-BY-4.0 +1 -1
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons
 public licenses is dedicated to the public domain under the CC0 Public
 Domain Dedication. Except for the limited purpose of indicating that
 material is shared under a Creative Commons public license or as

Thanks.

Signature · 1 line
~Randy
#2 lore raw
In reply to Nishanth Menon
Quoted 8 lines · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")

So...this file *is* in UTF-8; I'm finding your changelog a bit confusing.

Quoted 19 lines
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
LICENSES/dual/CC-BY-4.0 +0 -0
index 45a81b8e4669..869cad3d1643 100644

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 395

Quoted 5 lines
LICENSES/dual/CC-BY-4.0 +1 -1
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons

It seems that what you're really doing is replacing "smart quotes" with the basic ASCII variety? That seems like a fine thing to do, but that's not really what the changelog says.

I can tweak it when I apply this.

Meanwhile, though, if there's a bug it's the spdxcheck.py issue reported by Rahul. That problem doesn't reproduce here; he must be running in an environment where ASCII is assumed. Being explicit about the encoding expected is the right fix in any case... Maybe I'll snag that patch as well if nobody else beats me to it.

Thanks,

jon

#3 lore raw
Quoted 6 lines · Jonathan Corbet
Quoted 4 lines · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

Quoted 7 lines
Quoted 4 lines

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")

So...this file *is* in UTF-8; I'm finding your changelog a bit confusing.

Ahh, I'm not the only one here.

Quoted 14 lines
Quoted 14 lines
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 395

Quoted 10 lines
LICENSES/dual/CC-BY-4.0 +1 -1
index 45a81b8e4669..869cad3d1643 100644
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons

FWIW, I kinda like that the text (apart from the intro) up to now is identical to the official license text (where I copied it from iirc when I added it), but well, the type of quotes really shouldn't matter, so:

Quoted 3 lines

It seems that what you're really doing is replacing "smart quotes" with the basic ASCII variety? That seems like a fine thing to do, but that's not really what the changelog says.

Thx for handling this, Jon.

Quoted 1 line

[...]

Ciao, Thorsten

#4 lore raw
In reply to Jonathan Corbet
Quoted 6 lines · Jonathan Corbet
Quoted 4 lines · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

Quoted 7 lines
Quoted 4 lines

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")

So...this file *is* in UTF-8; I'm finding your changelog a bit confusing.

Arrgh, you are right.

Quoted 15 lines
Quoted 15 lines
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 395

Quoted 10 lines
LICENSES/dual/CC-BY-4.0 +1 -1
index 45a81b8e4669..869cad3d1643 100644
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons

It seems that what you're really doing is replacing "smart quotes" with the basic ASCII variety? That seems like a fine thing to do, but that's not really what the changelog says.

Yes, that was the intent, the description and $subject came out all wrong.

Quoted 2 lines

I can tweak it when I apply this.

Thanks. Let me know if it turns out that I need to respin the patch.

Quoted 6 lines

Meanwhile, though, if there's a bug it's the spdxcheck.py issue reported by Rahul. That problem doesn't reproduce here; he must be running in an environment where ASCII is assumed. Being explicit about the encoding expected is the right fix in any case... Maybe I'll snag that patch as well if nobody else beats me to it.

Thanks again.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Acked-by on v1 1/1
#5 lore raw
In reply to Nishanth Menon

Nishanth,

Quoted 1 line · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with

Again: s/Lets//

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 395

Quoted 8 lines

equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

Creative Commons is not a party to its public
licenses. Notwithstanding, Creative Commons may elect to apply one of its public licenses to material it publishes and in those instances

LICENSES/dual/CC-BY-4.0 +1 -1
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons

In theory the License text should be a verbatim copy. But yes, this unicode stuff is a pain.

#6 lore raw
Quoted 9 lines · Thomas Gleixner

Nishanth,

Quoted 1 line · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with

Again: s/Lets//

Quoted 2 lines

equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

s/utf-8/ASCII/? otherwise the description makes no sense...

Quoted 6 lines

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 395

Quoted 3 lines

its public licenses to material it publishes and in those instances

LICENSES/dual/CC-BY-4.0 +1 -1
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons

In theory the License text should be a verbatim copy. But yes, this unicode stuff is a pain.

But we use unicode elsewhere for random stuff, and license should be verbatim, so I'm not sure this is good idea.

Pavel

#7 lore raw
In reply to Nishanth Menon
Quoted 28 lines · Nishanth Menon

Lets drop the unicode characters that peeped in and replace with equivalent utf-8 characters. This makes the CC-BY-4.0 file inline with rest of license files.

This messes up code such as scripts/spdxcheck.py which assumed utf-8 LICENSE files.

Fixes bc41a7f36469 ("LICENSES: Add the CC-BY-4.0 license")
Cc Thorsten Leemhuis <[email protected]>
CC Thomas Gleixner <[email protected]>
CC Greg Kroah-Hartman <[email protected]>
CC Christoph Hellwig <[email protected]>
Cc Jonathan Corbet <[email protected]>

---
also see: https://lore.kernel.org/linux-spdx/[email protected]/T/#u

 LICENSES/dual/CC-BY-4.0 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
LICENSES/dual/CC-BY-4.0 +0 -0
index 45a81b8e4669..869cad3d1643 100644

LICENSES/dual/CC-BY-4.0 Section 8 -- Interpretation. · line 396

Quoted 6 lines
LICENSES/dual/CC-BY-4.0 +1 -1
@@ -392,7 +392,7 @@ Section 8 -- Interpretation.
 Creative Commons is not a party to its public
 licenses. Notwithstanding, Creative Commons may elect to apply one of
 its public licenses to material it publishes and in those instances
-will be considered the “Licensor.” The text of the Creative Commons
+will be considered the "Licensor." The text of the Creative Commons
 public licenses is dedicated to the public domain under the CC0 Public

...and I've applied this one as well.

Thanks,

jon