Skip to contentSkip to conversation

gpu: ttm: fix GPF in ttm_bo_release

PATCH In review Pavel Skripkin 2 participants 7 messages Jul 7, 2021 – Jul 8, 2021 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: ttm: fix GPF in ttm_bo_release

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced
(bo embedded in this object)
ttm_bo_init()

    ttm_bo_init_reserved()
      ttm_resource_alloc()
        man->func->alloc()       <-- allocation failure
      ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

So, I've added check in ttm_bo_release() to avoid passing NULL as second argument to ttm_mem_io_free().

Fail log:

KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
CPU: 1 PID: 10419 Comm: syz-executor.3 Not tainted 5.13.0-rc7-next-20210625 #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
RIP: 0010:ttm_mem_io_free+0x28/0x170 drivers/gpu/drm/ttm/ttm_bo_util.c:66
Code: b1 90 41 56 41 55 41 54 55 48 89 fd 53 48 89 f3 e8 cd 19 24 fd 4c 8d 6b 20 48 b8 00 00 00 00 00 fc ff df 4c 89 ea 48 c1 ea 03 <80> 3c 02 00 0f 85 2a 01 00 00 4c 8b 63 20 31 ff 4c 89 e6 e8 00 1f
RSP: 0018:ffffc900141df968 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc90010da0000
RDX: 0000000000000004 RSI: ffffffff84513ea3 RDI: ffff888041fbc010
RBP: ffff888041fbc010 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000020 R14: ffff88806b258800 R15: ffff88806b258a38
FS:  00007fa6e9845640(0000) GS:ffff88807ec00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fad61265e18 CR3: 000000005ad79000 CR4: 0000000000350ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 ttm_bo_release+0xd94/0x10a0 drivers/gpu/drm/ttm/ttm_bo.c:422
 kref_put include/linux/kref.h:65 [inline]
 ttm_bo_put drivers/gpu/drm/ttm/ttm_bo.c:470 [inline]
 ttm_bo_init_reserved+0x7cb/0x960 drivers/gpu/drm/ttm/ttm_bo.c:1050
 ttm_bo_init+0x105/0x270 drivers/gpu/drm/ttm/ttm_bo.c:1074
 drm_gem_vram_create+0x332/0x4c0 drivers/gpu/drm/drm_gem_vram_helper.c:228
Fixes d3116756a710 ("drm/ttm: rename bo->mem and make it a pointer")
---
 drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +2 -1
index 1b950b45cf4b..15eb97459eab 100644
@@ -419,7 +419,8 @@ static void ttm_bo_release(struct kref *kref)
 			bo->bdev->funcs->release_notify(bo);
 
 		drm_vma_offset_remove(bdev->vma_manager, &bo->base.vma_node);
-		ttm_mem_io_free(bdev, bo->resource);
+		if (bo->resource)
+			ttm_mem_io_free(bdev, bo->resource);
 	}
 
 	if (!dma_resv_test_signaled(bo->base.resv, true) ||
Signature · 1 line
2.32.0
#1 lore raw

Am 07.07.21 um 20:51 schrieb Pavel Skripkin:

Quoted 16 lines

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced
(bo embedded in this object)
ttm_bo_init()

     ttm_bo_init_reserved()
       ttm_resource_alloc()
         man->func->alloc()       <-- allocation failure
       ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*
Quoted 2 lines

So, I've added check in ttm_bo_release() to avoid passing NULL as second argument to ttm_mem_io_free().

There is another ocassion of this a bit down before we call ttm_bo_move_to_lru_tail() apart from that good catch.

But I'm wondering if we should make the functions NULL save instead of the external check.

Thanks,
Christian.

Quoted 47 lines

Fail log:

KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
CPU: 1 PID: 10419 Comm: syz-executor.3 Not tainted 5.13.0-rc7-next-20210625 #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
RIP: 0010:ttm_mem_io_free+0x28/0x170 drivers/gpu/drm/ttm/ttm_bo_util.c:66
Code: b1 90 41 56 41 55 41 54 55 48 89 fd 53 48 89 f3 e8 cd 19 24 fd 4c 8d 6b 20 48 b8 00 00 00 00 00 fc ff df 4c 89 ea 48 c1 ea 03 <80> 3c 02 00 0f 85 2a 01 00 00 4c 8b 63 20 31 ff 4c 89 e6 e8 00 1f
RSP: 0018:ffffc900141df968 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc90010da0000
RDX: 0000000000000004 RSI: ffffffff84513ea3 RDI: ffff888041fbc010
RBP: ffff888041fbc010 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000020 R14: ffff88806b258800 R15: ffff88806b258a38
FS:  00007fa6e9845640(0000) GS:ffff88807ec00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fad61265e18 CR3: 000000005ad79000 CR4: 0000000000350ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
  ttm_bo_release+0xd94/0x10a0 drivers/gpu/drm/ttm/ttm_bo.c:422
  kref_put include/linux/kref.h:65 [inline]
  ttm_bo_put drivers/gpu/drm/ttm/ttm_bo.c:470 [inline]
  ttm_bo_init_reserved+0x7cb/0x960 drivers/gpu/drm/ttm/ttm_bo.c:1050
  ttm_bo_init+0x105/0x270 drivers/gpu/drm/ttm/ttm_bo.c:1074
  drm_gem_vram_create+0x332/0x4c0 drivers/gpu/drm/drm_gem_vram_helper.c:228
Fixes d3116756a710 ("drm/ttm: rename bo->mem and make it a pointer")
---
  drivers/gpu/drm/ttm/ttm_bo.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +2 -1
index 1b950b45cf4b..15eb97459eab 100644
@@ -419,7 +419,8 @@ static void ttm_bo_release(struct kref *kref)
  			bo->bdev->funcs->release_notify(bo);
 
  		drm_vma_offset_remove(bdev->vma_manager, &bo->base.vma_node);
-		ttm_mem_io_free(bdev, bo->resource);
+		if (bo->resource)
+			ttm_mem_io_free(bdev, bo->resource);
  	}
 
  	if (!dma_resv_test_signaled(bo->base.resv, true) ||

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 47 lines · On Thu, 8 Jul 2021 11:37:01 +0300 Pavel Skripkin <[email protected]> wrote:
Quoted 19 lines · On Thu, 8 Jul 2021 08:49:48 +0200 Christian König <[email protected]>…

Am 07.07.21 um 20:51 schrieb Pavel Skripkin:

Quoted 18 lines

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced
(bo embedded in this object)
ttm_bo_init()

     ttm_bo_init_reserved()
       ttm_resource_alloc()
         man->func->alloc()       <-- allocation failure
       ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

So, I've added check in ttm_bo_release() to avoid passing NULL as second argument to ttm_mem_io_free().

Hi, Christian!

Thank you for quick feedback :)

Quoted 4 lines

There is another ocassion of this a bit down before we call ttm_bo_move_to_lru_tail() apart from that good catch.

Did you mean, that ttm_bo_move_to_lru_tail() should have NULL check too? I checked it's realization, and, I think, NULL check is necessary there, since mem pointer is dereferenced w/o any checking

Quoted 3 lines

But I'm wondering if we should make the functions NULL save instead of the external check.

I tried to find more possible scenarios of GPF in ttm_bo_release(), but I didn't find one. But, yes, moving NULL check inside ttm_mem_io_free() is more general approach and it will defend this function from GPFs in the future.

Quoted 3 lines

With regards,
Pavel Skripkin

I misclicked and sent this email to Christian privately :(

Added all thread participants back, sorry.

With regards,
Pavel Skripkin

#4 lore raw

Am 08.07.21 um 12:09 schrieb Pavel Skripkin:

Quoted 27 lines
Quoted 24 lines · On Thu, 8 Jul 2021 11:37:01 +0300 Pavel Skripkin <[email protected]> wrote:
Quoted 19 lines · On Thu, 8 Jul 2021 08:49:48 +0200 Christian König <[email protected]>…

Am 07.07.21 um 20:51 schrieb Pavel Skripkin:

Quoted 18 lines

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced

				     (bo embedded in this object)
    ttm_bo_init()
      ttm_bo_init_reserved()
        ttm_resource_alloc()
          man->func->alloc()       <-- allocation failure
        ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

So, I've added check in ttm_bo_release() to avoid passing NULL as second argument to ttm_mem_io_free().

Hi, Christian!

Quoted 7 lines
Quoted 7 lines

Thank you for quick feedback :)

Quoted 3 lines

There is another ocassion of this a bit down before we call ttm_bo_move_to_lru_tail() apart from that good catch.

Did you mean, that ttm_bo_move_to_lru_tail() should have NULL check too?

Yes, exactly that.

Quoted 13 lines
Quoted 13 lines

I checked it's realization, and, I think, NULL check is necessary
there, since mem pointer is dereferenced w/o any checking

Quoted 3 lines

But I'm wondering if we should make the functions NULL save instead of the external check.

I tried to find more possible scenarios of GPF in ttm_bo_release(), but I didn't find one. But, yes, moving NULL check inside ttm_mem_io_free() is more general approach and it will defend this function from GPFs in the future.

Quoted 6 lines
Quoted 3 lines

With regards,
Pavel Skripkin

I misclicked and sent this email to Christian privately :(

Added all thread participants back, sorry.

No problem.

Do you want to update your patch or should I take care of this?

Thanks,
Christian.

Quoted 5 lines

With regards,
Pavel Skripkin

#5 lore raw
Quoted 54 lines · On Thu, 8 Jul 2021 12:56:19 +0200 Christian König <[email protected]>…

Am 08.07.21 um 12:09 schrieb Pavel Skripkin:

Quoted 27 lines
Quoted 24 lines · On Thu, 8 Jul 2021 11:37:01 +0300 Pavel Skripkin <[email protected]> wrote:
Quoted 19 lines · On Thu, 8 Jul 2021 08:49:48 +0200 Christian König <[email protected]>…

Am 07.07.21 um 20:51 schrieb Pavel Skripkin:

Quoted 18 lines

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object
kzalloced (bo embedded in this object)

    ttm_bo_init()
      ttm_bo_init_reserved()
        ttm_resource_alloc()
          man->func->alloc()       <-- allocation failure
        ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

So, I've added check in ttm_bo_release() to avoid passing NULL as second argument to ttm_mem_io_free().

Hi, Christian!

Quoted 7 lines
Quoted 7 lines

Thank you for quick feedback :)

Quoted 3 lines

There is another ocassion of this a bit down before we call ttm_bo_move_to_lru_tail() apart from that good catch.

Did you mean, that ttm_bo_move_to_lru_tail() should have NULL check too?

Yes, exactly that.

Quoted 16 lines
Quoted 16 lines

I checked it's realization, and, I think, NULL check is necessary
there, since mem pointer is dereferenced w/o any checking

Quoted 3 lines

But I'm wondering if we should make the functions NULL save instead of the external check.

I tried to find more possible scenarios of GPF in ttm_bo_release(), but I didn't find one. But, yes, moving NULL check inside ttm_mem_io_free() is more general approach and it will defend this function from GPFs in the future.

With regards,
Pavel Skripkin

Quoted 8 lines
Quoted 3 lines

I misclicked and sent this email to Christian privately :(

Added all thread participants back, sorry.

No problem.

Do you want to update your patch or should I take care of this?

Yes, I will send v2 soon. Thank you!

With regards,
Pavel Skripkin

#6 lore raw

PATCH v2 1/1 gpu: ttm: add missing NULL checks

In reply to Christian König

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced
(bo embedded in this object)
ttm_bo_init()

    ttm_bo_init_reserved()
      ttm_resource_alloc()
        man->func->alloc()       <-- allocation failure
      ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

Added NULL check inside ttm_mem_io_free() to prevent reported GPF and make this function NULL save in future.

Same problem was in ttm_bo_move_to_lru_tail() as Christian reported. ttm_bo_move_to_lru_tail() is called in ttm_bo_release() and mem pointer can be NULL as well as in ttm_mem_io_free().

Fail log:

KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
CPU: 1 PID: 10419 Comm: syz-executor.3 Not tainted 5.13.0-rc7-next-20210625 #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
RIP: 0010:ttm_mem_io_free+0x28/0x170 drivers/gpu/drm/ttm/ttm_bo_util.c:66
Code: b1 90 41 56 41 55 41 54 55 48 89 fd 53 48 89 f3 e8 cd 19 24 fd 4c 8d 6b 20 48 b8 00 00 00 00 00 fc ff df 4c 89 ea 48 c1 ea 03 <80> 3c 02 00 0f 85 2a 01 00 00 4c 8b 63 20 31 ff 4c 89 e6 e8 00 1f
RSP: 0018:ffffc900141df968 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc90010da0000
RDX: 0000000000000004 RSI: ffffffff84513ea3 RDI: ffff888041fbc010
RBP: ffff888041fbc010 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000020 R14: ffff88806b258800 R15: ffff88806b258a38
FS:  00007fa6e9845640(0000) GS:ffff88807ec00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fad61265e18 CR3: 000000005ad79000 CR4: 0000000000350ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 ttm_bo_release+0xd94/0x10a0 drivers/gpu/drm/ttm/ttm_bo.c:422
 kref_put include/linux/kref.h:65 [inline]
 ttm_bo_put drivers/gpu/drm/ttm/ttm_bo.c:470 [inline]
 ttm_bo_init_reserved+0x7cb/0x960 drivers/gpu/drm/ttm/ttm_bo.c:1050
 ttm_bo_init+0x105/0x270 drivers/gpu/drm/ttm/ttm_bo.c:1074
 drm_gem_vram_create+0x332/0x4c0 drivers/gpu/drm/drm_gem_vram_helper.c:228
Fixes d3116756a710 ("drm/ttm: rename bo->mem and make it a pointer")

---

Changes in v2:
1. Added NULL check in ttm_bo_move_to_lru_tail()

2. Changed subject line, since NULL check added in 2 funtions

---
 drivers/gpu/drm/ttm/ttm_bo.c      | 3 +++
 drivers/gpu/drm/ttm/ttm_bo_util.c | 3 +++
 2 files changed, 6 insertions(+)
drivers/gpu/drm/ttm/ttm_bo.c +3 -0
index 1b950b45cf4b..8d7fd65ccced 100644
@@ -102,6 +102,9 @@ void ttm_bo_move_to_lru_tail(struct ttm_buffer_object *bo,
 		return;
 	}
 
+	if (!mem)
+		return;
+
 	man = ttm_manager_type(bdev, mem->mem_type);
 	list_move_tail(&bo->lru, &man->lru[bo->priority]);
 
drivers/gpu/drm/ttm/ttm_bo_util.c +3 -0
index 2f57f824e6db..763fa6f4e07d 100644
@@ -63,6 +63,9 @@ int ttm_mem_io_reserve(struct ttm_device *bdev,
 void ttm_mem_io_free(struct ttm_device *bdev,
 		     struct ttm_resource *mem)
 {
+	if (!mem)
+		return;
+
 	if (!mem->bus.offset && !mem->bus.addr)
 		return;
 
Signature · 1 line
2.32.0
Reviewed-by on v2 1/1
#7 lore raw

Re: [PATCH v2] gpu: ttm: add missing NULL checks

Am 08.07.21 um 13:25 schrieb Pavel Skripkin:

Quoted 49 lines

My local syzbot instance hit GPF in ttm_bo_release(). Unfortunately, syzbot didn't produce a reproducer for this, but I found out possible scenario:

drm_gem_vram_create() <-- drm_gem_vram_object kzalloced
(bo embedded in this object)
ttm_bo_init()

     ttm_bo_init_reserved()
       ttm_resource_alloc()
         man->func->alloc()       <-- allocation failure
       ttm_bo_put()
	ttm_bo_release()
	  ttm_mem_io_free()      <-- bo->resource == NULL passed
				     as second argument
	     *GPF*

Added NULL check inside ttm_mem_io_free() to prevent reported GPF and make this function NULL save in future.

Same problem was in ttm_bo_move_to_lru_tail() as Christian reported. ttm_bo_move_to_lru_tail() is called in ttm_bo_release() and mem pointer can be NULL as well as in ttm_mem_io_free().

Fail log:

KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027]
CPU: 1 PID: 10419 Comm: syz-executor.3 Not tainted 5.13.0-rc7-next-20210625 #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a-rebuilt.opensuse.org 04/01/2014
RIP: 0010:ttm_mem_io_free+0x28/0x170 drivers/gpu/drm/ttm/ttm_bo_util.c:66
Code: b1 90 41 56 41 55 41 54 55 48 89 fd 53 48 89 f3 e8 cd 19 24 fd 4c 8d 6b 20 48 b8 00 00 00 00 00 fc ff df 4c 89 ea 48 c1 ea 03 <80> 3c 02 00 0f 85 2a 01 00 00 4c 8b 63 20 31 ff 4c 89 e6 e8 00 1f
RSP: 0018:ffffc900141df968 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc90010da0000
RDX: 0000000000000004 RSI: ffffffff84513ea3 RDI: ffff888041fbc010
RBP: ffff888041fbc010 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000020 R14: ffff88806b258800 R15: ffff88806b258a38
FS:  00007fa6e9845640(0000) GS:ffff88807ec00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fad61265e18 CR3: 000000005ad79000 CR4: 0000000000350ee0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
  ttm_bo_release+0xd94/0x10a0 drivers/gpu/drm/ttm/ttm_bo.c:422
  kref_put include/linux/kref.h:65 [inline]
  ttm_bo_put drivers/gpu/drm/ttm/ttm_bo.c:470 [inline]
  ttm_bo_init_reserved+0x7cb/0x960 drivers/gpu/drm/ttm/ttm_bo.c:1050
  ttm_bo_init+0x105/0x270 drivers/gpu/drm/ttm/ttm_bo.c:1074
  drm_gem_vram_create+0x332/0x4c0 drivers/gpu/drm/drm_gem_vram_helper.c:228
Quoted 2 lines
Fixes d3116756a710 ("drm/ttm: rename bo->mem and make it a pointer")

Going to push this to drm-misc-next-fixes.

Thanks,
Christian.

Quoted 40 lines

---

Changes in v2:
1. Added NULL check in ttm_bo_move_to_lru_tail()

2. Changed subject line, since NULL check added in 2 funtions

---
  drivers/gpu/drm/ttm/ttm_bo.c      | 3 +++
  drivers/gpu/drm/ttm/ttm_bo_util.c | 3 +++
  2 files changed, 6 insertions(+)
drivers/gpu/drm/ttm/ttm_bo.c +3 -0
index 1b950b45cf4b..8d7fd65ccced 100644
@@ -102,6 +102,9 @@ void ttm_bo_move_to_lru_tail(struct ttm_buffer_object *bo,
  		return;
  	}
 
+	if (!mem)
+		return;
+
  	man = ttm_manager_type(bdev, mem->mem_type);
  	list_move_tail(&bo->lru, &man->lru[bo->priority]);
 
drivers/gpu/drm/ttm/ttm_bo_util.c +3 -0
index 2f57f824e6db..763fa6f4e07d 100644
@@ -63,6 +63,9 @@ int ttm_mem_io_reserve(struct ttm_device *bdev,
  void ttm_mem_io_free(struct ttm_device *bdev,
  		     struct ttm_resource *mem)
  {
+	if (!mem)
+		return;
+
  	if (!mem->bus.offset && !mem->bus.addr)
  		return;