Skip to contentSkip to conversation

scripts/spdxcheck-test.sh: Drop python2

PATCH New Nishanth Menon 1 participant 1 message Jul 7, 2021 Licenses and spdx stuff

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/spdxcheck-test.sh: Drop python2

Since commit d0259c42abff ("spdxcheck.py: Use Python 3"), spdxcheck.py explicitly expects to run as python3 script, there is no further point in attempting to test with python2.

---

Also see checkpatch.pl patch
https://lore.kernel.org/lkml/[email protected]/

PS: While it may be debatable if *ever* there is going to be a python4 and hence leave the for loop alone (in addition to reducing the diffstat). I just took the path where I hope if we ever see that day, we pick one version.

 scripts/spdxcheck-test.sh | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
scripts/spdxcheck-test.sh +7 -9
index cfea6a0d1cc0..cb76324756bd 100644
@@ -1,12 +1,10 @@
 #!/bin/sh
 
-for PYTHON in python2 python3; do
-	# run check on a text and a binary file
-	for FILE in Makefile Documentation/logo.gif; do
-		$PYTHON scripts/spdxcheck.py $FILE
-		$PYTHON scripts/spdxcheck.py - < $FILE
-	done
-
-	# run check on complete tree to catch any other issues
-	$PYTHON scripts/spdxcheck.py > /dev/null
+# run check on a text and a binary file
+for FILE in Makefile Documentation/logo.gif; do
+	python3 scripts/spdxcheck.py $FILE
+	python3 scripts/spdxcheck.py - < $FILE
 done
+
+# run check on complete tree to catch any other issues
+python3 scripts/spdxcheck.py > /dev/null
Signature · 1 line
2.32.0