remote/memory: Replace share parameter with ram_flags
PATCH 1/1 remote/memory: Replace share parameter with ram_flags
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() in the hw/remote/memory.c.
--- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +1 -1
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) subregion =g_new (MemoryRegion,1 );memory_region_init_ram_from_fd (subregion,NULL , name, sysmem_info->sizes[region], - true, msg->fds[region], +RAM_SHARED , msg->fds[region], sysmem_info->offsets[region], errp);
Signature · 1 line
2.29.2.334.gfaefdd61ec
Quoted 2 lines · Yang Zhong
The commit(d5015b80) missed the
ram_flagstomemory_region_init_ram_from_fd()in thehw/remote/memory.c.
Yes, seems like that call was added just after I crafted my patches:
Thanks!
Quoted 20 lines
Signed-off-by Yang Zhong <[email protected]>--- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/remote/memory.c +1
-1@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) subregion =g_new (MemoryRegion,1 );memory_region_init_ram_from_fd (subregion,NULL , name, sysmem_info->sizes[region], - true, msg->fds[region], +RAM_SHARED , msg->fds[region], sysmem_info->offsets[region], errp);
Signature · 3 lines
Thanks, David / dhildenb
Quoted 10 lines · David Hildenbrand
Quoted 2 lines · Yang Zhong
The commit(d5015b80) missed the
ram_flagstomemory_region_init_ram_from_fd()in thehw/remote/memory.c.Yes, seems like that call was added just after I crafted my patches:
Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to
qemu_ram_alloc_from_fd()")Reviewed-by David Hildenbrand <[email protected]>
Thanks David, if there is not any other comments, i will send the new version according to your commit info. thanks!
Yang
Quoted 27 lines
Thanks!
Quoted 19 lines
Signed-off-by Yang Zhong <[email protected]>--- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/remote/memory.c +1
-1@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) subregion =g_new (MemoryRegion,1 );memory_region_init_ram_from_fd (subregion,NULL , name, sysmem_info->sizes[region], - true, msg->fds[region], +RAM_SHARED , msg->fds[region], sysmem_info->offsets[region], errp);Signature · 3 lines
Thanks, David / dhildenb
Quoted 4 lines · Yang Zhong
The commit(d5015b80) missed the
ram_flagstomemory_region_init_ram_from_fd()in thehw/remote/memory.c.Signed-off-by Yang Zhong <[email protected]>
Signature · 1 line
Peter Xu