Skip to contentSkip to conversation

tracing/selftests: Add tests to test histogram sym and sym-offset modifiers

PATCH In review Steven Rostedt 3 participants 3 messages Jul 7, 2021 – Jul 8, 2021

Subsystems (2)
lore
Share & tools
lore

Steven Rostedt

author maintainer
#0 lore raw

PATCH 1/1 tracing/selftests: Add tests to test histogram sym and sym-offset modifiers

From: "Steven Rostedt (VMware)" <[email protected]>

Add a test to the tracing selftests that will catch if the .sym or .sym-offset modifiers break in the future.

---
 .../ftrace/test.d/trigger/trigger-hist.tc      | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc +18 -0
index 2950bfbc6fce..adae72665500 100644
@@ -39,6 +39,24 @@ grep "parent_comm: $COMM" events/sched/sched_process_fork/hist > /dev/null || \
 
 reset_trigger
 
+echo "Test histogram with sym modifier"
+
+echo 'hist:keys=call_site.sym' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]* *}' events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym modifier on kmalloc call_site did not work"
+
+reset_trigger
+
+echo "Test histogram with sym-offset modifier"
+
+echo 'hist:keys=call_site.sym-offset' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]*+0x[0-9a-f][0-9a-f]*' events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym-offset modifier on kmalloc call_site did not work"
+
+reset_trigger
+
 echo "Test histogram with sort key"
 
 echo 'hist:keys=parent_pid,child_pid:sort=child_pid.ascending' > events/sched/sched_process_fork/trigger
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#1 lore raw
Quoted 44 lines · Steven Rostedt

From: "Steven Rostedt (VMware)" <[email protected]>

Add a test to the tracing selftests that will catch if the .sym or .sym-offset modifiers break in the future.

---
 .../ftrace/test.d/trigger/trigger-hist.tc      | 18
++++++++++++++++++
 1 file changed, 18 insertions(+)
(quoted diff) +0 -0

hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger- hist.tc
index 2950bfbc6fce..adae72665500 100644

tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc +18 -0
@@ -39,6 +39,24 @@ grep "parent_comm: $COMM"
 events/sched/sched_process_fork/hist > /dev/null || \
 
 reset_trigger
 
+echo "Test histogram with sym modifier"
+
+echo 'hist:keys=call_site.sym' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]* *}'
 events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym modifier on kmalloc call_site did not work"
+
+reset_trigger
+
+echo "Test histogram with sym-offset modifier"
+
+echo 'hist:keys=call_site.sym-offset' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]*+0x[0-
 9a-f][0-9a-f]*' events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym-offset modifier on kmalloc call_site did not work"
+
+reset_trigger
+

echo "Test histogram with sort key"

Quoted 2 lines

echo 'hist:keys=parent_pid,child_pid:sort=child_pid.ascending' >
events/sched/sched_process_fork/trigger

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Steven Rostedt
Quoted 6 lines · On Wed, 7 Jul 2021 12:14:51 -0400 Steven Rostedt <[email protected]> wrote:

From: "Steven Rostedt (VMware)" <[email protected]>

Add a test to the tracing selftests that will catch if the .sym or .sym-offset modifiers break in the future.

Looks good to me.

Thank you!

Quoted 36 lines
---
 .../ftrace/test.d/trigger/trigger-hist.tc      | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
tools/testing/selftests/ftrace/test.d/trigger/trigger-hist.tc +18 -0
index 2950bfbc6fce..adae72665500 100644
@@ -39,6 +39,24 @@ grep "parent_comm: $COMM" events/sched/sched_process_fork/hist > /dev/null || \
 
 reset_trigger
 
+echo "Test histogram with sym modifier"
+
+echo 'hist:keys=call_site.sym' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]* *}' events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym modifier on kmalloc call_site did not work"
+
+reset_trigger
+
+echo "Test histogram with sym-offset modifier"
+
+echo 'hist:keys=call_site.sym-offset' > events/kmem/kmalloc/trigger
+for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done
+grep '{ call_site: \[[0-9a-f][0-9a-f]*\] [_a-zA-Z][_a-zA-Z]*+0x[0-9a-f][0-9a-f]*' events/kmem/kmalloc/hist > /dev/null || \
+    fail "sym-offset modifier on kmalloc call_site did not work"
+
+reset_trigger
+
 echo "Test histogram with sort key"
 
 echo 'hist:keys=parent_pid,child_pid:sort=child_pid.ascending' > events/sched/sched_process_fork/trigger
Signature · 1 line
2.31.1
Signature · 1 line
Masami Hiramatsu <[email protected]>