Skip to contentSkip to conversation

drm/amdgpu/display: add support for multiple backlights

PATCH Superseded Alex Deucher 1 participant 1 message Jul 8, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/display: add support for multiple backlights

On platforms that support multiple backlights, register each one separately. This lets us manage them independently rather than registering a single backlight and applying the same settings to both.

---

Does anyone have a multi-eDP board to test this?

drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 146 ++++++++++--------
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   4 +-
 3 files changed, 82 insertions(+), 70 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +1 -1
index 84a1b4bc9bb4..eb5969dc6b68 100644
@@ -854,7 +854,7 @@ int amdgpu_acpi_init(struct amdgpu_device *adev)
 #if defined(CONFIG_DRM_AMD_DC)
 			struct amdgpu_display_manager *dm = &adev->dm;
 			if (dm->backlight_dev)
-				atif->bd = dm->backlight_dev;
+				atif->bd = dm->backlight_dev[0];
 #endif
 		} else {
 			struct drm_encoder *tmp;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +79 -67

276 lines not on this page · raw message

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h +2 -2
index 57996c364940..4c7ad106353d 100644
@@ -365,13 +365,13 @@ struct amdgpu_display_manager {
 
 	spinlock_t irq_handler_list_table_lock;
 
-	struct backlight_device *backlight_dev;
+	struct backlight_device *backlight_dev[AMDGPU_DM_MAX_NUM_EDP];
 
 	const struct dc_link *backlight_link[AMDGPU_DM_MAX_NUM_EDP];
 
 	uint8_t num_of_edps;
 
-	struct amdgpu_dm_backlight_caps backlight_caps;
+	struct amdgpu_dm_backlight_caps backlight_caps[AMDGPU_DM_MAX_NUM_EDP];
 
 	struct mod_freesync *freesync_module;
 #ifdef CONFIG_DRM_AMD_DC_HDCP
Signature · 6 lines
2.31.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx