Skip to contentSkip to conversation

Kconfig.boot: Make 0x0 the default SYS_TEXT_BASE for POSITION_INDEPENDENT

PATCH In review Tom Rini 2 participants 4 messages Jul 9, 2021 – Jul 23, 2021

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Kconfig.boot: Make 0x0 the default SYS_TEXT_BASE for POSITION_INDEPENDENT

When we build U-Boot with POSITION_INDEPENDENT we must have SYS_TEXT_BASE be set to zero. Make this the default in that case.

---
 common/Kconfig.boot | 1 +
 1 file changed, 1 insertion(+)
common/Kconfig.boot +1 -0
index 89a3161f1faa..f078743f06ed 100644
@@ -358,6 +358,7 @@ config HAVE_SYS_TEXT_BASE
 
 config SYS_TEXT_BASE
 	depends on HAVE_SYS_TEXT_BASE
+	default 0x0 if POSITION_INDEPENDENT
 	default 0x80800000 if ARCH_OMAP2PLUS || ARCH_K3
 	default 0x4a000000 if ARCH_SUNXI && !MACH_SUN9I && !MACH_SUN8I_V3S
 	default 0x2a000000 if ARCH_SUNXI && MACH_SUN9I
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines

From: Tom Rini <[email protected]>
Date: Fri, 9 Jul 2021 10:39:21 -0400

When we build U-Boot with POSITION_INDEPENDENT we must have SYS_TEXT_BASE be set to zero. Make this the default in that case.

Makes sense. I had to set this for the (still in progress) Apple M1 support. So:

P.S. Any chance of picking up the first diff I sent a while ago that
was acked by Marc Zyngier?

https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Quoted 21 lines
---
 common/Kconfig.boot | 1 +
 1 file changed, 1 insertion(+)
common/Kconfig.boot +1 -0
index 89a3161f1faa..f078743f06ed 100644
@@ -358,6 +358,7 @@ config HAVE_SYS_TEXT_BASE
 
 config SYS_TEXT_BASE
 	depends on HAVE_SYS_TEXT_BASE
+	default 0x0 if POSITION_INDEPENDENT
 	default 0x80800000 if ARCH_OMAP2PLUS || ARCH_K3
 	default 0x4a000000 if ARCH_SUNXI && !MACH_SUN9I && !MACH_SUN8I_V3S
 	default 0x2a000000 if ARCH_SUNXI && MACH_SUN9I
Signature · 1 line
2.17.1
author
#2 lore raw
Quoted 9 lines · Mark Kettenis
Quoted 5 lines

From: Tom Rini <[email protected]>
Date: Fri, 9 Jul 2021 10:39:21 -0400

When we build U-Boot with POSITION_INDEPENDENT we must have SYS_TEXT_BASE be set to zero. Make this the default in that case.

Makes sense. I had to set this for the (still in progress) Apple M1 support. So:

Quoted 7 lines

P.S. Any chance of picking up the first diff I sent a while ago that
was acked by Marc Zyngier?

https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Ah that, yeah, I need to get a PR going of general ARM changes, I should do that today, thanks.

Signature · 1 line
Tom