drm/mipi: set fwnode when a mipi_dsi_device registers itself
Subsystems (2)
PATCH 1/1 drm/mipi: set fwnode when a mipi_dsi_device registers itself
This is needed for fw_devlink to work properly with MIPI DSI devices. Without setting the device's fwnode, the sync state framework isn't able to properly track device links between the MIPI DSI device and its suppliers which may result in its supplier probing before the mipi device.
--- drivers/gpu/drm/drm_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_mipi_dsi.c +1 -0
@@ -222,6 +222,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, } dsi->dev.of_node = info->node; + dsi->dev.fwnode =of_fwnode_handle (info->node); dsi->channel = info->channel;strlcpy (dsi->name, info->type,sizeof (dsi->name));
Signature · 1 line
2.32.0.93.g670b81a890-goog
Hi William,
Thanks for catching this.
Quoted 6 lines · Will McVicker
This is needed for
fw_devlinkto work properly with MIPI DSI devices. Without setting the device's fwnode, the sync state framework isn't able to properly track device links between the MIPI DSI device and its suppliers which may result in its supplier probing before the mipi device.
I think it'd be more accurate if the commit text is something like:
drm/mipi: set fwnode when a mipi_dsi_device is registered
This allows the fw_devlink feature to work across mipi_dsi bus devices too. This feature avoid unnecessary probe deferrals of mipi_dsi devices, defers consumers ofmipi_dsi devices till the mipi_dsi devices probe, and allows mipi_dsi drivers to implement sync_state() callbacks.
Thanks,
Saravana
Quoted 22 lines
Suggested-by Saravana Kannan <[email protected]>Signed-off-by Will McVicker <[email protected]>--- drivers/gpu/drm/drm_mipi_dsi.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/drm_mipi_dsi.c +1
-1@@ -222,6 +222,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, } dsi->dev.of_node = info->node; + dsi->dev.fwnode =of_fwnode_handle (info->node); dsi->channel = info->channel;strlcpy (dsi->name, info->type,sizeof (dsi->name)); --2.32.0.93.g670b81a890-goog