Skip to contentSkip to conversation

smegw01: Allow booting the Yocto image by default

PATCH In review Fabio Estevam 3 participants 10 messages Jun 15, 2021 – Jul 12, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 smegw01: Allow booting the Yocto image by default

On the Yocto image there is a single partition and the kernel and dtb are present in the 'boot' directory.

Change it accordingly so that the board can boot the Yocto image by default.

Use the generic 'load' command instead, which is able to read from an ext4 partition.

---
 include/configs/smegw01.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/smegw01.h +3 -3
index 50f00136ac46..a92c583c8669 100644
@@ -29,11 +29,11 @@
 	"bootm_size=0x10000000\0" \
 	"mmcdev=0\0" \
 	"mmcpart=1\0" \
-	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
+	"mmcroot=/dev/mmcblk0p1 rootwait rw\0" \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=${mmcroot}\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdtfile}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run mmcargs; " \
 		"if run loadfdt; then " \
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/3 smegw01: Re-sync the defconfig

Re-sync the defconfig by doing:

make smegw01_defconfig
make savedefconfig
cp defconfig configs/smegw01_defconfig

---
 configs/smegw01_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/smegw01_defconfig +1 -1
index aa10577a9f3f..9bfaa010ae77 100644
@@ -6,12 +6,12 @@ CONFIG_SYS_MEMTEST_END=0xa0000000
 CONFIG_ENV_SIZE=0x2000
 CONFIG_ENV_OFFSET=0xC0000
 CONFIG_DM_GPIO=y
+CONFIG_DEFAULT_DEVICE_TREE="imx7d-smegw01"
 CONFIG_TARGET_SMEGW01=y
 CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
 # CONFIG_ARMV7_VIRT is not set
 CONFIG_IMX_RDC=y
 CONFIG_IMX_BOOTAUX=y
-CONFIG_DEFAULT_DEVICE_TREE="imx7d-smegw01"
 CONFIG_FIT=y
 CONFIG_FIT_VERBOSE=y
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/storopack/smegw01/imximage.cfg"
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 2/3] smegw01: Re-sync the defconfig

Quoted 10 lines · Fabio Estevam

Re-sync the defconfig by doing:

make smegw01_defconfig
make savedefconfig
cp defconfig configs/smegw01_defconfig

---
 configs/smegw01_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This will likely conflict with the next resync I do, and since it's not part of migrating a Kconfig option or similar I don't think this ends up being a win.

Signature · 1 line
Tom
#3 lore raw

PATCH 3/3 smegw01: Select the CMD_UNZIP option

In reply to Fabio Estevam

Select the CMD_UNZIP option so that the 'gzwrite' command can be used to flash .gz image into the eMMC.

---
 configs/smegw01_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/smegw01_defconfig +1 -0
index 9bfaa010ae77..75fd5bc24a81 100644
@@ -21,6 +21,7 @@ CONFIG_CMD_BOOTZ=y
 # CONFIG_CMD_IMI is not set
 # CONFIG_CMD_XIMG is not set
 CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_UNZIP=y
 CONFIG_CMD_DFU=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/3 smegw01: Select the CMD_UNZIP option

Quoted 3 lines

Select the CMD_UNZIP option so that the 'gzwrite' command can be used to flash .gz image into the eMMC.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#5 lore raw

PATCH 3/3 smegw01: Select the CMD_UNZIP option

In reply to Fabio Estevam
Quoted 3 lines

Select the CMD_UNZIP option so that the 'gzwrite' command can be used to flash .gz image into the eMMC.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#6 lore raw
In reply to Fabio Estevam
Quoted 23 lines · Fabio Estevam

On the Yocto image there is a single partition and the kernel and dtb are present in the 'boot' directory.

Change it accordingly so that the board can boot the Yocto image by default.

Use the generic 'load' command instead, which is able to read from an ext4 partition.

---
 include/configs/smegw01.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/smegw01.h +0 -1
index 50f00136ac46..a92c583c8669 100644
@@ -29,11 +29,11 @@
 	"bootm_size=0x10000000\0" \
 	"mmcdev=0\0" \
 	"mmcpart=1\0" \
-	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \

include/configs/smegw01.h line 39

Quoted 10 lines
include/configs/smegw01.h +3 -2
+	"mmcroot=/dev/mmcblk0p1 rootwait rw\0" \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=${mmcroot}\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdtfile}\0" \
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
 	"mmcboot=echo Booting from mmc ...; " \
 		"run mmcargs; " \
 		"if run loadfdt; then " \

Shouldn't this be using the generic distro boot and then generating an extlinux.conf in OE? Thanks!

Signature · 1 line
Tom
#7 lore raw

Hi,

just for the note because there is an open comment and I applied it:

Quoted 30 lines · Tom Rini
Quoted 28 lines · Fabio Estevam

On the Yocto image there is a single partition and the kernel and dtb are present in the 'boot' directory.

Change it accordingly so that the board can boot the Yocto image by default.

Use the generic 'load' command instead, which is able to read from an ext4 partition.

---
  include/configs/smegw01.h | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
include/configs/smegw01.h +1 -3
index 50f00136ac46..a92c583c8669 100644
@@ -29,11 +29,11 @@
  	"bootm_size=0x10000000\0" \
  	"mmcdev=0\0" \
  	"mmcpart=1\0" \
-	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
+	"mmcroot=/dev/mmcblk0p1 rootwait rw\0" \
  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
  		"root=${mmcroot}\0" \
-	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
-	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdtfile}\0" \
Quoted 9 lines

include/configs/smegw01.h line 39

Quoted 5 lines
include/configs/smegw01.h +2 -0
+	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
+	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
  	"mmcboot=echo Booting from mmc ...; " \
  		"run mmcargs; " \
  		"if run loadfdt; then " \

Shouldn't this be using the generic distro boot and then generating an extlinux.conf in OE? Thanks!

This is not an evaluation board but a customer's project with strict rules about environment (secure boot is required) and with a short list of variable that can be modified (from both U-Boot and user space). A generic distro boot is then unwanted, and just a few set of variables are allowed in this project. An extlinux.conf is not allowed. So I merged it, I have not ignored the comment, I had to answer before, sorry for that.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#8 lore raw

PATCH 1/3 smegw01: Allow booting the Yocto image by default

In reply to Fabio Estevam
Quoted 7 lines

On the Yocto image there is a single partition and the kernel and dtb are present in the 'boot' directory.
Change it accordingly so that the board can boot the Yocto image by default.
Use the generic 'load' command instead, which is able to read from an ext4 partition.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#9 lore raw

PATCH 1/3 smegw01: Allow booting the Yocto image by default

In reply to Fabio Estevam
Quoted 7 lines

On the Yocto image there is a single partition and the kernel and dtb are present in the 'boot' directory.
Change it accordingly so that the board can boot the Yocto image by default.
Use the generic 'load' command instead, which is able to read from an ext4 partition.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================