Skip to contentSkip to conversation

scsi: fas216: Fix a build error

PATCH Applied Bart Van Assche 3 participants 3 messages Jul 11, 2021 – Jul 13, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: fas216: Fix a build error

Use SAM_STAT_GOOD instead of GOOD since GOOD has been removed.

Cc Hannes Reinecke <[email protected]>
Fixes 3d45cefc8edd ("scsi: core: Drop obsolete Linux-specific SCSI status codes")
Fixes df1303147649 ("scsi: fas216: Use get_status_byte() to avoid using Linux-specific status codes")
---
 drivers/scsi/arm/fas216.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/arm/fas216.c +1 -1
index 30ed3d23635a..6baa9b36367d 100644
@@ -2010,7 +2010,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt,
 		   "request sense complete, result=0x%04x%02x%02x",
 		   result, SCpnt->SCp.Message, SCpnt->SCp.Status);
 
-	if (result != DID_OK || SCpnt->SCp.Status != GOOD)
+	if (result != DID_OK || SCpnt->SCp.Status != SAM_STAT_GOOD)
 		/*
 		 * Something went wrong.  Make sure that we don't
 		 * have valid data in the sense buffer that could
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Bart Van Assche

Use SAM_STAT_GOOD instead of GOOD since GOOD has been removed.

Cc Hannes Reinecke <[email protected]>
Fixes 3d45cefc8edd ("scsi: core: Drop obsolete Linux-specific SCSI status codes")
Fixes df1303147649 ("scsi: fas216: Use get_status_byte() to avoid using Linux-specific status codes")
---
  drivers/scsi/arm/fas216.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/arm/fas216.c +0 -0
index 30ed3d23635a..6baa9b36367d 100644

drivers/scsi/arm/fas216.c static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt, · line 2016

Quoted 8 lines
drivers/scsi/arm/fas216.c +1 -1
@@ -2010,7 +2010,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt,
  		   "request sense complete, result=0x%04x%02x%02x",
  		   result, SCpnt->SCp.Message, SCpnt->SCp.Status);
 
-	if (result != DID_OK || SCpnt->SCp.Status != GOOD)
+	if (result != DID_OK || SCpnt->SCp.Status != SAM_STAT_GOOD)
  		/*
  		 * Something went wrong.  Make sure that we don't
  		 * have valid data in the sense buffer that could

Thanks for spotting this.

Cheers,

Hannes

Signature · 4 lines
Dr. Hannes Reinecke                Kernel Storage Architect
[email protected]                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer